Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
C
cocoapods
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
gengmeiios
cocoapods
Commits
0994612e
Commit
0994612e
authored
Jan 03, 2015
by
Kyle Fuller
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[Podfile] Change the default spec repository to the master
Closes #2946
parent
8ba4d543
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
21 additions
and
5 deletions
+21
-5
CHANGELOG.md
CHANGELOG.md
+14
-0
analyzer.rb
lib/cocoapods/installer/analyzer.rb
+4
-2
analyzer_spec.rb
spec/unit/installer/analyzer_spec.rb
+3
-3
No files found.
CHANGELOG.md
View file @
0994612e
...
@@ -6,6 +6,14 @@ To install release candidates run `[sudo] gem install cocoapods --pre`
...
@@ -6,6 +6,14 @@ To install release candidates run `[sudo] gem install cocoapods --pre`
## Master
## Master
##### Breaking
*
Changes the default spec repositories used from all configured spec
repositories, to the master spec repository when no spec repositories
are explicitly configured in a Podfile.
[
Kyle Fuller
](
https://github.com/kylef
)
[
#2946
](
https://github.com/CocoaPods/CocoaPods/issues/2946
)
##### Enhancements
##### Enhancements
*
Xcodebuild warnings will now be reported as
`warning`
during linting
*
Xcodebuild warnings will now be reported as
`warning`
during linting
...
@@ -23,6 +31,12 @@ To install release candidates run `[sudo] gem install cocoapods --pre`
...
@@ -23,6 +31,12 @@ To install release candidates run `[sudo] gem install cocoapods --pre`
[
#2981
](
https://github.com/CocoaPods/CocoaPods/issues/2981
)
[
#2981
](
https://github.com/CocoaPods/CocoaPods/issues/2981
)
[
cocoapods-trunk#33
](
https://github.com/CocoaPods/cocoapods-trunk/issues/33
)
[
cocoapods-trunk#33
](
https://github.com/CocoaPods/cocoapods-trunk/issues/33
)
*
Clone the master spec repository when no spec repositories are explicitly
defined in the Podfile. This fixes problems using CocoaPods for the first
time without any explicit spec repositories.
[
Kyle Fuller
](
https://github.com/kylef
)
[
#2946
](
https://github.com/CocoaPods/CocoaPods/issues/2946
)
*
Xcodebuild warnings with the string
`error`
in them will no longer be
*
Xcodebuild warnings with the string
`error`
in them will no longer be
linted as errors if they are in fact warnings.
linted as errors if they are in fact warnings.
[
Hugo Tunius
](
https://github.com/K0nserv
)
[
Hugo Tunius
](
https://github.com/K0nserv
)
...
...
lib/cocoapods/installer/analyzer.rb
View file @
0994612e
...
@@ -465,7 +465,8 @@ module Pod
...
@@ -465,7 +465,8 @@ module Pod
# Returns the sources used to query for specifications
# Returns the sources used to query for specifications
#
#
# When no explicit Podfile sources are defined, this defaults to all
# When no explicit Podfile sources are defined, this defaults to the
# master spec repository.
# available sources ({SourcesManager.all}).
# available sources ({SourcesManager.all}).
#
#
# @return [Array<Source>] the sources to be used in finding
# @return [Array<Source>] the sources to be used in finding
...
@@ -475,7 +476,8 @@ module Pod
...
@@ -475,7 +476,8 @@ module Pod
@sources
||=
begin
@sources
||=
begin
sources
=
podfile
.
sources
sources
=
podfile
.
sources
if
sources
.
empty?
if
sources
.
empty?
SourcesManager
.
all
url
=
'https://github.com/CocoaPods/Specs.git'
[
SourcesManager
.
find_or_create_source_with_url
(
url
)]
else
else
sources
.
map
do
|
url
|
sources
.
map
do
|
url
|
SourcesManager
.
find_or_create_source_with_url
(
url
)
SourcesManager
.
find_or_create_source_with_url
(
url
)
...
...
spec/unit/installer/analyzer_spec.rb
View file @
0994612e
...
@@ -54,7 +54,7 @@ module Pod
...
@@ -54,7 +54,7 @@ module Pod
it
'updates the repositories by default'
do
it
'updates the repositories by default'
do
config
.
skip_repo_update
=
false
config
.
skip_repo_update
=
false
SourcesManager
.
expects
(
:update
).
twi
ce
SourcesManager
.
expects
(
:update
).
on
ce
@analyzer
.
analyze
@analyzer
.
analyze
end
end
...
@@ -552,9 +552,9 @@ module Pod
...
@@ -552,9 +552,9 @@ module Pod
describe
'#sources'
do
describe
'#sources'
do
describe
'when there are no explicit sources'
do
describe
'when there are no explicit sources'
do
it
'defaults to
all sources
'
do
it
'defaults to
the master spec repository
'
do
@analyzer
.
send
(
:sources
).
map
(
&
:url
).
should
==
@analyzer
.
send
(
:sources
).
map
(
&
:url
).
should
==
SourcesManager
.
all
.
map
(
&
:url
)
[
'https://github.com/CocoaPods/Specs.git'
]
end
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment