Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
C
cocoapods
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
gengmeiios
cocoapods
Commits
122c8d98
Commit
122c8d98
authored
Feb 25, 2015
by
Boris Bügling
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Make the filtering of frameworks warning work.
Logical expressions are hard.
parent
a06299dc
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
11 additions
and
3 deletions
+11
-3
validator.rb
lib/cocoapods/validator.rb
+2
-3
validator_spec.rb
spec/unit/validator_spec.rb
+9
-0
No files found.
lib/cocoapods/validator.rb
View file @
122c8d98
...
...
@@ -509,9 +509,8 @@ module Pod
def
parse_xcodebuild_output
(
output
)
lines
=
output
.
split
(
"
\n
"
)
selected_lines
=
lines
.
select
do
|
l
|
l
.
include?
(
'error: '
)
&&
(
l
!~
/frameworks only run on iOS 8/
)
&&
(
l
!~
/errors? generated\./
)
&&
(
l
!~
/error: \(null\)/
)
||
l
.
include?
(
'warning: '
)
&&
(
l
!~
/warnings? generated\./
)
||
l
.
include?
(
'error: '
)
&&
(
l
!~
/errors? generated\./
)
&&
(
l
!~
/error: \(null\)/
)
||
l
.
include?
(
'warning: '
)
&&
(
l
!~
/warnings? generated\./
)
&&
(
l
!~
/frameworks only run on iOS 8/
)
||
l
.
include?
(
'note: '
)
&&
(
l
!~
/expanded from macro/
)
end
selected_lines
.
map
do
|
l
|
...
...
spec/unit/validator_spec.rb
View file @
122c8d98
...
...
@@ -395,6 +395,15 @@ module Pod
validator
.
results
.
count
.
should
==
0
end
it
'does filter embedded frameworks warnings'
do
validator
=
Validator
.
new
(
podspec_path
,
SourcesManager
.
master
.
map
(
&
:url
))
validator
.
stubs
(
:check_file_patterns
)
validator
.
stubs
(
:xcodebuild
).
returns
(
'ld: warning: embedded dylibs/frameworks only run on iOS 8 or later.'
)
validator
.
stubs
(
:validate_url
)
validator
.
validate
validator
.
results
.
count
.
should
==
0
end
describe
'file pattern validation'
do
it
'checks for file patterns'
do
file
=
write_podspec
(
stub_podspec
(
/.*source_files.*/
,
'"source_files": "wrong_paht.*",'
))
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment