Commit 2b500a99 authored by Kyle Fuller's avatar Kyle Fuller

[linter] Remove logic around slashes in URLS

Fix is a bug with nap and has been fixed in nap.

https://github.com/Fingertips/nap/pull/4
Fixes #1998
parent 28a45334
...@@ -83,7 +83,7 @@ PATH ...@@ -83,7 +83,7 @@ PATH
colored (~> 1.2) colored (~> 1.2)
escape (~> 0.0.4) escape (~> 0.0.4)
json_pure (~> 1.8) json_pure (~> 1.8)
nap (~> 0.5) nap (~> 0.7)
open4 (~> 1.3) open4 (~> 1.3)
xcodeproj (~> 0.16.0) xcodeproj (~> 0.16.0)
...@@ -127,7 +127,7 @@ GEM ...@@ -127,7 +127,7 @@ GEM
mocha-on-bacon (0.2.2) mocha-on-bacon (0.2.2)
mocha (>= 0.13.0) mocha (>= 0.13.0)
multi_json (1.9.2) multi_json (1.9.2)
nap (0.6.0) nap (0.7.0)
netrc (0.7.7) netrc (0.7.7)
notify (0.5.2) notify (0.5.2)
open4 (1.3.3) open4 (1.3.3)
......
...@@ -38,7 +38,7 @@ s.files = Dir["lib/**/*.rb"] + %w{ bin/pod bin/sandbox-pod README.md LICENSE CHA ...@@ -38,7 +38,7 @@ s.files = Dir["lib/**/*.rb"] + %w{ bin/pod bin/sandbox-pod README.md LICENSE CHA
s.add_runtime_dependency 'json_pure', '~> 1.8' s.add_runtime_dependency 'json_pure', '~> 1.8'
s.add_runtime_dependency 'open4', '~> 1.3' s.add_runtime_dependency 'open4', '~> 1.3'
s.add_runtime_dependency 'activesupport', '>= 3.2.15', '< 4' s.add_runtime_dependency 'activesupport', '>= 3.2.15', '< 4'
s.add_runtime_dependency 'nap', '~> 0.5' s.add_runtime_dependency 'nap', '~> 0.7'
s.add_development_dependency 'bacon', '~> 1.1' s.add_development_dependency 'bacon', '~> 1.1'
......
...@@ -228,7 +228,6 @@ module Pod ...@@ -228,7 +228,6 @@ module Pod
require 'rest' require 'rest'
homepage = spec.homepage homepage = spec.homepage
return unless homepage return unless homepage
homepage += '/' unless homepage.end_with?('/')
begin begin
resp = ::REST.head(homepage) resp = ::REST.head(homepage)
......
...@@ -102,13 +102,6 @@ module Pod ...@@ -102,13 +102,6 @@ module Pod
@sut.results.map(&:to_s).first.should.match /The homepage is not reachable/ @sut.results.map(&:to_s).first.should.match /The homepage is not reachable/
end end
it "checks if that the homepage validates without a trailing slash" do
WebMock::API.stub_request(:head, /banana-corp.local/).to_return(:status => 200)
Specification.any_instance.stubs(:homepage).returns('http://banana-corp.local')
@sut.validate
@sut.results.should.be.empty?
end
it "indicates if it was not able to validate the homepage" do it "indicates if it was not able to validate the homepage" do
WebMock::API.stub_request(:head, 'banana-corp.local').to_raise(SocketError) WebMock::API.stub_request(:head, 'banana-corp.local').to_raise(SocketError)
Specification.any_instance.stubs(:homepage).returns('http://banana-corp.local/') Specification.any_instance.stubs(:homepage).returns('http://banana-corp.local/')
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment