[SourcesManager] Improve search performance

lib/cocoapods/sources_manager.rb

@@ -59,6 +59,7 @@ module Pod
       # @return [Array<Set>]  The sets that contain the search term.
       #
       def search_by_name(query, full_text_search = false)
+        if full_text_search
           set_names = []
           updated_search_index.each do |name, set_data|
             text = name.dup
@@ -69,8 +70,10 @@ module Pod
             end
             set_names << name if text.downcase.include?(query.downcase)
           end
-
           sets = set_names.sort.map { |name| aggregate.represenative_set(name) }
+        else
+          sets = aggregate.search_by_name(query, false)
+        end
         if sets.empty?
           extra = ", author, summary, or description" if full_text_search
           raise Informative, "Unable to find a pod with name#{extra} matching `#{query}`"
@@ -86,9 +89,13 @@ module Pod
       #   - description
       #   - authors
       #
+      # @note   This operation is fairly expensive, because of the YAML
+      #         conversion.
+      #
       # @return [Hash{String => String}] The up to date search data.
       #
       def updated_search_index
+        unless @updated_search_index
           if search_index_path.exist?
             stored_index = YAML.load(search_index_path.read)
             if stored_index && stored_index.is_a?(Hash)
@@ -101,7 +108,9 @@ module Pod
           end
 
           File.open(search_index_path, 'w') {|f| f.write(search_index.to_yaml) }
-        search_index
+          @updated_search_index = search_index
+        end
+        @updated_search_index
       end
 
       # @return [Pathname] The path where the search index should be stored.