Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
C
cocoapods
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
gengmeiios
cocoapods
Commits
4638615b
Commit
4638615b
authored
Dec 30, 2015
by
Samuel Giddins
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update for removal of docset_url attribute
parent
b611ae93
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
1 addition
and
27 deletions
+1
-27
Gemfile.lock
Gemfile.lock
+1
-1
validator.rb
lib/cocoapods/validator.rb
+0
-7
validator_spec.rb
spec/unit/validator_spec.rb
+0
-19
No files found.
Gemfile.lock
View file @
4638615b
...
@@ -7,7 +7,7 @@ GIT
...
@@ -7,7 +7,7 @@ GIT
GIT
GIT
remote: https://github.com/CocoaPods/Core.git
remote: https://github.com/CocoaPods/Core.git
revision:
ca0a5d504357e48da31b274430a966d64fd6207
8
revision:
0c386062a4b72b3eb487129f6c8854bcd8ea1b6
8
branch: master
branch: master
specs:
specs:
cocoapods-core (0.39.0)
cocoapods-core (0.39.0)
...
...
lib/cocoapods/validator.rb
View file @
4638615b
...
@@ -257,7 +257,6 @@ module Pod
...
@@ -257,7 +257,6 @@ module Pod
validate_screenshots
(
spec
)
validate_screenshots
(
spec
)
validate_social_media_url
(
spec
)
validate_social_media_url
(
spec
)
validate_documentation_url
(
spec
)
validate_documentation_url
(
spec
)
validate_docset_url
(
spec
)
valid
=
spec
.
available_platforms
.
send
(
fail_fast
?
:
all?
:
:each
)
do
|
platform
|
valid
=
spec
.
available_platforms
.
send
(
fail_fast
?
:
all?
:
:each
)
do
|
platform
|
UI
.
message
"
\n\n
#{
spec
}
- Analyzing on
#{
platform
}
platform."
.
green
.
reversed
UI
.
message
"
\n\n
#{
spec
}
- Analyzing on
#{
platform
}
platform."
.
green
.
reversed
...
@@ -342,12 +341,6 @@ module Pod
...
@@ -342,12 +341,6 @@ module Pod
validate_url
(
spec
.
documentation_url
)
if
spec
.
documentation_url
validate_url
(
spec
.
documentation_url
)
if
spec
.
documentation_url
end
end
# Performs validations related to the `docset_url` attribute.
#
def
validate_docset_url
(
spec
)
validate_url
(
spec
.
docset_url
)
if
spec
.
docset_url
end
def
setup_validation_environment
def
setup_validation_environment
validation_dir
.
rmtree
if
validation_dir
.
exist?
validation_dir
.
rmtree
if
validation_dir
.
exist?
validation_dir
.
mkpath
validation_dir
.
mkpath
...
...
spec/unit/validator_spec.rb
View file @
4638615b
...
@@ -265,25 +265,6 @@ module Pod
...
@@ -265,25 +265,6 @@ module Pod
@validator
.
results
.
map
(
&
:to_s
).
first
.
should
.
match
/The URL (.*) is not reachable/
@validator
.
results
.
map
(
&
:to_s
).
first
.
should
.
match
/The URL (.*) is not reachable/
end
end
end
end
describe
'docset URL validation'
do
before
do
@validator
.
stubs
(
:validate_homepage
)
end
it
'checks if the docset URL is valid'
do
Specification
.
any_instance
.
stubs
(
:docset_url
).
returns
(
'http://banana-corp.local/'
)
WebMock
::
API
.
stub_request
(
:head
,
/banana-corp.local/
).
to_return
(
:status
=>
200
)
@validator
.
validate
@validator
.
results
.
should
.
be
.
empty?
end
it
"should fail validation if it wasn't able to validate the URL"
do
Specification
.
any_instance
.
stubs
(
:docset_url
).
returns
(
'http://banana-corp.local/not-found'
)
@validator
.
validate
@validator
.
results
.
map
(
&
:to_s
).
first
.
should
.
match
/The URL (.*) is not reachable/
end
end
end
end
it
'respects the no clean option'
do
it
'respects the no clean option'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment