[Validator] Cleanup spec

spec/unit/validator_spec.rb

@@ -32,96 +32,103 @@ module Pod
 
     #-------------------------------------------------------------------------#
 
+    describe "Quick mode" do
       it "validates a correct podspec" do
-      validator = Validator.new(podspec_path)
-      validator.quick = true
-      validator.validate
-      validator.results.should == []
-      validator.validated?.should.be.true
+        sut = Validator.new(podspec_path)
+        sut.quick = true
+        sut.validate
+        sut.results.should == []
+        sut.validated?.should.be.true
       end
 
       it "lints the podspec during validation" do
         podspec = stub_podspec(/s.name.*$/, 's.name = "TEST"')
         file = write_podspec(podspec)
-      validator = Validator.new(file)
-      validator.quick = true
-      validator.validate
-      validator.results.map(&:to_s).first.should.match /should match the name/
-      validator.validated?.should.be.false
+        sut = Validator.new(file)
+        sut.quick = true
+        sut.validate
+        sut.results.map(&:to_s).first.should.match /should match the name/
+        sut.validated?.should.be.false
       end
 
-    it "uses xcodebuild to generate notes and warnings" do
-      validator = Validator.new(podspec_path)
-      validator.stubs(:check_file_patterns)
-      validator.stubs(:xcodebuild).returns("file.m:1:1: warning: direct access to objective-c's isa is deprecated")
-      validator.validate
-      first = validator.results.map(&:to_s).first
-      first.should.include "[xcodebuild]"
-      validator.result_type.should == :note
+      it "respects quick mode" do
+        file = write_podspec(stub_podspec)
+        sut = Validator.new(file)
+        sut.quick = true
+        sut.expects(:perform_extensive_analysis).never
+        sut.validate
       end
 
-    it "checks for file patterns" do
-      file = write_podspec(stub_podspec(/s\.source_files = 'JSONKit\.\*'/, "s.source_files = 'wrong_paht.*'"))
-      validator = Validator.new(file)
-      validator.stubs(:build_pod)
-      validator.validate
-      validator.results.map(&:to_s).first.should.match /source_files.*did not match/
-      validator.result_type.should == :error
+      it "respects the only errors option" do
+        podspec = stub_podspec(/s.summary.*/, "s.summary = 'A short description of'")
+        file = write_podspec(podspec)
+        sut = Validator.new(file)
+        sut.quick = true
+        sut.only_errors = true
+        sut.validate
+        sut.results.map(&:to_s).first.should.match /summary.*meaningful/
+        sut.validated?.should.be.true
       end
-
-    it "validates a podspec with dependencies" do
-      podspec = stub_podspec(/s.name.*$/, 's.name = "ZKit"')
-      podspec.gsub!(/s.requires_arc/, "s.dependency 'SBJson', '~> 3.2'\n  s.requires_arc")
-      podspec.gsub!(/s.license.*$/, 's.license = "Public Domain"')
-      file = write_podspec(podspec, "ZKit.podspec")
-
-      spec = Specification.from_file(file)
-      validator = Validator.new(spec)
-      validator.validate
-      validator.validated?.should.be.true
     end
 
-    #--------------------------------------#
+    #-------------------------------------------------------------------------#
 
-    it "respects quick mode" do
+    describe "Extensive analysis" do
+      it "respects the no clean option" do
         file = write_podspec(stub_podspec)
-      validator = Validator.new(file)
-      validator.quick = true
-      validator.expects(:perform_extensive_analysis).never
-      validator.validate
+        sut = Validator.new(file)
+        sut.no_clean = true
+        sut.validate
+        sut.validation_dir.should.exist
       end
 
-    it "respects the no clean option" do
-      file = write_podspec(stub_podspec)
-      validator = Validator.new(file)
-      validator.no_clean = true
-      validator.validate
-      validator.validation_dir.should.exist
+      it "uses the deployment target of the specification" do
+        sut = Validator.new(podspec_path)
+        podfile = sut.send(:podfile_from_spec, :ios, '5.0')
+        dependency = podfile.target_definitions['Pods'].dependencies.first
+        dependency.external_source.has_key?(:podspec).should.be.true
       end
 
       it "respects the local option" do
-      validator = Validator.new(podspec_path)
-      podfile = validator.send(:podfile_from_spec, :ios, '5.0')
+        sut = Validator.new(podspec_path)
+        podfile = sut.send(:podfile_from_spec, :ios, '5.0')
         deployment_target = podfile.target_definitions['Pods'].platform.deployment_target
         deployment_target.to_s.should == "5.0"
       end
 
-    it "respects the only errors option" do
-      podspec = stub_podspec(/s.summary.*/, "s.summary = 'A short description of'")
-      file = write_podspec(podspec)
-      validator = Validator.new(file)
-      validator.quick = true
-      validator.only_errors = true
-      validator.validate
-      validator.results.map(&:to_s).first.should.match /summary.*meaningful/
-      validator.validated?.should.be.true
+      it "uses xcodebuild to generate notes and warnings" do
+        sut = Validator.new(podspec_path)
+        sut.stubs(:check_file_patterns)
+        sut.stubs(:xcodebuild).returns("file.m:1:1: warning: direct access to objective-c's isa is deprecated")
+        sut.validate
+        first = sut.results.map(&:to_s).first
+        first.should.include "[xcodebuild]"
+        sut.result_type.should == :note
       end
 
-    it "uses the deployment target of the specification" do
-      validator = Validator.new(podspec_path)
-      podfile = validator.send(:podfile_from_spec, :ios, '5.0')
-      dependency = podfile.target_definitions['Pods'].dependencies.first
-      dependency.external_source.has_key?(:podspec).should.be.true
+      it "checks for file patterns" do
+        file = write_podspec(stub_podspec(/s\.source_files = 'JSONKit\.\*'/, "s.source_files = 'wrong_paht.*'"))
+        sut = Validator.new(file)
+        sut.stubs(:build_pod)
+        sut.validate
+        sut.results.map(&:to_s).first.should.match /source_files.*did not match/
+        sut.result_type.should == :error
+      end
+
+      it "validates a podspec with dependencies" do
+        podspec = stub_podspec(/s.name.*$/, 's.name = "ZKit"')
+        podspec.gsub!(/s.requires_arc/, "s.dependency 'SBJson', '~> 3.2'\n  s.requires_arc")
+        podspec.gsub!(/s.license.*$/, 's.license = "Public Domain"')
+        file = write_podspec(podspec, "ZKit.podspec")
+
+        spec = Specification.from_file(file)
+        sut = Validator.new(spec)
+        sut.validate
+        sut.validated?.should.be.true
+      end
     end
+
+    #-------------------------------------------------------------------------#
+
   end
 end