Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
C
cocoapods
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
gengmeiios
cocoapods
Commits
5d7c7d3b
Commit
5d7c7d3b
authored
Mar 14, 2018
by
Dimitris Koutsogiorgas
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix `PRODUCT_MODULE_NAME` for generated test targets
parent
67d662c2
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
7 additions
and
0 deletions
+7
-0
CHANGELOG.md
CHANGELOG.md
+4
-0
pod_target_installer.rb
...ller/xcode/pods_project_generator/pod_target_installer.rb
+1
-0
pod_target_installer_spec.rb
...xcode/pods_project_generator/pod_target_installer_spec.rb
+2
-0
No files found.
CHANGELOG.md
View file @
5d7c7d3b
...
...
@@ -59,6 +59,10 @@ To install release candidates run `[sudo] gem install cocoapods --pre`
[
Dimitris Koutsogiorgas
](
https://github.com/dnkoutso
)
[
#7511
](
https://github.com/CocoaPods/CocoaPods/issues/7511
)
*
Fix
`PRODUCT_MODULE_NAME`
for generated test targets
[
Dimitris Koutsogiorgas
](
https://github.com/dnkoutso
)
[
#7507
](
https://github.com/CocoaPods/CocoaPods/issues/7507
)
*
Ensure
`SWIFT_VERSION`
is set for test only pod targets during validation
[
Dimitris Koutsogiorgas
](
https://github.com/dnkoutso
)
[
#7498
](
https://github.com/CocoaPods/CocoaPods/issues/7498
)
...
...
lib/cocoapods/installer/xcode/pods_project_generator/pod_target_installer.rb
View file @
5d7c7d3b
...
...
@@ -277,6 +277,7 @@ module Pod
# requires frameworks. For tests we always use the test target name as the product name
# irrelevant to whether we use frameworks or not.
configuration
.
build_settings
[
'PRODUCT_NAME'
]
=
name
configuration
.
build_settings
[
'PRODUCT_MODULE_NAME'
]
=
name
# We must codesign iOS XCTest bundles that contain binary frameworks to allow them to be launchable in the simulator
unless
target
.
platform
==
:osx
configuration
.
build_settings
[
'CODE_SIGNING_REQUIRED'
]
=
'YES'
...
...
spec/unit/installer/xcode/pods_project_generator/pod_target_installer_spec.rb
View file @
5d7c7d3b
...
...
@@ -199,6 +199,7 @@ module Pod
native_test_target
.
product_reference
.
name
.
should
==
'CoconutLib-Unit-Tests'
native_test_target
.
build_configurations
.
each
do
|
bc
|
bc
.
build_settings
[
'PRODUCT_NAME'
].
should
==
'CoconutLib-Unit-Tests'
bc
.
build_settings
[
'PRODUCT_MODULE_NAME'
].
should
==
'CoconutLib-Unit-Tests'
bc
.
build_settings
[
'CODE_SIGNING_REQUIRED'
].
should
==
'YES'
bc
.
build_settings
[
'CODE_SIGNING_ALLOWED'
].
should
==
'YES'
bc
.
build_settings
[
'CODE_SIGN_IDENTITY'
].
should
==
'iPhone Developer'
...
...
@@ -216,6 +217,7 @@ module Pod
native_test_target
.
product_reference
.
name
.
should
==
'CoconutLib-Unit-Tests'
native_test_target
.
build_configurations
.
each
do
|
bc
|
bc
.
build_settings
[
'PRODUCT_NAME'
].
should
==
'CoconutLib-Unit-Tests'
bc
.
build_settings
[
'PRODUCT_MODULE_NAME'
].
should
==
'CoconutLib-Unit-Tests'
bc
.
build_settings
[
'CODE_SIGNING_REQUIRED'
].
should
.
be
.
nil
bc
.
build_settings
[
'CODE_SIGNING_ALLOWED'
].
should
.
be
.
nil
bc
.
build_settings
[
'CODE_SIGN_IDENTITY'
].
should
==
''
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment