Commit 68f5f109 authored by Kra Larivain's avatar Kra Larivain Committed by Eloy Durán

[Linter] Work around Xcode issue where build passes but lint fails.

Fixes #2394.
parent dd70ffdd
...@@ -6,6 +6,16 @@ To install or update CocoaPods see this [guide](http://docs.cocoapods.org/guides ...@@ -6,6 +6,16 @@ To install or update CocoaPods see this [guide](http://docs.cocoapods.org/guides
##### Bug Fixes ##### Bug Fixes
* Works around an Xcode issue where linting would fail even though `xcodebuild`
actually succeeds. Xcode.app also doesn't fail when this issue occurs, so it's
safe for us to do the same.
[Kra Larivain](https://github.com/olarivain)
[Boris Bügling](https://github.com/neonichu)
[Eloy Durán](https://github.com/alloy)
[Samuel E. Giddins](https://github.com/segiddins)
[#2394](https://github.com/CocoaPods/CocoaPods/issues/2394)
[#2395](https://github.com/CocoaPods/CocoaPods/pull/2395)
* Fixes the detection of JSON podspecs included via `:path`. * Fixes the detection of JSON podspecs included via `:path`.
[laiso](https://github.com/laiso) [laiso](https://github.com/laiso)
[#2489](https://github.com/CocoaPods/CocoaPods/pull/2489) [#2489](https://github.com/CocoaPods/CocoaPods/pull/2489)
......
...@@ -325,7 +325,14 @@ module Pod ...@@ -325,7 +325,14 @@ module Pod
UI.puts output UI.puts output
parsed_output = parse_xcodebuild_output(output) parsed_output = parse_xcodebuild_output(output)
parsed_output.each do |message| parsed_output.each do |message|
if message.include?('error: ') # Checking the error for `InputFile` is to work around an Xcode
# issue where linting would fail even though `xcodebuild` actually
# succeeds. Xcode.app also doesn't fail when this issue occurs, so
# it's safe for us to do the same.
#
# For more details see https://github.com/CocoaPods/CocoaPods/issues/2394#issuecomment-56658587
#
if message.include?('error: ') && !message.include?("'InputFile' should have")
error "[xcodebuild] #{message}" error "[xcodebuild] #{message}"
else else
note "[xcodebuild] #{message}" note "[xcodebuild] #{message}"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment