[PodVariant] Remove swift_version

parent d6523d56
...@@ -452,7 +452,7 @@ module Pod ...@@ -452,7 +452,7 @@ module Pod
distinct_targets = specs_by_target.each_with_object({}) do |dependency, hash| distinct_targets = specs_by_target.each_with_object({}) do |dependency, hash|
target_definition, dependent_specs = *dependency target_definition, dependent_specs = *dependency
dependent_specs.group_by(&:root).each do |root_spec, specs| dependent_specs.group_by(&:root).each do |root_spec, specs|
pod_variant = PodVariant.new(specs, target_definition.platform, target_definition.uses_frameworks?, target_definition.swift_version) pod_variant = PodVariant.new(specs, target_definition.platform, target_definition.uses_frameworks?)
hash[root_spec] ||= {} hash[root_spec] ||= {}
(hash[root_spec][pod_variant] ||= []) << target_definition (hash[root_spec][pod_variant] ||= []) << target_definition
end end
......
...@@ -16,10 +16,6 @@ module Pod ...@@ -16,10 +16,6 @@ module Pod
attr_accessor :requires_frameworks attr_accessor :requires_frameworks
alias_method :requires_frameworks?, :requires_frameworks alias_method :requires_frameworks?, :requires_frameworks
# @return [String] the Swift version
#
attr_accessor :swift_version
# @return [Specification] the root specification # @return [Specification] the root specification
# #
def root_spec def root_spec
...@@ -32,11 +28,10 @@ module Pod ...@@ -32,11 +28,10 @@ module Pod
# @param [Platform] platform @see #platform # @param [Platform] platform @see #platform
# @param [Bool] requires_frameworks @see #requires_frameworks? # @param [Bool] requires_frameworks @see #requires_frameworks?
# #
def initialize(specs, platform, requires_frameworks = false, swift_version = nil) def initialize(specs, platform, requires_frameworks = false)
self.specs = specs self.specs = specs
self.platform = platform self.platform = platform
self.requires_frameworks = requires_frameworks self.requires_frameworks = requires_frameworks
self.swift_version = swift_version
end end
# @return [Bool] whether the {PodVariant} is equal to another taking all # @return [Bool] whether the {PodVariant} is equal to another taking all
...@@ -46,8 +41,7 @@ module Pod ...@@ -46,8 +41,7 @@ module Pod
self.class == other.class && self.class == other.class &&
specs == other.specs && specs == other.specs &&
platform == other.platform && platform == other.platform &&
requires_frameworks == other.requires_frameworks && requires_frameworks == other.requires_frameworks
swift_version == other.swift_version
end end
alias_method :eql?, :== alias_method :eql?, :==
...@@ -57,7 +51,7 @@ module Pod ...@@ -57,7 +51,7 @@ module Pod
# #
# @!visibility private # @!visibility private
def hash def hash
[specs, platform, requires_frameworks, swift_version].hash [specs, platform, requires_frameworks].hash
end end
end end
end end
......
require File.expand_path('../../../../spec_helper', __FILE__) require File.expand_path('../../../../spec_helper', __FILE__)
module Pod module Pod
describe PodVariant = Installer::Analyzer::PodVariant do class Installer
class Analyzer
describe PodVariant do
before do before do
@specs = [stub('Spec'), stub('Spec/Foo')] @specs = [stub('Spec'), stub('Spec/Foo')]
@platform = Platform.ios @platform = Platform.ios
...@@ -12,7 +14,6 @@ module Pod ...@@ -12,7 +14,6 @@ module Pod
variant.specs.should == @specs variant.specs.should == @specs
variant.platform.should == @platform variant.platform.should == @platform
variant.requires_frameworks.should == false variant.requires_frameworks.should == false
variant.swift_version.should.nil?
end end
it 'can be initialized with specs, platform and whether it requires frameworks' do it 'can be initialized with specs, platform and whether it requires frameworks' do
...@@ -20,15 +21,6 @@ module Pod ...@@ -20,15 +21,6 @@ module Pod
variant.specs.should == @specs variant.specs.should == @specs
variant.platform.should == @platform variant.platform.should == @platform
variant.requires_frameworks.should == true variant.requires_frameworks.should == true
variant.swift_version.should.nil?
end
it 'can be initialized with specs, platform, whether it requires frameworks, and a Swift version' do
variant = PodVariant.new(@specs, @platform, true, '2.3')
variant.specs.should == @specs
variant.platform.should == @platform
variant.requires_frameworks.should == true
variant.swift_version.should == '2.3'
end end
it 'can return the root spec' do it 'can return the root spec' do
...@@ -37,12 +29,11 @@ module Pod ...@@ -37,12 +29,11 @@ module Pod
variant.root_spec.should == spec variant.root_spec.should == spec
end end
it 'can be compared for equality with another variant with the same specs, platform, value for whether it requires frameworks and Swift version' do it 'can be compared for equality with another variant with the same specs, platform, and whether it requires frameworks' do
spec = PodVariant.new(@specs, @platform, false, '2.3') spec = PodVariant.new(@specs, @platform, false)
spec.should == PodVariant.new(@specs, @platform, false, '2.3') spec.should == PodVariant.new(@specs, @platform, false)
spec.should.not == PodVariant.new(@specs, @platform, false, '3.0') spec.should.not == PodVariant.new([@specs.first], @platform)
spec.should.not == PodVariant.new([@specs.first], @platform, false) spec.should.not == PodVariant.new(@specs, Platform.osx, false)
spec.should.not == PodVariant.new(@specs, Platform.osx, false, '2.3')
spec.should.not == PodVariant.new(@specs, @platform, true) spec.should.not == PodVariant.new(@specs, @platform, true)
end end
...@@ -56,4 +47,6 @@ module Pod ...@@ -56,4 +47,6 @@ module Pod
hash[k1].should == v1 hash[k1].should == v1
end end
end end
end
end
end end
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment