Commit 7840787e authored by Eloy Durán's avatar Eloy Durán

Un-deprecate use of implicit sources, by default all are used.

After much deliberation, the conclusion is that there is no good
techincal reason to enforce this, after all, and as such the decision
to deprecate it has been reverted.
parent 058b3247
...@@ -19,9 +19,16 @@ To install or update CocoaPods see this [guide](http://docs.cocoapods.org/guides ...@@ -19,9 +19,16 @@ To install or update CocoaPods see this [guide](http://docs.cocoapods.org/guides
[Samuel Giddins](https://github.com/segiddins) [Samuel Giddins](https://github.com/segiddins)
[Molinillo#6](https://github.com/CocoaPods/Molinillo/issues/6) [Molinillo#6](https://github.com/CocoaPods/Molinillo/issues/6)
##### Enhancements ##### Enhancements
* The use of implicit sources has been un-deprecated. By default, all available
spec-repos will be used. There should only be a need to specify explicit
sources if you want to specifically _exclude_ certain spec-repos, such as the
`master` spec-repo, if you want to declare the order of spec look-up
precedence, or if you want other users of a Podfile to automatically have a
spec-repo cloned on `pod install`.
[Eloy Durán](https://github.com/alloy)
* The `pod push` command has been removed as it has been deprecated in favour of * The `pod push` command has been removed as it has been deprecated in favour of
`pod repo push` in CocoaPods 0.33. `pod repo push` in CocoaPods 0.33.
[Fabio Pelosin](https://github.com/fabiopelosin) [Fabio Pelosin](https://github.com/fabiopelosin)
......
...@@ -346,8 +346,9 @@ module Pod ...@@ -346,8 +346,9 @@ module Pod
# @!group Analysis internal products # @!group Analysis internal products
# @return [Molinillo::DependencyGraph<Dependency>] the dependencies generated by the lockfile # @return [Molinillo::DependencyGraph<Dependency>] the dependencies
# that prevent the resolver to update a Pod. # generated by the lockfile that prevent the resolver to update a
# Pod.
# #
attr_reader :locked_dependencies attr_reader :locked_dependencies
...@@ -357,23 +358,17 @@ module Pod ...@@ -357,23 +358,17 @@ module Pod
# Returns the sources used to query for specifications # Returns the sources used to query for specifications
# #
# @note Currently, this defaults to {SourcesManager.all} when no # When no explicit Podfile sources are defined, this defaults to all
# Podfile sources are defined, but this implicit declaration of # available sources ({SourcesManager.all}).
# sources is deprecated.
# #
# @return [Array<Source>] the sources to be used in finding # @return [Array<Source>] the sources to be used in finding
# specifications, as specified by the {#podfile}. # specifications, as specified by the {#podfile} or all sources.
# #
def sources def sources
@sources ||= begin @sources ||= begin
sources = podfile.sources sources = podfile.sources
if sources.empty? && !podfile.dependencies.reject(&:external_source).empty? if sources.empty? && !podfile.dependencies.reject(&:external_source).empty?
SourcesManager.all.tap do |all| SourcesManager.all
UI.warn all.reduce("The use of implicit sources has been " \
"deprecated. To continue using all of the sources currently " \
"on your machine, add the following to the top of your " \
"Podfile:\n") { |w, s| w << "\n source '#{s.url}'" } + "\n"
end
else else
sources.map do |url| sources.map do |url|
SourcesManager.find_or_create_source_with_url(url) SourcesManager.find_or_create_source_with_url(url)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment