Commit 86424fc3 authored by Samuel E. Giddins's avatar Samuel E. Giddins

Merge branch 'danthorpe-bug/2983_inherit_swift_flags'

parents 63f240ea 4f2fe411
......@@ -34,6 +34,10 @@ To install release candidates run `[sudo] gem install cocoapods --pre`
[Samuel Giddins](https://github.com/segiddins)
[#3230](https://github.com/CocoaPods/CocoaPods/issues/3230)
* Fix the `OTHER_SWIFT_FLAGS` generated, so it inherits previous definitions.
[Daniel Thorpe](https://github.com/danthorpe)
[#2983](https://github.com/CocoaPods/CocoaPods/issues/2983)
## 0.36.0.rc.1
......
......@@ -160,7 +160,7 @@ module Pod
def self.add_language_specific_settings(target, xcconfig)
if target.uses_swift?
build_settings = {
'OTHER_SWIFT_FLAGS' => quote(%w(-D COCOAPODS)),
'OTHER_SWIFT_FLAGS' => '$(inherited) ' + quote(%w(-D COCOAPODS)),
}
xcconfig.merge!(build_settings)
end
......
......@@ -157,7 +157,7 @@ module Pod
end
it 'adds the COCOAPODS macro definition' do
@xcconfig.to_hash['OTHER_SWIFT_FLAGS'].should.include '"-D" "COCOAPODS"'
@xcconfig.to_hash['OTHER_SWIFT_FLAGS'].should.include '$(inherited) "-D" "COCOAPODS"'
end
end
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment