Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
C
cocoapods
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
gengmeiios
cocoapods
Commits
86424fc3
Commit
86424fc3
authored
Mar 07, 2015
by
Samuel E. Giddins
Browse files
Options
Browse Files
Download
Plain Diff
Merge branch 'danthorpe-bug/2983_inherit_swift_flags'
parents
63f240ea
4f2fe411
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
6 additions
and
2 deletions
+6
-2
CHANGELOG.md
CHANGELOG.md
+4
-0
xcconfig_helper.rb
lib/cocoapods/generator/xcconfig/xcconfig_helper.rb
+1
-1
aggregate_xcconfig_spec.rb
spec/unit/generator/xcconfig/aggregate_xcconfig_spec.rb
+1
-1
No files found.
CHANGELOG.md
View file @
86424fc3
...
...
@@ -34,6 +34,10 @@ To install release candidates run `[sudo] gem install cocoapods --pre`
[
Samuel Giddins
](
https://github.com/segiddins
)
[
#3230
](
https://github.com/CocoaPods/CocoaPods/issues/3230
)
*
Fix the
`OTHER_SWIFT_FLAGS`
generated, so it inherits previous definitions.
[
Daniel Thorpe
](
https://github.com/danthorpe
)
[
#2983
](
https://github.com/CocoaPods/CocoaPods/issues/2983
)
## 0.36.0.rc.1
...
...
lib/cocoapods/generator/xcconfig/xcconfig_helper.rb
View file @
86424fc3
...
...
@@ -160,7 +160,7 @@ module Pod
def
self
.
add_language_specific_settings
(
target
,
xcconfig
)
if
target
.
uses_swift?
build_settings
=
{
'OTHER_SWIFT_FLAGS'
=>
quote
(
%w(-D COCOAPODS)
),
'OTHER_SWIFT_FLAGS'
=>
'$(inherited) '
+
quote
(
%w(-D COCOAPODS)
),
}
xcconfig
.
merge!
(
build_settings
)
end
...
...
spec/unit/generator/xcconfig/aggregate_xcconfig_spec.rb
View file @
86424fc3
...
...
@@ -157,7 +157,7 @@ module Pod
end
it
'adds the COCOAPODS macro definition'
do
@xcconfig
.
to_hash
[
'OTHER_SWIFT_FLAGS'
].
should
.
include
'"-D" "COCOAPODS"'
@xcconfig
.
to_hash
[
'OTHER_SWIFT_FLAGS'
].
should
.
include
'
$(inherited)
"-D" "COCOAPODS"'
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment