[linter] Check docset_url is valid HTTP URL

CHANGELOG.md

@@ -6,8 +6,8 @@ To install or update CocoaPods see this [guide](http://docs.cocoapods.org/guides
 
 ##### Enhancements
 
-* Validate the reachability of social_media_url, documentation_url in
-  podspecs while linting a specification.  
+* Validate the reachability of social_media_url, documentation_url and
+  docset_url in podspecs we while linting a specification.  
   [Kyle Fuller](https://github.com/kylef)
   [#2025](https://github.com/CocoaPods/CocoaPods/issues/2025)
 

lib/cocoapods/validator.rb

@@ -200,6 +200,7 @@ module Pod
       validate_screenshots(spec)
       validate_social_media_url(spec)
       validate_documentation_url(spec)
+      validate_docset_url(spec)
 
       spec.available_platforms.each do |platform|
         UI.message "\n\n#{spec} - Analyzing on #{platform} platform.".green.reversed
@@ -270,6 +271,12 @@ module Pod
       validate_url(spec.documentation_url) if spec.documentation_url
     end
 
+    # Performs validations related to the `docset_url` attribute.
+    #
+    def validate_docset_url(spec)
+      validate_url(spec.docset_url) if spec.docset_url
+    end
+
     def setup_validation_environment
       validation_dir.rmtree if validation_dir.exist?
       validation_dir.mkpath

spec/unit/validator_spec.rb

@@ -228,6 +228,25 @@ module Pod
             @sut.results.map(&:to_s).first.should.match /The URL (.*) is not reachable/
           end
         end
+
+        describe "docset URL validation" do
+          before do
+            @sut.stubs(:validate_homepage)
+          end
+
+          it "checks if the docset URL is valid" do
+            Specification.any_instance.stubs(:docset_url).returns('http://banana-corp.local/')
+            WebMock::API.stub_request(:head, /banana-corp.local/).to_return(:status => 200)
+            @sut.validate
+            @sut.results.should.be.empty?
+          end
+
+          it "should fail validation if it wasn't able to validate the URL" do
+            Specification.any_instance.stubs(:docset_url).returns('http://banana-corp.local/not-found')
+            @sut.validate
+            @sut.results.map(&:to_s).first.should.match /The URL (.*) is not reachable/
+          end
+        end
       end
 
       it "respects the no clean option" do