[PodSourceInstaller] Allow opting out of pod source locking

Projects opened via pod try are now editable
Closes https://github.com/CocoaPods/cocoapods-try/issues/31

CHANGELOG.md

@@ -4,6 +4,16 @@ To install or update CocoaPods see this [guide](http://docs.cocoapods.org/guides
 
 To install release candidates run `[sudo] gem install cocoapods --pre`
 
+## Master
+
+##### Enhancements
+
+* Allow opting out of pod source locking, meaning `pod try` yields editable
+  projects.  
+  [Samuel Giddins](https://github.com/segiddins)
+  [cocoapods-try#31](https://github.com/CocoaPods/cocoapods-try/issues/31)
+
+
 ## 0.37.1
 
 ##### Bug Fixes

lib/cocoapods/config.rb

@@ -19,6 +19,7 @@ module Pod
 
       :clean               => true,
       :integrate_targets   => true,
+      :lock_pod_source     => true,
       :new_version_message => ENV['COCOAPODS_SKIP_UPDATE_MESSAGE'].nil?,
 
       :cache_root          => Pathname.new(Dir.home) + 'Library/Caches/CocoaPods',
@@ -71,6 +72,12 @@ module Pod
     attr_accessor :clean
     alias_method :clean?, :clean
 
+    # @return [Bool] Whether the installer should remove write permissions for
+    #                installed pod source files after the installation.
+    #
+    attr_accessor :lock_pod_source
+    alias_method :lock_pod_source?, :lock_pod_source
+
     # @return [Bool] Whether CocoaPods should integrate a user target and build
     #         the workspace or just create the Pods project.
     #

lib/cocoapods/installer.rb

@@ -122,6 +122,7 @@ module Pod
         install_pod_sources
         run_pre_install_hooks
         clean_pod_sources
+        lock_pod_sources
       end
     end
 
@@ -316,6 +317,16 @@ module Pod
       @pod_installers.each(&:clean!)
     end
 
+    # Locks the sources of the Pods if the config instructs to do so.
+    #
+    # @todo Why the @pod_installers might be empty?
+    #
+    def lock_pod_sources
+      return unless config.lock_pod_source?
+      return unless @pod_installers
+      @pod_installers.each(&:lock_files!)
+    end
+
     # Determines if the dependencies need to be built as dynamic frameworks or
     # if they can be built as static libraries by checking for the Swift source
     # presence. Therefore it is important that the file accessors of the

lib/cocoapods/installer/pod_source_installer.rb

@@ -44,7 +44,6 @@ module Pod
       def install!
         download_source unless predownloaded? || local?
         PodSourcePreparer.new(root_spec, root).prepare! if local?
-        lock_files!
       end
 
       # Cleans the installations if appropriate.
@@ -58,6 +57,17 @@ module Pod
         clean_installation unless local?
       end
 
+      # Locks the source files if appropriate.
+      #
+      # @todo   As the pre install hooks need to run before cleaning this
+      #         method should be refactored.
+      #
+      # @return [void]
+      #
+      def lock_files!
+        lock_installation unless local?
+      end
+
       # @return [Hash]
       #
       attr_reader :specific_source
@@ -95,11 +105,7 @@ module Pod
       #
       # @return [void]
       #
-      def lock_files!
-        if local?
-          return
-        end
-
+      def lock_installation
         # We don't want to lock diretories, as that forces you to override
         # those permissions if you decide to delete the Pods folder.
         Dir.glob(root + '**/*').each do |file|

spec/unit/config_spec.rb

@@ -180,6 +180,10 @@ module Pod
         @config.should.clean
       end
 
+      it 'locks pod source files' do
+        @config.should.lock_pod_source
+      end
+
       it 'returns the cache root' do
         @config.cache_root.should == Pathname.new(File.join(ENV['HOME'], 'Library/Caches/CocoaPods'))
       end

spec/unit/installer/pod_source_installer_spec.rb

@@ -137,12 +137,14 @@ module Pod
         it 'locks the source files for each Pod' do
           File.expects(:chmod).at_least_once
           @installer.install!
+          @installer.lock_files!
         end
 
         it "doesn't lock local pods" do
           @installer.stubs(:local?).returns(true)
           File.expects(:chmod).never
           @installer.install!
+          @installer.lock_files!
         end
       end