Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
C
cocoapods
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
gengmeiios
cocoapods
Commits
b5b8012e
Commit
b5b8012e
authored
Apr 15, 2014
by
Orta
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #2026 from clarkda/master
Dont allow pod names that begin with a `.`
parents
f28d2d4d
1174213a
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
11 additions
and
0 deletions
+11
-0
CHANGELOG.md
CHANGELOG.md
+6
-0
lib.rb
lib/cocoapods/command/lib.rb
+1
-0
lib_spec.rb
spec/functional/command/lib_spec.rb
+4
-0
No files found.
CHANGELOG.md
View file @
b5b8012e
...
...
@@ -20,6 +20,12 @@ To install or update CocoaPods see this [guide](http://docs.cocoapods.org/guides
[
Piet Brauer
](
https://github.com/pietbrauer
)
[
Orta Therox
](
https://github.com/orta
)
*
`pod lib create`
now disallows any pod name that begins with a
`.`
[
Dustin Clark
](
https://github.com/clarkda
)
[
#2026
](
https://github.com/CocoaPods/CocoaPods/pull/2026
)
[
Core#97
](
https://github.com/CocoaPods/Core/pull/97
)
[
Core#98
](
https://github.com/CocoaPods/Core/issues/98
)
*
Validate the reachability of screenshot URLs in podspecs while linting a
specification.
[
Kyle Fuller
](
https://github.com/kylef
)
...
...
lib/cocoapods/command/lib.rb
View file @
b5b8012e
...
...
@@ -26,6 +26,7 @@ module Pod
super
help!
"A name for the Pod is required."
unless
@name
help!
"The Pod name cannot contain spaces."
if
@name
.
match
(
/\s/
)
help!
"The Pod name cannot begin with a '.'"
if
@name
[
0
,
1
]
==
'.'
end
def
run
...
...
spec/functional/command/lib_spec.rb
View file @
b5b8012e
...
...
@@ -16,6 +16,10 @@ module Pod
lambda
{
run_command
(
'lib'
,
'create'
,
'Pod Name With Spaces'
)
}.
should
.
raise
CLAide
::
Help
end
it
"complains if pod name begins with a period"
do
lambda
{
run_command
(
'lib'
,
'create'
,
'.HiddenPod'
)
}.
should
.
raise
CLAide
::
Help
end
it
"should create a new dir for the newly created pod"
do
@sut
.
any_instance
.
stubs
(
:configure_template
)
url
=
@sut
::
TEMPLATE_REPO
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment