Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
C
cocoapods
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
gengmeiios
cocoapods
Commits
c8999d00
Commit
c8999d00
authored
Oct 05, 2017
by
Dimitris Koutsogiorgas
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Do not set a `CODE_SIGN_IDENTITY` for macOS app hosts or xctest bundles
parent
bd9e7f40
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
9 additions
and
0 deletions
+9
-0
CHANGELOG.md
CHANGELOG.md
+4
-0
pod_target_installer.rb
...ller/xcode/pods_project_generator/pod_target_installer.rb
+3
-0
pod_target_installer_spec.rb
...xcode/pods_project_generator/pod_target_installer_spec.rb
+2
-0
No files found.
CHANGELOG.md
View file @
c8999d00
...
...
@@ -34,6 +34,10 @@ To install release candidates run `[sudo] gem install cocoapods --pre`
[
Dimitris Koutsogiorgas
](
https://github.com/dnkoutso
)
[
#7104
](
https://github.com/CocoaPods/CocoaPods/pull/7104
)
*
Do not set a
`CODE_SIGN_IDENTITY`
for macOS app hosts or xctest bundles
[
Dimitris Koutsogiorgas
](
https://github.com/dnkoutso
)
[
#7103
](
https://github.com/CocoaPods/CocoaPods/pull/7103
)
*
Fix framework and resources paths caching
[
Dimitris Koutsogiorgas
](
https://github.com/dnkoutso
)
[
#7068
](
https://github.com/CocoaPods/CocoaPods/pull/7068
)
...
...
lib/cocoapods/installer/xcode/pods_project_generator/pod_target_installer.rb
View file @
c8999d00
...
...
@@ -200,6 +200,7 @@ module Pod
configuration
.
build_settings
.
merge!
(
custom_build_settings
)
configuration
.
build_settings
[
'PRODUCT_NAME'
]
=
name
configuration
.
build_settings
[
'PRODUCT_BUNDLE_IDENTIFIER'
]
=
'org.cocoapods.${PRODUCT_NAME:rfc1034identifier}'
configuration
.
build_settings
[
'CODE_SIGN_IDENTITY'
]
=
''
if
target
.
platform
==
:osx
end
Pod
::
Generator
::
AppTargetHelper
.
add_app_host_main_file
(
project
,
app_host_target
,
platform_name
,
name
)
app_host_info_plist_path
=
project
.
path
.
dirname
.
+
(
"
#{
name
}
/Info.plist"
)
...
...
@@ -248,6 +249,8 @@ module Pod
configuration
.
build_settings
[
'PRODUCT_NAME'
]
=
name
# We must codesign iOS XCTest bundles that contain binary frameworks to allow them to be launchable in the simulator
configuration
.
build_settings
[
'CODE_SIGNING_REQUIRED'
]
=
'YES'
unless
target
.
platform
==
:osx
# For macOS we do not code sign the XCTest bundle because we do not code sign the frameworks either.
configuration
.
build_settings
[
'CODE_SIGN_IDENTITY'
]
=
''
if
target
.
platform
==
:osx
end
# Test native targets also need frameworks and resources to be copied over to their xctest bundle.
...
...
spec/unit/installer/xcode/pods_project_generator/pod_target_installer_spec.rb
View file @
c8999d00
...
...
@@ -200,6 +200,7 @@ module Pod
native_test_target
.
build_configurations
.
each
do
|
bc
|
bc
.
build_settings
[
'PRODUCT_NAME'
].
should
==
'CoconutLib-Unit-Tests'
bc
.
build_settings
[
'CODE_SIGNING_REQUIRED'
].
should
==
'YES'
bc
.
build_settings
[
'CODE_SIGN_IDENTITY'
].
should
==
'iPhone Developer'
end
native_test_target
.
symbol_type
.
should
==
:unit_test_bundle
@coconut_pod_target
.
test_native_targets
.
count
.
should
==
1
...
...
@@ -215,6 +216,7 @@ module Pod
native_test_target
.
build_configurations
.
each
do
|
bc
|
bc
.
build_settings
[
'PRODUCT_NAME'
].
should
==
'CoconutLib-Unit-Tests'
bc
.
build_settings
[
'CODE_SIGNING_REQUIRED'
].
should
.
be
.
nil
bc
.
build_settings
[
'CODE_SIGN_IDENTITY'
].
should
==
''
end
native_test_target
.
symbol_type
.
should
==
:unit_test_bundle
@coconut_pod_target2
.
test_native_targets
.
count
.
should
==
1
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment