[update] optimize memory

pkg/proxy/parsercmd.go

@@ -67,16 +67,16 @@ func (cp *CmdParser) initial() {
 	go func() {
 		logger.Infof("Session %s: %s start", cp.id, cp.name)
 		defer logger.Infof("Session %s: %s parser close", cp.id, cp.name)
-	inloop:
+	loop:
 		for {
 			line, err := cp.term.ReadLine()
 			if err != nil {
 				select {
 				case <-cp.closed:
-					goto outloop
+					break loop
 				default:
 				}
-				goto inloop
+				goto loop
 			}
 			cp.lock.Lock()
 			cp.currentLength += len(line)
@@ -85,7 +85,6 @@ func (cp *CmdParser) initial() {
 			}
 			cp.lock.Unlock()
 		}
-	outloop:
 	}()
 }
 

pkg/proxy/recorderstorage/azure.go

@@ -18,7 +18,7 @@ type AzureReplayStorage struct {
 	EndpointSuffix string
 }
 
-func (a *AzureReplayStorage) Upload(gZipFilePath, target string) (err error) {
+func (a AzureReplayStorage) Upload(gZipFilePath, target string) (err error) {
 	file, err := os.Open(gZipFilePath)
 	if err != nil {
 		return

pkg/proxy/recorderstorage/es.go

@@ -17,7 +17,7 @@ type ESCommandStorage struct {
 	DocType string
 }
 
-func (es *ESCommandStorage) BulkSave(commands []*model.Command) (err error) {
+func (es ESCommandStorage) BulkSave(commands []*model.Command) (err error) {
 	var buf bytes.Buffer
 	esClinet, err := elasticsearch.NewClient(elasticsearch.Config{
 		Addresses: es.Hosts,

pkg/proxy/recorderstorage/oss.go

@@ -13,7 +13,7 @@ type OSSReplayStorage struct {
 	SecretKey string
 }
 
-func (o *OSSReplayStorage) Upload(gZipFilePath, target string) (err error) {
+func (o OSSReplayStorage) Upload(gZipFilePath, target string) (err error) {
 	client, err := oss.New(o.Endpoint, o.AccessKey, o.SecretKey)
 	if err != nil {
 		return

pkg/proxy/recorderstorage/s3.go

@@ -19,7 +19,7 @@ type S3ReplayStorage struct {
 	Endpoint  string
 }
 
-func (s *S3ReplayStorage) Upload(gZipFilePath, target string) (err error) {
+func (s S3ReplayStorage) Upload(gZipFilePath, target string) (err error) {
 
 	file, err := os.Open(gZipFilePath)
 	if err != nil {

pkg/proxy/recorderstorage/server.go

@@ -11,7 +11,7 @@ import (
 type ServerCommandStorage struct {
 }
 
-func (s *ServerCommandStorage) BulkSave(commands []*model.Command) (err error) {
+func (s ServerCommandStorage) BulkSave(commands []*model.Command) (err error) {
 	return service.PushSessionCommand(commands)
 }
 
@@ -19,7 +19,7 @@ type ServerReplayStorage struct {
 	StorageType string
 }
 
-func (s *ServerReplayStorage) Upload(gZipFilePath, target string) (err error) {
+func (s ServerReplayStorage) Upload(gZipFilePath, target string) (err error) {
 	sessionID := strings.Split(filepath.Base(gZipFilePath), ".")[0]
 	return service.PushSessionReplay(sessionID, gZipFilePath)
 }

pkg/proxy/util.go

@@ -16,8 +16,8 @@ type CommandStorage interface {
 	BulkSave(commands []*model.Command) error
 }
 
-var defaultCommandStorage = &storage.ServerCommandStorage{}
-var defaultReplayStorage = &storage.ServerReplayStorage{StorageType: "server"}
+var defaultCommandStorage = storage.ServerCommandStorage{}
+var defaultReplayStorage = storage.ServerReplayStorage{StorageType: "server"}
 
 func NewReplayStorage() ReplayStorage {
 	cf := config.GetConf().ReplayStorage
@@ -31,14 +31,14 @@ func NewReplayStorage() ReplayStorage {
 		if endpointSuffix == "" {
 			endpointSuffix = "core.chinacloudapi.cn"
 		}
-		return &storage.AzureReplayStorage{
+		return storage.AzureReplayStorage{
 			AccountName:    cf["ACCOUNT_NAME"].(string),
 			AccountKey:     cf["ACCOUNT_KEY"].(string),
 			ContainerName:  cf["CONTAINER_NAME"].(string),
 			EndpointSuffix: endpointSuffix,
 		}
 	case "oss":
-		return &storage.OSSReplayStorage{
+		return storage.OSSReplayStorage{
 			Endpoint:  cf["ENDPOINT"].(string),
 			Bucket:    cf["BUCKET"].(string),
 			AccessKey: cf["ACCESS_KEY"].(string),
@@ -58,7 +58,7 @@ func NewReplayStorage() ReplayStorage {
 			region = strings.Split(endpoint, ".")[1]
 		}
 
-		return &storage.S3ReplayStorage{
+		return storage.S3ReplayStorage{
 			Bucket:    bucket,
 			Region:    region,
 			AccessKey: cf["ACCESS_KEY"].(string),
@@ -90,7 +90,7 @@ func NewCommandStorage() CommandStorage {
 		if docType == "" {
 			docType = "command_store"
 		}
-		return &storage.ESCommandStorage{Hosts: hosts, Index: index, DocType: docType}
+		return storage.ESCommandStorage{Hosts: hosts, Index: index, DocType: docType}
 	default:
 		return defaultCommandStorage
 	}