code review

Example/Podfile.lock

@@ -35,7 +35,7 @@ PODS:
   - GMKit/Protocol (1.1.3):
     - Masonry (= 1.1.0)
     - SDWebImage (= 3.7.6)
-  - GMPhobos (1.3.0):
+  - GMPhobos (1.3.4):
     - GMCache
     - GMKit
   - Masonry (1.1.0)
@@ -63,7 +63,7 @@ EXTERNAL SOURCES:
 SPEC CHECKSUMS:
   GMCache: 09a3029c96fe130e3a21faef70b3d9d2ce92d639
   GMKit: 35f788243cceeddf3e13c5226b3ea0b5e08e2117
-  GMPhobos: c1dd33760f8d4243e6bf562a115899e66c6ec7d2
+  GMPhobos: 1ee4b12cccd1df054bf9539357c5fc60a2d64a68
   Masonry: 678fab65091a9290e40e2832a55e7ab731aad201
   SDWebImage: c325cf02c30337336b95beff20a13df489ec0ec9
   TMCache: 95ebcc9b3c7e90fb5fd8fc3036cba3aa781c9bed

GMPhobos/Classes/PhobosUtil.m

@@ -123,12 +123,11 @@
         // sendAsynchronousRequest 在iOS9以后y被废除了
         NSURLSession *session = [NSURLSession sharedSession];
         NSURLSessionDataTask *dataTask = [session dataTaskWithRequest:request completionHandler:^(NSData * _Nullable data, NSURLResponse * _Nullable response, NSError * _Nullable error) {
-            if (!error) {
-                //没有错误，返回正确；
-                if (success) {
-                    success(200);
-                } else {
+            if (success) {
+                if (error) {
                     success(error.code);
+                } else {
+                    success(200);
                 }
             }
         }];
@@ -148,12 +147,11 @@
         // sendAsynchronousRequest 在iOS9以后y被废除了
         NSURLSession *session = [NSURLSession sharedSession];
         NSURLSessionDataTask *dataTask = [session dataTaskWithRequest:request completionHandler:^(NSData * _Nullable data, NSURLResponse * _Nullable response, NSError * _Nullable error) {
-            if (!error) {
-                //没有错误，返回正确；
-                if (success) {
-                    success(200);
-                } else {
+            if (success) {
+                if (error) {
                     success(error.code);
+                } else {
+                    success(200);
                 }
             }
         }];