Unverified Commit 045bfff8 authored by Dimitris Koutsogiorgas's avatar Dimitris Koutsogiorgas Committed by GitHub

Merge pull request #7602 from amorde/cleanup-todos

Cleanup old TODOs
parents a55c5bee aef33b51
...@@ -13,11 +13,6 @@ module Pod ...@@ -13,11 +13,6 @@ module Pod
# Run the command # Run the command
# #
# @todo the command reports new dependencies added to the Podfile as
# updates.
#
# @todo fix.
#
def run def run
if updates.empty? if updates.empty?
UI.puts 'No pod updates are available.'.yellow UI.puts 'No pod updates are available.'.yellow
......
...@@ -544,8 +544,6 @@ module Pod ...@@ -544,8 +544,6 @@ module Pod
# Writes the Podfile and the lock files. # Writes the Podfile and the lock files.
# #
# @todo Pass the checkout options to the Lockfile.
#
# @return [void] # @return [void]
# #
def write_lockfiles def write_lockfiles
...@@ -571,11 +569,6 @@ module Pod ...@@ -571,11 +569,6 @@ module Pod
# #
# @return [void] # @return [void]
# #
# @todo [#397] The libraries should be cleaned and the re-added on every
# installation. Maybe a clean_user_project phase should be added.
# In any case it appears to be a good idea store target definition
# information in the lockfile.
#
def integrate_user_project def integrate_user_project
UI.section "Integrating client #{'project'.pluralize(aggregate_targets.map(&:user_project_path).uniq.count)}" do UI.section "Integrating client #{'project'.pluralize(aggregate_targets.map(&:user_project_path).uniq.count)}" do
installation_root = config.installation_root installation_root = config.installation_root
......
...@@ -223,9 +223,6 @@ module Pod ...@@ -223,9 +223,6 @@ module Pod
# the name of the Pod (root name of the dependencies) and doesn't # the name of the Pod (root name of the dependencies) and doesn't
# group them by target definition. # group them by target definition.
# #
# @todo [CocoaPods > 0.18] If there isn't a Lockfile all the Pods should
# be marked as added.
#
def generate_podfile_state def generate_podfile_state
if lockfile if lockfile
pods_state = nil pods_state = nil
...@@ -706,8 +703,6 @@ module Pod ...@@ -706,8 +703,6 @@ module Pod
# #
# @return [void] # @return [void]
# #
# TODO: Specs
#
def fetch_external_sources def fetch_external_sources
return unless allow_pre_downloads? return unless allow_pre_downloads?
......
...@@ -43,11 +43,7 @@ module Pod ...@@ -43,11 +43,7 @@ module Pod
alias_method :update_mode?, :update_mode alias_method :update_mode?, :update_mode
# @return [Lockfile] The lockfile of the installation as a fall-back if # @return [Lockfile] The lockfile of the installation as a fall-back if
# there is no sandbox manifest. This is indented as a temporary # there is no sandbox manifest.
# solution to prevent the full re-installation from users which
# are upgrading from CP < 0.17.
#
# @todo Remove for CP 0.18.
# #
attr_reader :lockfile attr_reader :lockfile
......
...@@ -63,9 +63,6 @@ module Pod ...@@ -63,9 +63,6 @@ module Pod
# Cleans the installations if appropriate. # Cleans the installations if appropriate.
# #
# @todo As the pre install hooks need to run before cleaning this
# method should be refactored.
#
# @return [void] # @return [void]
# #
def clean! def clean!
...@@ -74,9 +71,6 @@ module Pod ...@@ -74,9 +71,6 @@ module Pod
# Locks the source files if appropriate. # Locks the source files if appropriate.
# #
# @todo As the pre install hooks need to run before cleaning this
# method should be refactored.
#
# @return [void] # @return [void]
# #
def lock_files!(file_accessors) def lock_files!(file_accessors)
...@@ -88,9 +82,6 @@ module Pod ...@@ -88,9 +82,6 @@ module Pod
# Unlocks the source files if appropriate. # Unlocks the source files if appropriate.
# #
# @todo As the pre install hooks need to run before cleaning this
# method should be refactored.
#
# @return [void] # @return [void]
# #
def unlock_files!(file_accessors) def unlock_files!(file_accessors)
......
...@@ -44,8 +44,6 @@ module Pod ...@@ -44,8 +44,6 @@ module Pod
# @param [Pathname] installation_root @see #installation_root # @param [Pathname] installation_root @see #installation_root
# @param [Array<AggregateTarget>] targets @see #targets # @param [Array<AggregateTarget>] targets @see #targets
# #
# @todo Too many initialization arguments
#
def initialize(podfile, sandbox, installation_root, targets) def initialize(podfile, sandbox, installation_root, targets)
@podfile = podfile @podfile = podfile
@sandbox = sandbox @sandbox = sandbox
......
...@@ -367,8 +367,6 @@ module Pod ...@@ -367,8 +367,6 @@ module Pod
# @return [Hash{String=>Pathname}] The path of the Pods' podspecs with a local source # @return [Hash{String=>Pathname}] The path of the Pods' podspecs with a local source
# grouped by their root name. # grouped by their root name.
# #
# @todo Rename (e.g. `pods_with_local_path`)
#
attr_reader :development_pods attr_reader :development_pods
# Checks if a Pod is locally sourced? # Checks if a Pod is locally sourced?
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment