Merge pull request #5021 from CocoaPods/seg-validate-headers-in-source-files

[Validator] Validate that header files are in source_files

CHANGELOG.md

@@ -20,6 +20,11 @@ To install release candidates run `[sudo] gem install cocoapods --pre`
   [Samuel Giddins](https://github.com/segiddins)
   [#5016](https://github.com/CocoaPods/CocoaPods/issues/5016)
 
+* The validator will check that all `public_header_files` and
+  `private_header_files` are also present in `source_files`.  
+  [Samuel Giddins](https://github.com/segiddins)
+  [#4936](https://github.com/CocoaPods/CocoaPods/issues/4936)
+
 ##### Bug Fixes
 
 * The master specs repository can no longer be added via `pod repo add`, but
@@ -36,6 +41,7 @@ To install release candidates run `[sudo] gem install cocoapods --pre`
   [Marius Rackwitz](https://github.com/mrackwitz)
   [#5022](https://github.com/CocoaPods/CocoaPods/issues/5022)
 
+
 ## 1.0.0.beta.5 (2016-03-08)
 
 ##### Breaking

lib/cocoapods/validator.rb

@@ -560,12 +560,18 @@ module Pod
     # Ensures that a list of header files only contains header files.
     #
     def _validate_header_files(attr_name)
-      non_header_files = file_accessor.send(attr_name).
+      header_files = file_accessor.send(attr_name)
+      non_header_files = header_files.
         select { |f| !Sandbox::FileAccessor::HEADER_EXTENSIONS.include?(f.extname) }.
         map { |f| f.relative_path_from(file_accessor.root) }
       unless non_header_files.empty?
         error(attr_name, "The pattern matches non-header files (#{non_header_files.join(', ')}).")
       end
+      non_source_files = header_files - file_accessor.source_files
+      unless non_source_files.empty?
+        error(attr_name, 'The pattern includes header files that are not listed' \
+          "in source_files (#{non_source_files.join(', ')}).")
+      end
     end
 
     def _validate_header_mappings_dir