Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
C
cocoapods
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
gengmeiios
cocoapods
Commits
10d1f50e
Commit
10d1f50e
authored
Feb 02, 2018
by
Paul Beusterien
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix received spelling
parent
9f9865c3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
9 additions
and
9 deletions
+9
-9
inspector_reporter.rb
lib/cocoapods/user_interface/inspector_reporter.rb
+4
-4
error_report_spec.rb
spec/unit/user_interface/error_report_spec.rb
+1
-1
inspector_reporter_spec.rb
spec/unit/user_interface/inspector_reporter_spec.rb
+4
-4
No files found.
lib/cocoapods/user_interface/inspector_reporter.rb
View file @
10d1f50e
...
@@ -19,7 +19,7 @@ module Pod
...
@@ -19,7 +19,7 @@ module Pod
UI
.
puts
"Looking for related issues on
#{
inspector
.
repo_owner
}
/
#{
inspector
.
repo_name
}
..."
UI
.
puts
"Looking for related issues on
#{
inspector
.
repo_owner
}
/
#{
inspector
.
repo_name
}
..."
end
end
# Called once the inspector has rec
ie
ved a report with more than one issue,
# Called once the inspector has rec
ei
ved a report with more than one issue,
# showing the top 3 issues, and offering a link to see more.
# showing the top 3 issues, and offering a link to see more.
#
#
# @param [GhInspector::InspectionReport] report
# @param [GhInspector::InspectionReport] report
...
@@ -30,7 +30,7 @@ module Pod
...
@@ -30,7 +30,7 @@ module Pod
#
#
# @return [void]
# @return [void]
#
#
def
inspector_successfully_rec
ie
ved_report
(
report
,
_
)
def
inspector_successfully_rec
ei
ved_report
(
report
,
_
)
report
.
issues
[
0
..
2
].
each
{
|
issue
|
print_issue_full
(
issue
)
}
report
.
issues
[
0
..
2
].
each
{
|
issue
|
print_issue_full
(
issue
)
}
if
report
.
issues
.
count
>
3
if
report
.
issues
.
count
>
3
...
@@ -39,7 +39,7 @@ module Pod
...
@@ -39,7 +39,7 @@ module Pod
end
end
end
end
# Called once the report has been rec
ie
ved, but when there are no issues found.
# Called once the report has been rec
ei
ved, but when there are no issues found.
#
#
# @param [GhInspector::InspectionReport] report
# @param [GhInspector::InspectionReport] report
# An empty report
# An empty report
...
@@ -49,7 +49,7 @@ module Pod
...
@@ -49,7 +49,7 @@ module Pod
#
#
# @return [void]
# @return [void]
#
#
def
inspector_rec
ie
ved_empty_report
(
_
,
inspector
)
def
inspector_rec
ei
ved_empty_report
(
_
,
inspector
)
UI
.
puts
'Found no similar issues. To create a new issue, please visit:'
UI
.
puts
'Found no similar issues. To create a new issue, please visit:'
UI
.
puts
"https://github.com/
#{
inspector
.
repo_owner
}
/
#{
inspector
.
repo_name
}
/issues/new"
UI
.
puts
"https://github.com/
#{
inspector
.
repo_owner
}
/
#{
inspector
.
repo_name
}
/issues/new"
end
end
...
...
spec/unit/user_interface/error_report_spec.rb
View file @
10d1f50e
...
@@ -111,7 +111,7 @@ EOS
...
@@ -111,7 +111,7 @@ EOS
message
.
should
==
'[!] at -'
message
.
should
==
'[!] at -'
end
end
it
'handles inspector_successfully_rec
ie
ved_report'
do
it
'handles inspector_successfully_rec
ei
ved_report'
do
time
=
Time
.
new
(
2016
,
5
,
13
)
time
=
Time
.
new
(
2016
,
5
,
13
)
Time
.
stubs
(
:now
).
returns
(
time
)
Time
.
stubs
(
:now
).
returns
(
time
)
...
...
spec/unit/user_interface/inspector_reporter_spec.rb
View file @
10d1f50e
...
@@ -7,9 +7,9 @@ class SilentEvidence
...
@@ -7,9 +7,9 @@ class SilentEvidence
def
inspector_is_still_investigating
(
query
,
inspector
);
end
def
inspector_is_still_investigating
(
query
,
inspector
);
end
def
inspector_successfully_rec
ie
ved_report
(
report
,
inspector
);
end
def
inspector_successfully_rec
ei
ved_report
(
report
,
inspector
);
end
def
inspector_rec
ie
ved_empty_report
(
report
,
inspector
);
end
def
inspector_rec
ei
ved_empty_report
(
report
,
inspector
);
end
def
inspector_could_not_create_report
(
error
,
query
,
inspector
);
end
def
inspector_could_not_create_report
(
error
,
query
,
inspector
);
end
end
end
...
@@ -24,7 +24,7 @@ module Pod
...
@@ -24,7 +24,7 @@ module Pod
UI
.
output
.
should
.
match
%r{Looking for related issues on cocoapods
\/
cocoapods}
UI
.
output
.
should
.
match
%r{Looking for related issues on cocoapods
\/
cocoapods}
end
end
it
'handles inspector_successfully_rec
ie
ved_report'
do
it
'handles inspector_successfully_rec
ei
ved_report'
do
url
=
'https://api.github.com/search/issues?q=Testing+repo:cocoapods/cocoapods'
url
=
'https://api.github.com/search/issues?q=Testing+repo:cocoapods/cocoapods'
fixture_json_text
=
File
.
read
SpecHelper
.
fixture
(
'github_search_response.json'
)
fixture_json_text
=
File
.
read
SpecHelper
.
fixture
(
'github_search_response.json'
)
GhInspector
::
Sidekick
.
any_instance
.
expects
(
:get_api_results
).
with
(
url
).
returns
(
JSON
.
parse
(
fixture_json_text
))
GhInspector
::
Sidekick
.
any_instance
.
expects
(
:get_api_results
).
with
(
url
).
returns
(
JSON
.
parse
(
fixture_json_text
))
...
@@ -33,7 +33,7 @@ module Pod
...
@@ -33,7 +33,7 @@ module Pod
report
=
inspector
.
search_query
'Testing'
,
SilentEvidence
.
new
report
=
inspector
.
search_query
'Testing'
,
SilentEvidence
.
new
reporter
=
UserInterface
::
InspectorReporter
.
new
reporter
=
UserInterface
::
InspectorReporter
.
new
reporter
.
inspector_successfully_rec
ie
ved_report
(
report
,
inspector
)
reporter
.
inspector_successfully_rec
ei
ved_report
(
report
,
inspector
)
UI
.
output
.
should
.
match
/Travis CI with Ruby 1.9.x fails for recent pull requests/
UI
.
output
.
should
.
match
/Travis CI with Ruby 1.9.x fails for recent pull requests/
UI
.
output
.
should
.
match
%r{https:
\/\/
github.com
\/
CocoaPods
\/
CocoaPods
\/
issues
\/
646
\[
closed
\]
\[
8 comments
\]
}
UI
.
output
.
should
.
match
%r{https:
\/\/
github.com
\/
CocoaPods
\/
CocoaPods
\/
issues
\/
646
\[
closed
\]
\[
8 comments
\]
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment