Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
C
cocoapods
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
gengmeiios
cocoapods
Commits
191eff09
Commit
191eff09
authored
Aug 22, 2017
by
Dimitris Koutsogiorgas
Committed by
GitHub
Aug 22, 2017
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #6968 from dnkoutso/wrap_with_quotes
Wrap platform warning message with quotes
parents
0dc40ad6
89c8549f
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
8 additions
and
4 deletions
+8
-4
CHANGELOG.md
CHANGELOG.md
+4
-0
target_inspector.rb
lib/cocoapods/installer/analyzer/target_inspector.rb
+2
-2
cocoapods-integration-specs
spec/cocoapods-integration-specs
+1
-1
target_inspector_spec.rb
spec/unit/installer/analyzer/target_inspector_spec.rb
+1
-1
No files found.
CHANGELOG.md
View file @
191eff09
...
...
@@ -18,6 +18,10 @@ To install release candidates run `[sudo] gem install cocoapods --pre`
##### Bug Fixes
*
Wrap platform warning message with quotes
[
Dimitris Koutsogiorgas
](
https://github.com/dnkoutso
)
[
#6968
](
https://github.com/CocoaPods/CocoaPods/pull/6968
)
*
Wire dependencies for pod targets not part of any aggregate target
[
Dimitris Koutsogiorgas
](
https://github.com/dnkoutso
)
[
#6948
](
https://github.com/CocoaPods/CocoaPods/pull/6948
)
...
...
lib/cocoapods/installer/analyzer/target_inspector.rb
View file @
191eff09
...
...
@@ -161,8 +161,8 @@ module Pod
"Unable to determine the platform for the `
#{
target_definition
.
name
}
` target."
end
UI
.
warn
"Automatically assigning platform
#{
name
}
with version
#{
deployment_target
}
"
\
"on target
#{
target_definition
.
name
}
because no platform was specified. "
\
UI
.
warn
"Automatically assigning platform
`
#{
name
}
` with version `
#{
deployment_target
}
`
"
\
"on target
`
#{
target_definition
.
name
}
`
because no platform was specified. "
\
"Please specify a platform for this target in your Podfile. See `
#{
PLATFORM_INFO_URL
}
`."
target_definition
.
set_platform
(
name
,
deployment_target
)
...
...
cocoapods-integration-specs
@
887db925
Subproject commit 8
e2ead35c3933543b2fbf9d554fcd59f9da9be57
Subproject commit 8
87db925362e22e065a1c410a18d71a670b1ec28
spec/unit/installer/analyzer/target_inspector_spec.rb
View file @
191eff09
...
...
@@ -232,7 +232,7 @@ module Pod
target_inspector
=
TargetInspector
.
new
(
target_definition
,
config
.
installation_root
)
platforms
=
target_inspector
.
send
(
:compute_platform
,
user_targets
)
platforms
.
should
==
Platform
.
new
(
:ios
,
'4.0'
)
UI
.
warnings
.
should
.
include
'Automatically assigning platform
ios with version 4.0 on target default
because no '
\
UI
.
warnings
.
should
.
include
'Automatically assigning platform
`ios` with version `4.0` on target `default`
because no '
\
'platform was specified. Please specify a platform for this target in your Podfile. '
\
'See `https://guides.cocoapods.org/syntax/podfile.html#platform`.'
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment