Merge pull request #3900 from CocoaPods/seg-delay-locking

[Installer] Delay source file locking

CHANGELOG.md

@@ -23,6 +23,11 @@ To install release candidates run `[sudo] gem install cocoapods --pre`
   [#3889](https://github.com/CocoaPods/CocoaPods/issues/3889)
   [#3884](https://github.com/CocoaPods/CocoaPods/issues/3884)
 
+* Source file locking now happens after plugin and podfile post-install hooks
+  have run.  
+  [Samuel Giddins](https://github.com/segiddins)
+  [#3529](https://github.com/CocoaPods/CocoaPods/issues/3529)
+
 
 ## 0.38.1
 

lib/cocoapods/installer.rb

 require 'active_support/core_ext/string/inflections'
+require 'fileutils'
 
 module Pod
   # The Installer is responsible of taking a Podfile and transform it in the
@@ -113,6 +114,7 @@ module Pod
 
     def prepare
       UI.message 'Preparing' do
+        FileUtils.chmod_R('+w', sandbox.root)
         sandbox.prepare
         ensure_plugins_are_installed!
         Migrator.migrate(sandbox)
@@ -141,7 +143,6 @@ module Pod
         install_pod_sources
         run_podfile_pre_install_hooks
         clean_pod_sources
-        lock_pod_sources
       end
     end
 
@@ -442,6 +443,7 @@ module Pod
     def perform_post_install_actions
       run_plugins_post_install_hooks
       warn_for_deprecations
+      lock_pod_sources
     end
 
     # Runs the registered callbacks for the plugins post install hooks.

lib/cocoapods/installer/pod_source_installer.rb

@@ -78,8 +78,7 @@ module Pod
         file_accessors.each do |file_accessor|
           file_accessor.source_files.each do |source_file|
             next unless source_file.exist?
-            new_permissions = source_file.stat.mode & ~0222
-            source_file.chmod(new_permissions)
+            FileUtils.chmod('-w', source_file)
           end
         end
       end

cocoapods-integration-specs @ 6e68269b

-Subproject commit 26bb687a87734a7b431074d2aca8b1a8c2f62c8c
+Subproject commit 6e68269b557236f9bd5afa3bc41b0f05d7d224ba