Commit 2220774b authored by Eloy Durán's avatar Eloy Durán

More cleanup using ActiveSupport's Oxford comma styling of a list.

parent 21bc6d45
require 'active_support/core_ext/array/conversions'
module Pod module Pod
class Command class Command
class Presenter class Presenter
...@@ -27,7 +29,7 @@ module Pod ...@@ -27,7 +29,7 @@ module Pod
end end
def authors def authors
oxfordify spec.authors.keys spec.authors.keys.to_sentence
end end
def homepage def homepage
...@@ -89,13 +91,6 @@ module Pod ...@@ -89,13 +91,6 @@ module Pod
end end
private private
def oxfordify words
if words.size < 3
words.join ' and '
else
"#{words[0..-2].join(', ')}, and #{words.last}"
end
end
def distance_from_now_in_words(from_time) def distance_from_now_in_words(from_time)
return nil unless from_time return nil unless from_time
......
require 'escape' require 'escape'
require 'active_support/core_ext/array/conversions'
module Pod module Pod
module Generator module Generator
...@@ -23,7 +24,7 @@ module Pod ...@@ -23,7 +24,7 @@ module Pod
def company def company
if @specification.authors if @specification.authors
@specification.authors.keys.sort.join(', ') @specification.authors.keys.sort.to_sentence
else else
'no-company' 'no-company'
end end
......
require 'active_support/core_ext/array/conversions'
module Pod module Pod
class Specification class Specification
class Set class Set
...@@ -18,7 +20,7 @@ module Pod ...@@ -18,7 +20,7 @@ module Pod
# TODO add graph that shows which dependencies led to this. # TODO add graph that shows which dependencies led to this.
raise Informative, "#{specification} tries to activate `#{dependency}', " \ raise Informative, "#{specification} tries to activate `#{dependency}', " \
"but already activated version `#{required_version}' " \ "but already activated version `#{required_version}' " \
"by #{@required_by.join(', ')}." "by #{@required_by.to_sentence}."
end end
@specification = nil @specification = nil
@required_by << specification @required_by << specification
......
...@@ -26,8 +26,8 @@ describe Pod::Generator::Documentation do ...@@ -26,8 +26,8 @@ describe Pod::Generator::Documentation do
@doc_installer.appledoc_options.should == [ @doc_installer.appledoc_options.should == [
'--project-name', 'BananaLib 1.0', '--project-name', 'BananaLib 1.0',
'--docset-desc', 'Full of chunky bananas.', '--docset-desc', 'Full of chunky bananas.',
'--project-company', 'Banana Corp, Monkey Boy', '--project-company', 'Banana Corp and Monkey Boy',
'--docset-copyright', 'Banana Corp, Monkey Boy', '--docset-copyright', 'Banana Corp and Monkey Boy',
'--company-id', 'org.cocoapods', '--company-id', 'org.cocoapods',
'--ignore', '.m', '--ignore', '.m',
'--keep-undocumented-objects', '--keep-undocumented-objects',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment