Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
C
cocoapods
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
gengmeiios
cocoapods
Commits
2a559b74
Commit
2a559b74
authored
Sep 27, 2016
by
Orta Therox
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove the superfluous call to gh inspector introduced in #5950
parent
162d573b
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
0 additions
and
45 deletions
+0
-45
CHANGELOG.md
CHANGELOG.md
+0
-4
install.rb
lib/cocoapods/command/install.rb
+0
-11
install_spec.rb
spec/functional/command/install_spec.rb
+0
-30
No files found.
CHANGELOG.md
View file @
2a559b74
...
@@ -12,10 +12,6 @@ To install release candidates run `[sudo] gem install cocoapods --pre`
...
@@ -12,10 +12,6 @@ To install release candidates run `[sudo] gem install cocoapods --pre`
[
Dimitris Koutsogiorgas
](
https://github.com/dnkoutso
)
[
Dimitris Koutsogiorgas
](
https://github.com/dnkoutso
)
[
#5837
](
https://github.com/CocoaPods/CocoaPods/pull/5837
)
[
#5837
](
https://github.com/CocoaPods/CocoaPods/pull/5837
)
*
GitHub issue inspection will now happen for any StandardError in a pod install
[
Orta Therox
](
https://github.com/orta
)
[
#5950
](
https://github.com/CocoaPods/CocoaPods/pull/5950
)
##### Bug Fixes
##### Bug Fixes
*
Remove special handling for messages apps
*
Remove special handling for messages apps
...
...
lib/cocoapods/command/install.rb
View file @
2a559b74
require
'gh_inspector'
module
Pod
module
Pod
class
Command
class
Command
class
Install
<
Command
class
Install
<
Command
...
@@ -37,15 +35,6 @@ module Pod
...
@@ -37,15 +35,6 @@ module Pod
installer
.
repo_update
=
repo_update?
(
:default
=>
false
)
installer
.
repo_update
=
repo_update?
(
:default
=>
false
)
installer
.
update
=
false
installer
.
update
=
false
installer
.
install!
installer
.
install!
rescue
StandardError
=>
e
search_for_exceptions
(
e
)
raise
e
end
def
search_for_exceptions
(
exception
)
inspector
=
GhInspector
::
Inspector
.
new
'cocoapods'
,
'cocoapods'
message_delegate
=
UserInterface
::
InspectorReporter
.
new
inspector
.
search_exception
exception
,
message_delegate
end
end
end
end
end
end
...
...
spec/functional/command/install_spec.rb
View file @
2a559b74
...
@@ -27,35 +27,5 @@ module Pod
...
@@ -27,35 +27,5 @@ module Pod
run_command
(
'install'
,
'--repo-update'
)
run_command
(
'install'
,
'--repo-update'
)
end
end
end
end
describe
'Issue Inspection'
do
before
do
file
=
temporary_directory
+
'Podfile'
File
.
open
(
file
,
'w'
)
do
|
f
|
f
.
puts
(
'platform :ios'
)
f
.
puts
(
'pod "Reachability"'
)
end
end
it
'passes raised StandardError to the GH Inspector'
do
error
=
StandardError
# Replace first method call with raising an error
Pod
::
Command
.
any_instance
.
expects
(
:installer_for_config
).
raises
(
error
,
'message'
)
# Ensure that gh inspector is called
Command
::
Install
.
any_instance
.
expects
(
:search_for_exceptions
).
returns
(
''
)
lambda
{
run_command
(
'install'
)
}.
should
.
raise
error
end
it
'does not pass CP Informative errors to the GH Inspector'
do
error
=
Pod
::
Informative
Pod
::
Command
.
any_instance
.
expects
(
:installer_for_config
).
raises
(
error
,
'message'
)
# Ensure that gh inspector is not called
Command
::
Install
.
any_instance
.
expects
(
:search_for_exceptions
).
never
lambda
{
run_command
(
'install'
)
}.
should
.
raise
error
end
end
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment