[PodTarget] Ensure the deployment target is high enough for frameworks

lib/cocoapods/installer.rb

@@ -380,6 +380,7 @@ module Pod
       aggregate_targets.each do |aggregate_target|
         aggregate_target.pod_targets.each do |pod_target|
           pod_target.host_requires_frameworks ||= aggregate_target.requires_frameworks?
+          pod_target.platform = nil # needs to be recomputed
         end
       end
     end

lib/cocoapods/installer/target_installer/pod_target_installer.rb

@@ -325,18 +325,6 @@ module Pod
         end
       end
 
-      # The deployment target for the pod target, which is the maximum of all
-      # the deployment targets for the current platform of the target.
-      #
-      # @return [String] The deployment target.
-      #
-      def deployment_target
-        default = Podfile::TargetDefinition::PLATFORM_DEFAULTS[target.platform.name]
-        target.specs.map do |spec|
-          Pod::Version.new(spec.deployment_target(target.platform.name) || default)
-        end.max.to_s
-      end
-
       #-----------------------------------------------------------------------#
     end
   end

lib/cocoapods/target/pod_target.rb

@@ -88,12 +88,30 @@ module Pod
       end
     end
 
-    # @return [Platform] the platform for this target.
+    # The deployment target for the pod target, which is the maximum of all
+    # the deployment targets for the current platform of the target.
+    #
+    # @return [String] The deployment target.
     #
     def platform
-      @platform ||= target_definitions.first.platform
+      @platform ||= begin
+        platform_name = target_definitions.first.platform.name
+        default = Podfile::TargetDefinition::PLATFORM_DEFAULTS[platform_name]
+        deployment_target = specs.map do |spec|
+          version = Pod::Version.new(spec.deployment_target(platform_name) || default)
+          if platform_name == :ios && requires_frameworks?
+            minimum = Version.new('8.0')
+            version = [version, minimum].max
+          end
+          version
+        end.max
+        Platform.new(platform_name, deployment_target)
+      end
     end
 
+    # @visibility private
+    attr_writer :platform
+
     # @return [Podfile] The podfile which declares the dependency.
     #
     def podfile

lib/cocoapods/validator.rb

@@ -364,8 +364,16 @@ module Pod
       Config.instance = @original_config
     end
 
-    def download_pod
+    def deployment_target
       deployment_target = spec.subspec_by_name(subspec_name).deployment_target(consumer.platform_name)
+      if consumer.platform_name == :ios && use_frameworks
+        minimum = Version.new('8.0')
+        deployment_target = [Version.new(deployment_target), minimum].max.to_s
+      end
+      deployment_target
+    end
+
+    def download_pod
       podfile = podfile_from_spec(consumer.platform_name, deployment_target, use_frameworks)
       sandbox = Sandbox.new(config.sandbox_root)
       @installer = Installer.new(sandbox, podfile)
@@ -376,7 +384,6 @@ module Pod
 
     def create_app_project
       app_project = Xcodeproj::Project.new(validation_dir + 'App.xcodeproj')
-      deployment_target = spec.subspec_by_name(subspec_name).deployment_target(consumer.platform_name)
       app_project.new_target(:application, 'App', consumer.platform_name, deployment_target)
       app_project.save
       app_project.recreate_user_schemes

spec/unit/installer/target_installer/pod_target_installer_spec.rb

@@ -49,8 +49,17 @@ module Pod
         target.build_settings('Debug')['IPHONEOS_DEPLOYMENT_TARGET'].should == '4.3'
       end
 
+      it 'sets the platform and the deployment target for iOS targets that require frameworks' do
+        @pod_target.stubs(:requires_frameworks?).returns(true)
+        @installer.install!
+        target = @project.targets.first
+        target.platform_name.should == :ios
+        target.deployment_target.should == '8.0'
+        target.build_settings('Debug')['IPHONEOS_DEPLOYMENT_TARGET'].should == '8.0'
+      end
+
       it 'sets the platform and the deployment target for OS X targets' do
-        @pod_target.stubs(:platform).returns(Platform.new(:osx, '10.8'))
+        @pod_target.target_definitions.first.stubs(:platform).returns(Platform.new(:osx, '10.8'))
         @installer.install!
         target = @project.targets.first
         target.platform_name.should == :osx