Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
C
cocoapods
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
gengmeiios
cocoapods
Commits
31d25e71
Commit
31d25e71
authored
Oct 13, 2014
by
Samuel E. Giddins
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[ResolverSpec] Make specs for conflict messages more precise
parent
01b2fa5b
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
25 additions
and
4 deletions
+25
-4
Gemfile.lock
Gemfile.lock
+1
-1
resolver.rb
lib/cocoapods/resolver.rb
+7
-1
resolver_spec.rb
spec/unit/resolver_spec.rb
+17
-2
No files found.
Gemfile.lock
View file @
31d25e71
...
...
@@ -18,7 +18,7 @@ GIT
GIT
remote: https://github.com/CocoaPods/Resolver.git
revision: 8
241b8f2079928cd4fc58416e8c7796811d541c6
revision: 8
f5241546ce3f67756d87547154b88445b306933
branch: master
specs:
resolver (0.0.1)
...
...
lib/cocoapods/resolver.rb
View file @
31d25e71
...
...
@@ -118,8 +118,14 @@ module Pod
dependency
.
name
end
def
name_for_explicit_dependency_source
'Podfile'
end
def
requirement_satisfied_by?
(
requirement
,
activated
,
spec
)
existing
=
activated
.
vertices
.
values
.
map
(
&
:payload
).
compact
.
find
{
|
s
|
Specification
.
root_name
(
s
.
name
)
==
Specification
.
root_name
(
requirement
.
name
)
}
existing
=
activated
.
vertices
.
values
.
map
(
&
:payload
).
compact
.
find
do
|
s
|
Specification
.
root_name
(
s
.
name
)
==
Specification
.
root_name
(
requirement
.
name
)
end
if
existing
existing
.
version
==
spec
.
version
&&
requirement
.
requirement
.
satisfied_by?
(
spec
.
version
)
...
...
spec/unit/resolver_spec.rb
View file @
31d25e71
...
...
@@ -194,15 +194,30 @@ module Pod
config
.
sandbox
.
head_pod?
(
'JSONKit'
).
should
.
be
.
true
end
it
'raises if it finds two conflicting dependencies'
do
it
'raises if it finds two conflicting
explicit
dependencies'
do
podfile
=
Podfile
.
new
do
platform
:ios
pod
'JSONKit'
,
'1.4'
pod
'JSONKit'
,
'1.5pre'
end
resolver
=
Resolver
.
new
(
config
.
sandbox
,
podfile
,
[],
SourcesManager
.
all
)
e
=
lambda
{
resolver
.
resolve
}.
should
.
raise
Pod
::
Informative
e
=
lambda
{
resolver
.
resolve
}.
should
.
raise
Informative
e
.
message
.
should
.
match
(
/Unable to satisfy the following requirements/
)
e
.
message
.
should
.
match
(
/`JSONKit \(= 1.4\)` required by `Podfile`/
)
e
.
message
.
should
.
match
(
/`JSONKit \(= 1.5pre\)` required by `Podfile`/
)
end
it
'raises if it finds two conflicting dependencies'
do
podfile
=
Podfile
.
new
do
platform
:ios
pod
'RestKit'
,
'0.23.3'
# dependends on AFNetworking ~> 1.3.0
pod
'AFNetworking'
,
'> 2'
end
resolver
=
Resolver
.
new
(
config
.
sandbox
,
podfile
,
[],
SourcesManager
.
all
)
e
=
lambda
{
resolver
.
resolve
}.
should
.
raise
Informative
e
.
message
.
should
.
match
(
/Unable to satisfy the following requirements/
)
e
.
message
.
should
.
match
(
/`AFNetworking \(~> 1.3.0\)` required by `RestKit\/Network \(.*\)`/
)
e
.
message
.
should
.
match
(
/`AFNetworking \(> 2\)` required by `Podfile`/
)
end
it
'takes into account locked dependencies'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment