Commit 35edc176 authored by Samuel E. Giddins's avatar Samuel E. Giddins

Merge pull request #4317 from CocoaPods/seg-resource-bundle-deployment-targets

[PodTargetInstaller] Set deployment target for resource bundle targets
parents 77834ba0 283df9e4
...@@ -56,6 +56,10 @@ To install release candidates run `[sudo] gem install cocoapods --pre` ...@@ -56,6 +56,10 @@ To install release candidates run `[sudo] gem install cocoapods --pre`
[Samuel Giddins](https://github.com/segiddins) [Samuel Giddins](https://github.com/segiddins)
[#4354](https://github.com/CocoaPods/CocoaPods/issues/3454) [#4354](https://github.com/CocoaPods/CocoaPods/issues/3454)
* Set a deployment target for resource bundle targets.
[Samuel Giddins](https://github.com/segiddins)
[#3347](https://github.com/CocoaPods/CocoaPods/issues/3347)
##### Bug Fixes ##### Bug Fixes
* Improve repo lint error message when no repo found with given name. * Improve repo lint error message when no repo found with given name.
......
...@@ -112,6 +112,7 @@ module Pod ...@@ -112,6 +112,7 @@ module Pod
file_references = paths.map { |sf| project.reference_for_path(sf) } file_references = paths.map { |sf| project.reference_for_path(sf) }
label = target.resources_bundle_target_label(bundle_name) label = target.resources_bundle_target_label(bundle_name)
bundle_target = project.new_resources_bundle(label, file_accessor.spec_consumer.platform_name) bundle_target = project.new_resources_bundle(label, file_accessor.spec_consumer.platform_name)
bundle_target.deployment_target = deployment_target
bundle_target.product_reference.tap do |bundle_product| bundle_target.product_reference.tap do |bundle_product|
bundle_file_name = "#{bundle_name}.bundle" bundle_file_name = "#{bundle_name}.bundle"
bundle_product.name = bundle_file_name bundle_product.name = bundle_file_name
......
Subproject commit e0dba63b7fba6b23736c588dba46e32be8e975b8 Subproject commit ad385c014ac0c5f5b28fd22aa7c136554b9b6bf0
...@@ -148,6 +148,8 @@ module Pod ...@@ -148,6 +148,8 @@ module Pod
bundle_target.should.be.an.instance_of Xcodeproj::Project::Object::PBXNativeTarget bundle_target.should.be.an.instance_of Xcodeproj::Project::Object::PBXNativeTarget
bundle_target.product_reference.name.should == 'banana_bundle.bundle' bundle_target.product_reference.name.should == 'banana_bundle.bundle'
bundle_target.product_reference.path.should == 'banana_bundle.bundle' bundle_target.product_reference.path.should == 'banana_bundle.bundle'
bundle_target.platform_name.should == :ios
bundle_target.deployment_target.should == '4.3'
end end
it 'adds the build configurations to the resources bundle targets' do it 'adds the build configurations to the resources bundle targets' do
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment