Introduced two new classes: LocalPod and Sandbox.

The Sandbox represents the entire contents of the POD_ROOT (normally SOURCE_ROOT/Pods). A LocalPod represents a pod that has been installed within the Sandbox.

These two classes can be used as better homes for various pieces of logic currently spread throughout the installation process and provide a better API for working with the contents of this directory.

So far I've just refactored the downloaders to use them.

lib/cocoapods.rb

@@ -11,6 +11,7 @@ module Pod
   autoload :Downloader,             'cocoapods/downloader'
   autoload :Executable,             'cocoapods/executable'
   autoload :Installer,              'cocoapods/installer'
+  autoload :LocalPod,               'cocoapods/local_pod'
   autoload :Platform,               'cocoapods/platform'
   autoload :Podfile,                'cocoapods/podfile'
   autoload :Resolver,               'cocoapods/resolver'

lib/cocoapods/downloader.rb

@@ -6,29 +6,31 @@ module Pod
 
     extend Executable
 
-    def self.for_source(pod_root, source)
-      options = source.dup
+    def self.for_pod(pod)
+      options = pod.specification.source.dup
       if url = options.delete(:git)
-        Git.new(pod_root, url, options)
+        Git.new(pod, url, options)
       elsif url = options.delete(:hg)
-        Mercurial.new(pod_root, url, options)
+        Mercurial.new(pod, url, options)
       elsif url = options.delete(:svn)
-        Subversion.new(pod_root, url, options)
+        Subversion.new(pod, url, options)
       else
-        raise "Unsupported download strategy `#{source.inspect}'."
+        raise "Unsupported download strategy `#{options.inspect}'."
       end
     end
 
-    attr_reader :pod_root, :url, :options
+    attr_reader :pod, :url, :options
 
-    def initialize(pod_root, url, options)
-      @pod_root, @url, @options = pod_root, url, options
+    def initialize(pod, url, options)
+      @pod, @url, @options = pod, url, options
     end
 
     def clean(clean_paths = [])
+      return unless clean_paths
+      
       clean_paths.each do |path|
         path.rmtree
-      end if clean_paths
+      end
     end
   end
 end

lib/cocoapods/downloader/git.rb

@@ -4,10 +4,9 @@ module Pod
       executable :git
 
       def download
-        @pod_root.dirname.mkpath
-        if @options[:tag]
+        if options[:tag]
           download_tag
-        elsif @options[:commit]
+        elsif options[:commit]
           download_commit
         else
           download_head
@@ -15,32 +14,31 @@ module Pod
       end
 
       def download_head
-        git "clone '#{@url}' '#{@pod_root}'"
+        git "clone '#{url}' '#{pod.root}'"
       end
 
       def download_tag
-        @pod_root.mkpath
-        Dir.chdir(@pod_root) do
+        pod.chdir do
           git "init"
-          git "remote add origin '#{@url}'"
-          git "fetch origin tags/#{@options[:tag]}"
+          git "remote add origin '#{url}'"
+          git "fetch origin tags/#{options[:tag]}"
           git "reset --hard FETCH_HEAD"
           git "checkout -b activated-pod-commit"
         end
       end
 
       def download_commit
-        git "clone '#{@url}' '#{@pod_root}'"
-        Dir.chdir(@pod_root) do
-          git "checkout -b activated-pod-commit #{@options[:commit]}"
+        git "clone '#{url}' '#{pod.root}'"
+        
+        pod.chdir do
+          git "checkout -b activated-pod-commit #{options[:commit]}"
         end
       end
 
       def clean(clean_paths = [])
         super
-        (@pod_root + '.git').rmtree
+        (pod.root + '.git').rmtree
       end
     end
   end
 end
-

lib/cocoapods/downloader/mercurial.rb

@@ -4,8 +4,7 @@ module Pod
       executable :hg
 
       def download
-        @pod_root.dirname.mkpath
-        if @options[:revision]
+        if options[:revision]
           download_revision
         else
           download_head
@@ -13,16 +12,16 @@ module Pod
       end
 
       def download_head
-        hg "clone '#{@url}' '#{@pod_root}'"
+        hg "clone '#{url}' '#{pod.root}'"
       end
 
       def download_revision
-        hg "clone '#{@url}' --rev '#{@options[:revision]}' '#{@pod_root}'"
+        hg "clone '#{url}' --rev '#{options[:revision]}' '#{pod.root}'"
       end
 
       def clean(clean_paths = [])
         super
-        (@pod_root + '.hg').rmtree
+        (pod.root + '.hg').rmtree
       end
     end
   end

lib/cocoapods/downloader/subversion.rb

@@ -4,8 +4,7 @@ module Pod
       executable :svn
 
       def download
-        @pod_root.dirname.mkpath
-        if @options[:revision]
+        if options[:revision]
           download_revision
         else
           download_head
@@ -13,16 +12,16 @@ module Pod
       end
 
       def download_head
-        svn "checkout '#{@url}' '#{@pod_root}'"
+        svn "checkout '#{url}' '#{pod_root}'"
       end
 
       def download_revision
-        svn "checkout '#{@url}' -r '#{@options[:revision]}' '#{@pod_root}'"
+        svn "checkout '#{url}' -r '#{options[:revision]}' '#{pod.root}'"
       end
 
       def clean(clean_paths = [])
         super
-        @pod_root.glob('**/.svn').each(&:rmtree)
+        pod.root.glob('**/.svn').each(&:rmtree)
       end
     end
   end

lib/cocoapods/installer.rb

@@ -20,6 +20,8 @@ module Pod
 
     include Config::Mixin
     include Shared
+    
+    attr_reader :sandbox
 
     def initialize(podfile)
       @podfile = podfile
@@ -63,7 +65,8 @@ module Pod
         else
           puts "Installing #{spec}" unless config.silent?
           spec = spec.part_of_specification if spec.part_of_other_pod?
-          downloader = Downloader.for_source(spec.pod_destroot, spec.source)
+          pod = Pod.new(sandbox, spec)
+          downloader = Downloader.for_pod(pod)
           downloader.download
           # TODO move cleaning into the installer as well
           downloader.clean(spec.expanded_clean_paths) if config.clean

lib/cocoapods/local_pod.rb

+module Pod
+  class LocalPod
+    attr_reader :specification
+    
+    def initialize(specification, sandbox)
+      @specification, @sandbox = specification, sandbox
+    end
+    
+    def root
+      @sandbox.root + specification.name
+    end
+    
+    def create
+      root.mkpath unless root.exist?
+    end
+    
+    def chdir(&block)
+      create
+      Dir.chdir(root, &block)
+    end
+    
+    def implode
+      root.rmtree if root.exist?
+    end
+  end
+end

lib/cocoapods/sandbox.rb

+module Pod
+  class Sandbox
+    attr_reader :root
+    
+    def initialize(path)
+      @root = path
+      FileUtils.mkdir_p(@root)
+    end
+    
+    def implode
+      @root.rmtree
+    end
+  end
+end

lib/cocoapods/specification.rb

@@ -13,7 +13,7 @@ module Pod
       unless path.exist?
         raise Informative, "No podspec exists at path `#{path}'."
       end
-      spec = Pod._eval_podspec(path)
+      spec = ::Pod._eval_podspec(path)
       spec.defined_in_file = path
       spec
     end

spec/spec_helper.rb

@@ -40,3 +40,14 @@ class Pod::Spec::Set
     @sets = nil
   end
 end
+
+require 'tmpdir'
+
+def temporary_sandbox
+  Pod::Sandbox.new(Pathname.new(Dir.mktmpdir))
+end
+
+def fixture_spec(name)
+  file = SpecHelper::Fixture.fixture(name)
+  Pod::Specification.from_file(file)
+end

spec/unit/downloader_spec.rb

 require File.expand_path('../../spec_helper', __FILE__)
 
 describe "Pod::Downloader" do
-  it "returns a git downloader" do
-    downloader = Pod::Downloader.for_source(
-      '/path/to/pod_root',
-      :git => 'http://example.local/banana.git', :tag => 'v1.0'
-    )
+  it "returns a git downloader with parsed options" do
+    pod = Pod::LocalPod.new(fixture_spec('banana-lib/BananaLib.podspec'), temporary_sandbox)
+    downloader = Pod::Downloader.for_pod(pod)
     downloader.should.be.instance_of Pod::Downloader::Git
-    downloader.pod_root.should == '/path/to/pod_root'
-    downloader.url.should == 'http://example.local/banana.git'
+    downloader.url.should == 'http://banana-corp.local/banana-lib.git'
     downloader.options.should == { :tag => 'v1.0' }
   end
 end

spec/unit/local_pod_spec.rb

+require File.expand_path('../../spec_helper', __FILE__)
+
+describe Pod::LocalPod do
+
+  # a LocalPod represents a local copy of the dependency, inside the pod root, built from a spec
+  
+  before do
+    @spec = Pod::Specification.from_file(fixture('banana-lib/BananaLib.podspec'))
+    @sandbox = temporary_sandbox
+    @pod = Pod::LocalPod.new(@spec, @sandbox)
+  end
+  
+  it 'returns the Pod root directory path' do
+    @pod.root.should == @sandbox.root + 'BananaLib'
+  end
+  
+  it "creates it's own root directory if it doesn't exist" do
+    @pod.create
+    File.directory?(@pod.root).should.be.true
+  end
+  
+  it "can execute a block within the context of it's root" do
+    @pod.chdir { FileUtils.touch("foo") }
+    Pathname(@pod.root + "foo").should.exist
+  end
+  
+  it 'can delete itself' do
+    @pod.create
+    @pod.implode
+    @pod.root.should.not.exist
+  end
+end

spec/unit/sandbox_spec.rb

+require File.expand_path('../../spec_helper', __FILE__)
+require 'tmpdir'
+
+TMP_POD_ROOT = ROOT + "tmp" + "podroot"
+
+describe Pod::Sandbox do
+
+  before do 
+    @sandbox = Pod::Sandbox.new(TMP_POD_ROOT)
+  end
+  
+  after do
+    @sandbox.implode
+  end
+  
+  it "automatically creates the TMP_POD_ROOT if it doesn't exist" do
+    File.directory?(TMP_POD_ROOT).should.be.true
+  end
+  
+  it "deletes the entire root directory on implode" do
+    @sandbox.implode
+    File.directory?(TMP_POD_ROOT).should.be.false
+    FileUtils.mkdir(TMP_POD_ROOT) # put it back again
+  end
+
+end