Unverified Commit 4739ff19 authored by Dimitris Koutsogiorgas's avatar Dimitris Koutsogiorgas Committed by GitHub

Merge pull request #7510 from dnkoutso/fix_module_name_test_specs

Fix `PRODUCT_MODULE_NAME` for test generated targets
parents 67d662c2 5d7c7d3b
...@@ -59,6 +59,10 @@ To install release candidates run `[sudo] gem install cocoapods --pre` ...@@ -59,6 +59,10 @@ To install release candidates run `[sudo] gem install cocoapods --pre`
[Dimitris Koutsogiorgas](https://github.com/dnkoutso) [Dimitris Koutsogiorgas](https://github.com/dnkoutso)
[#7511](https://github.com/CocoaPods/CocoaPods/issues/7511) [#7511](https://github.com/CocoaPods/CocoaPods/issues/7511)
* Fix `PRODUCT_MODULE_NAME` for generated test targets
[Dimitris Koutsogiorgas](https://github.com/dnkoutso)
[#7507](https://github.com/CocoaPods/CocoaPods/issues/7507)
* Ensure `SWIFT_VERSION` is set for test only pod targets during validation * Ensure `SWIFT_VERSION` is set for test only pod targets during validation
[Dimitris Koutsogiorgas](https://github.com/dnkoutso) [Dimitris Koutsogiorgas](https://github.com/dnkoutso)
[#7498](https://github.com/CocoaPods/CocoaPods/issues/7498) [#7498](https://github.com/CocoaPods/CocoaPods/issues/7498)
......
...@@ -277,6 +277,7 @@ module Pod ...@@ -277,6 +277,7 @@ module Pod
# requires frameworks. For tests we always use the test target name as the product name # requires frameworks. For tests we always use the test target name as the product name
# irrelevant to whether we use frameworks or not. # irrelevant to whether we use frameworks or not.
configuration.build_settings['PRODUCT_NAME'] = name configuration.build_settings['PRODUCT_NAME'] = name
configuration.build_settings['PRODUCT_MODULE_NAME'] = name
# We must codesign iOS XCTest bundles that contain binary frameworks to allow them to be launchable in the simulator # We must codesign iOS XCTest bundles that contain binary frameworks to allow them to be launchable in the simulator
unless target.platform == :osx unless target.platform == :osx
configuration.build_settings['CODE_SIGNING_REQUIRED'] = 'YES' configuration.build_settings['CODE_SIGNING_REQUIRED'] = 'YES'
......
...@@ -199,6 +199,7 @@ module Pod ...@@ -199,6 +199,7 @@ module Pod
native_test_target.product_reference.name.should == 'CoconutLib-Unit-Tests' native_test_target.product_reference.name.should == 'CoconutLib-Unit-Tests'
native_test_target.build_configurations.each do |bc| native_test_target.build_configurations.each do |bc|
bc.build_settings['PRODUCT_NAME'].should == 'CoconutLib-Unit-Tests' bc.build_settings['PRODUCT_NAME'].should == 'CoconutLib-Unit-Tests'
bc.build_settings['PRODUCT_MODULE_NAME'].should == 'CoconutLib-Unit-Tests'
bc.build_settings['CODE_SIGNING_REQUIRED'].should == 'YES' bc.build_settings['CODE_SIGNING_REQUIRED'].should == 'YES'
bc.build_settings['CODE_SIGNING_ALLOWED'].should == 'YES' bc.build_settings['CODE_SIGNING_ALLOWED'].should == 'YES'
bc.build_settings['CODE_SIGN_IDENTITY'].should == 'iPhone Developer' bc.build_settings['CODE_SIGN_IDENTITY'].should == 'iPhone Developer'
...@@ -216,6 +217,7 @@ module Pod ...@@ -216,6 +217,7 @@ module Pod
native_test_target.product_reference.name.should == 'CoconutLib-Unit-Tests' native_test_target.product_reference.name.should == 'CoconutLib-Unit-Tests'
native_test_target.build_configurations.each do |bc| native_test_target.build_configurations.each do |bc|
bc.build_settings['PRODUCT_NAME'].should == 'CoconutLib-Unit-Tests' bc.build_settings['PRODUCT_NAME'].should == 'CoconutLib-Unit-Tests'
bc.build_settings['PRODUCT_MODULE_NAME'].should == 'CoconutLib-Unit-Tests'
bc.build_settings['CODE_SIGNING_REQUIRED'].should.be.nil bc.build_settings['CODE_SIGNING_REQUIRED'].should.be.nil
bc.build_settings['CODE_SIGNING_ALLOWED'].should.be.nil bc.build_settings['CODE_SIGNING_ALLOWED'].should.be.nil
bc.build_settings['CODE_SIGN_IDENTITY'].should == '' bc.build_settings['CODE_SIGN_IDENTITY'].should == ''
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment