Remove usage of deprecated ALWAYS_SEARCH_USER_PATHS build setting

lib/cocoapods/generator/xcconfig/aggregate_xcconfig.rb

@@ -16,7 +16,6 @@ module Pod
       #
       def generate
         config = {
-          'ALWAYS_SEARCH_USER_PATHS'         => 'YES',
           'OTHER_LDFLAGS'                    => default_ld_flags,
           'HEADER_SEARCH_PATHS'              => quote(sandbox.public_headers.search_paths),
           'PODS_ROOT'                        => target.relative_pods_root,

lib/cocoapods/generator/xcconfig/private_pod_xcconfig.rb

@@ -15,7 +15,6 @@ module Pod
       #
       def generate
         config = {
-          'ALWAYS_SEARCH_USER_PATHS'     => 'YES',
           'OTHER_LDFLAGS'                => default_ld_flags,
           'PODS_ROOT'                    => '${SRCROOT}',
           'HEADER_SEARCH_PATHS'          => quote(target.build_headers.search_paths) + ' ' + quote(sandbox.public_headers.search_paths),

lib/cocoapods/installer/target_installer/aggregate_target_installer.rb

@@ -29,9 +29,6 @@ module Pod
 
       # Generates the contents of the xcconfig file and saves it to disk.
       #
-      # @note   The `ALWAYS_SEARCH_USER_PATHS` flag is enabled to support
-      #         libraries like `EmbedReader`.
-      #
       # @return [void]
       #
       def create_xcconfig_file

lib/cocoapods/installer/target_installer/pod_target_installer.rb

@@ -51,9 +51,6 @@ module Pod
 
       # Generates the contents of the xcconfig file and saves it to disk.
       #
-      # @note   The `ALWAYS_SEARCH_USER_PATHS` flag is enabled to support
-      #         libraries like `EmbedReader`.
-      #
       # @return [void]
       #
       def create_xcconfig_file

spec/integration/install_add_pod/after/Pods/Pods-JSONKit-Private.xcconfig

 #include "Pods-JSONKit"
-ALWAYS_SEARCH_USER_PATHS = YES
 GCC_PREPROCESSOR_DEFINITIONS = COCOAPODS=1
 HEADER_SEARCH_PATHS = "${PODS_ROOT}/BuildHeaders" "${PODS_ROOT}/BuildHeaders/JSONKit" "${PODS_ROOT}/Headers" "${PODS_ROOT}/Headers/JSONKit" "${PODS_ROOT}/Headers/Reachability"
 OTHER_LDFLAGS = -ObjC

spec/integration/install_add_pod/after/Pods/Pods-Reachability-Private.xcconfig

 #include "Pods-Reachability"
-ALWAYS_SEARCH_USER_PATHS = YES
 GCC_PREPROCESSOR_DEFINITIONS = COCOAPODS=1
 HEADER_SEARCH_PATHS = "${PODS_ROOT}/BuildHeaders" "${PODS_ROOT}/BuildHeaders/Reachability" "${PODS_ROOT}/Headers" "${PODS_ROOT}/Headers/JSONKit" "${PODS_ROOT}/Headers/Reachability"
 OTHER_LDFLAGS = -ObjC ${PODS_REACHABILITY_OTHER_LDFLAGS}

spec/integration/install_add_pod/after/Pods/Pods.xcconfig

 #include "Pods-JSONKit"
 #include "Pods-Reachability"
-ALWAYS_SEARCH_USER_PATHS = YES
 GCC_PREPROCESSOR_DEFINITIONS = $(inherited) COCOAPODS=1
 HEADER_SEARCH_PATHS = "${PODS_ROOT}/Headers" "${PODS_ROOT}/Headers/JSONKit" "${PODS_ROOT}/Headers/Reachability"
 OTHER_LDFLAGS = -ObjC ${PODS_REACHABILITY_OTHER_LDFLAGS}

spec/integration/install_custom_workspace/after/Pods/Pods-SampleApp_1-Reachability-Private.xcconfig

 #include "Pods-SampleApp_1-Reachability"
-ALWAYS_SEARCH_USER_PATHS = YES
 GCC_PREPROCESSOR_DEFINITIONS = COCOAPODS=1
 HEADER_SEARCH_PATHS = "${PODS_ROOT}/BuildHeaders" "${PODS_ROOT}/BuildHeaders/Reachability" "${PODS_ROOT}/Headers" "${PODS_ROOT}/Headers/Reachability"
 OTHER_LDFLAGS = -ObjC ${PODS_SAMPLEAPP___REACHABILITY_OTHER_LDFLAGS}

spec/integration/install_custom_workspace/after/Pods/Pods-SampleApp_1.xcconfig

 #include "Pods-SampleApp_1-Reachability"
-ALWAYS_SEARCH_USER_PATHS = YES
 GCC_PREPROCESSOR_DEFINITIONS = $(inherited) COCOAPODS=1
 HEADER_SEARCH_PATHS = "${PODS_ROOT}/Headers" "${PODS_ROOT}/Headers/Reachability"
 OTHER_LDFLAGS = -ObjC ${PODS_SAMPLEAPP___REACHABILITY_OTHER_LDFLAGS}

spec/integration/install_custom_workspace/after/Pods/Pods-SampleApp_2-Reachability-Private.xcconfig

 #include "Pods-SampleApp_2-Reachability"
-ALWAYS_SEARCH_USER_PATHS = YES
 GCC_PREPROCESSOR_DEFINITIONS = COCOAPODS=1
 HEADER_SEARCH_PATHS = "${PODS_ROOT}/BuildHeaders" "${PODS_ROOT}/BuildHeaders/Reachability" "${PODS_ROOT}/Headers" "${PODS_ROOT}/Headers/Reachability"
 OTHER_LDFLAGS = -ObjC ${PODS_SAMPLEAPP___REACHABILITY_OTHER_LDFLAGS}

spec/integration/install_custom_workspace/after/Pods/Pods-SampleApp_2.xcconfig

 #include "Pods-SampleApp_2-Reachability"
-ALWAYS_SEARCH_USER_PATHS = YES
 GCC_PREPROCESSOR_DEFINITIONS = $(inherited) COCOAPODS=1
 HEADER_SEARCH_PATHS = "${PODS_ROOT}/Headers" "${PODS_ROOT}/Headers/Reachability"
 OTHER_LDFLAGS = -ObjC ${PODS_SAMPLEAPP___REACHABILITY_OTHER_LDFLAGS}

spec/integration/install_external_source/after/Pods/Pods-PodTest-Private.xcconfig

 #include "Pods-PodTest"
-ALWAYS_SEARCH_USER_PATHS = YES
 GCC_PREPROCESSOR_DEFINITIONS = COCOAPODS=1
 HEADER_SEARCH_PATHS = "${PODS_ROOT}/BuildHeaders" "${PODS_ROOT}/BuildHeaders/PodTest" "${PODS_ROOT}/Headers" "${PODS_ROOT}/Headers/PodTest"
 OTHER_LDFLAGS = -ObjC

spec/integration/install_external_source/after/Pods/Pods.xcconfig

 #include "Pods-PodTest"
-ALWAYS_SEARCH_USER_PATHS = YES
 GCC_PREPROCESSOR_DEFINITIONS = $(inherited) COCOAPODS=1
 HEADER_SEARCH_PATHS = "${PODS_ROOT}/Headers" "${PODS_ROOT}/Headers/PodTest"
 OTHER_LDFLAGS = -ObjC

spec/integration/install_local_source/after/Pods/Pods-Reachability-Private.xcconfig

 #include "Pods-Reachability"
-ALWAYS_SEARCH_USER_PATHS = YES
 GCC_PREPROCESSOR_DEFINITIONS = COCOAPODS=1
 HEADER_SEARCH_PATHS = "${PODS_ROOT}/BuildHeaders" "${PODS_ROOT}/BuildHeaders/Reachability" "${PODS_ROOT}/Headers" "${PODS_ROOT}/Headers/Reachability"
 OTHER_LDFLAGS = -ObjC ${PODS_REACHABILITY_OTHER_LDFLAGS}

spec/integration/install_local_source/after/Pods/Pods.xcconfig

 #include "Pods-Reachability"
-ALWAYS_SEARCH_USER_PATHS = YES
 GCC_PREPROCESSOR_DEFINITIONS = $(inherited) COCOAPODS=1
 HEADER_SEARCH_PATHS = "${PODS_ROOT}/Headers" "${PODS_ROOT}/Headers/Reachability"
 OTHER_LDFLAGS = -ObjC ${PODS_REACHABILITY_OTHER_LDFLAGS}

spec/integration/install_multiple_targets/after/Pods/Pods-Reachability-Private.xcconfig

 #include "Pods-Reachability"
-ALWAYS_SEARCH_USER_PATHS = YES
 GCC_PREPROCESSOR_DEFINITIONS = COCOAPODS=1
 HEADER_SEARCH_PATHS = "${PODS_ROOT}/BuildHeaders" "${PODS_ROOT}/BuildHeaders/Reachability" "${PODS_ROOT}/Headers" "${PODS_ROOT}/Headers/JSONKit" "${PODS_ROOT}/Headers/Reachability"
 OTHER_LDFLAGS = -ObjC ${PODS_REACHABILITY_OTHER_LDFLAGS}

spec/integration/install_multiple_targets/after/Pods/Pods-SampleApp_2-JSONKit-Private.xcconfig

 #include "Pods-SampleApp_2-JSONKit"
-ALWAYS_SEARCH_USER_PATHS = YES
 GCC_PREPROCESSOR_DEFINITIONS = COCOAPODS=1
 HEADER_SEARCH_PATHS = "${PODS_ROOT}/BuildHeaders" "${PODS_ROOT}/BuildHeaders/JSONKit" "${PODS_ROOT}/Headers" "${PODS_ROOT}/Headers/JSONKit" "${PODS_ROOT}/Headers/Reachability"
 OTHER_LDFLAGS = -ObjC

spec/integration/install_multiple_targets/after/Pods/Pods-SampleApp_2-Reachability-Private.xcconfig

 #include "Pods-SampleApp_2-Reachability"
-ALWAYS_SEARCH_USER_PATHS = YES
 GCC_PREPROCESSOR_DEFINITIONS = COCOAPODS=1
 HEADER_SEARCH_PATHS = "${PODS_ROOT}/BuildHeaders" "${PODS_ROOT}/BuildHeaders/Reachability" "${PODS_ROOT}/Headers" "${PODS_ROOT}/Headers/JSONKit" "${PODS_ROOT}/Headers/Reachability"
 OTHER_LDFLAGS = -ObjC ${PODS_SAMPLEAPP___REACHABILITY_OTHER_LDFLAGS}

spec/integration/install_multiple_targets/after/Pods/Pods-SampleApp_2.xcconfig

 #include "Pods-SampleApp_2-JSONKit"
 #include "Pods-SampleApp_2-Reachability"
-ALWAYS_SEARCH_USER_PATHS = YES
 GCC_PREPROCESSOR_DEFINITIONS = $(inherited) COCOAPODS=1
 HEADER_SEARCH_PATHS = "${PODS_ROOT}/Headers" "${PODS_ROOT}/Headers/JSONKit" "${PODS_ROOT}/Headers/Reachability"
 OTHER_LDFLAGS = -ObjC ${PODS_SAMPLEAPP___REACHABILITY_OTHER_LDFLAGS}

spec/integration/install_multiple_targets/after/Pods/Pods-test-JSONKit-Private.xcconfig

 #include "Pods-test-JSONKit"
-ALWAYS_SEARCH_USER_PATHS = YES
 GCC_PREPROCESSOR_DEFINITIONS = COCOAPODS=1
 HEADER_SEARCH_PATHS = "${PODS_ROOT}/BuildHeaders" "${PODS_ROOT}/BuildHeaders/JSONKit" "${PODS_ROOT}/Headers" "${PODS_ROOT}/Headers/JSONKit" "${PODS_ROOT}/Headers/Reachability"
 OTHER_LDFLAGS = -ObjC

spec/integration/install_multiple_targets/after/Pods/Pods-test.xcconfig

 #include "Pods-test-JSONKit"
-ALWAYS_SEARCH_USER_PATHS = YES
 GCC_PREPROCESSOR_DEFINITIONS = $(inherited) COCOAPODS=1
 HEADER_SEARCH_PATHS = "${PODS_ROOT}/Headers" "${PODS_ROOT}/Headers/JSONKit" "${PODS_ROOT}/Headers/Reachability"
 OTHER_LDFLAGS = -ObjC

spec/integration/install_multiple_targets/after/Pods/Pods.xcconfig

 #include "Pods-Reachability"
-ALWAYS_SEARCH_USER_PATHS = YES
 GCC_PREPROCESSOR_DEFINITIONS = $(inherited) COCOAPODS=1
 HEADER_SEARCH_PATHS = "${PODS_ROOT}/Headers" "${PODS_ROOT}/Headers/JSONKit" "${PODS_ROOT}/Headers/Reachability"
 OTHER_LDFLAGS = -ObjC ${PODS_REACHABILITY_OTHER_LDFLAGS}

spec/integration/install_new/after/Pods/Pods-Reachability-Private.xcconfig

 #include "Pods-Reachability"
-ALWAYS_SEARCH_USER_PATHS = YES
 GCC_PREPROCESSOR_DEFINITIONS = COCOAPODS=1
 HEADER_SEARCH_PATHS = "${PODS_ROOT}/BuildHeaders" "${PODS_ROOT}/BuildHeaders/Reachability" "${PODS_ROOT}/Headers" "${PODS_ROOT}/Headers/Reachability"
 OTHER_LDFLAGS = -ObjC ${PODS_REACHABILITY_OTHER_LDFLAGS}

spec/integration/install_new/after/Pods/Pods.xcconfig

 #include "Pods-Reachability"
-ALWAYS_SEARCH_USER_PATHS = YES
 GCC_PREPROCESSOR_DEFINITIONS = $(inherited) COCOAPODS=1
 HEADER_SEARCH_PATHS = "${PODS_ROOT}/Headers" "${PODS_ROOT}/Headers/Reachability"
 OTHER_LDFLAGS = -ObjC ${PODS_REACHABILITY_OTHER_LDFLAGS}

spec/integration/install_podfile_callbacks/after/Pods/Pods-Reachability-Private.xcconfig

 #include "Pods-Reachability"
-ALWAYS_SEARCH_USER_PATHS = YES
 GCC_PREPROCESSOR_DEFINITIONS = COCOAPODS=1
 HEADER_SEARCH_PATHS = "${PODS_ROOT}/BuildHeaders" "${PODS_ROOT}/BuildHeaders/Reachability" "${PODS_ROOT}/Headers" "${PODS_ROOT}/Headers/Reachability"
 OTHER_LDFLAGS = -ObjC ${PODS_REACHABILITY_OTHER_LDFLAGS}

spec/integration/install_podfile_callbacks/after/Pods/Pods.xcconfig

 #include "Pods-Reachability"
-ALWAYS_SEARCH_USER_PATHS = YES
 GCC_PREPROCESSOR_DEFINITIONS = $(inherited) COCOAPODS=1
 HEADER_SEARCH_PATHS = "${PODS_ROOT}/Headers" "${PODS_ROOT}/Headers/Reachability"
 OTHER_LDFLAGS = -ObjC ${PODS_REACHABILITY_OTHER_LDFLAGS}

spec/integration/install_podspec/after/Pods/Pods-Reachability-Private.xcconfig

 #include "Pods-Reachability"
-ALWAYS_SEARCH_USER_PATHS = YES
 GCC_PREPROCESSOR_DEFINITIONS = COCOAPODS=1
 HEADER_SEARCH_PATHS = "${PODS_ROOT}/BuildHeaders" "${PODS_ROOT}/BuildHeaders/Reachability" "${PODS_ROOT}/Headers" "${PODS_ROOT}/Headers/Reachability"
 OTHER_LDFLAGS = -ObjC ${PODS_REACHABILITY_OTHER_LDFLAGS}

spec/integration/install_podspec/after/Pods/Pods.xcconfig

 #include "Pods-Reachability"
-ALWAYS_SEARCH_USER_PATHS = YES
 GCC_PREPROCESSOR_DEFINITIONS = $(inherited) COCOAPODS=1
 HEADER_SEARCH_PATHS = "${PODS_ROOT}/Headers" "${PODS_ROOT}/Headers/Reachability"
 OTHER_LDFLAGS = -ObjC ${PODS_REACHABILITY_OTHER_LDFLAGS}

spec/integration/install_remove_pod/after/Pods/Pods-Reachability-Private.xcconfig

 #include "Pods-Reachability"
-ALWAYS_SEARCH_USER_PATHS = YES
 GCC_PREPROCESSOR_DEFINITIONS = COCOAPODS=1
 HEADER_SEARCH_PATHS = "${PODS_ROOT}/BuildHeaders" "${PODS_ROOT}/BuildHeaders/Reachability" "${PODS_ROOT}/Headers" "${PODS_ROOT}/Headers/Reachability"
 OTHER_LDFLAGS = -ObjC ${PODS_REACHABILITY_OTHER_LDFLAGS}

spec/integration/install_remove_pod/after/Pods/Pods.xcconfig

 #include "Pods-Reachability"
-ALWAYS_SEARCH_USER_PATHS = YES
 GCC_PREPROCESSOR_DEFINITIONS = $(inherited) COCOAPODS=1
 HEADER_SEARCH_PATHS = "${PODS_ROOT}/Headers" "${PODS_ROOT}/Headers/Reachability"
 OTHER_LDFLAGS = -ObjC ${PODS_REACHABILITY_OTHER_LDFLAGS}

spec/integration/install_spec_callbacks/after/Pods/Pods-Reachability-Private.xcconfig

 #include "Pods-Reachability"
-ALWAYS_SEARCH_USER_PATHS = YES
 GCC_PREPROCESSOR_DEFINITIONS = COCOAPODS=1
 HEADER_SEARCH_PATHS = "${PODS_ROOT}/BuildHeaders" "${PODS_ROOT}/BuildHeaders/Reachability" "${PODS_ROOT}/Headers" "${PODS_ROOT}/Headers/Reachability"
 OTHER_LDFLAGS = -ObjC ${PODS_REACHABILITY_OTHER_LDFLAGS}

spec/integration/install_spec_callbacks/after/Pods/Pods.xcconfig

 #include "Pods-Reachability"
-ALWAYS_SEARCH_USER_PATHS = YES
 GCC_PREPROCESSOR_DEFINITIONS = $(inherited) COCOAPODS=1
 HEADER_SEARCH_PATHS = "${PODS_ROOT}/Headers" "${PODS_ROOT}/Headers/Reachability"
 OTHER_LDFLAGS = -ObjC ${PODS_REACHABILITY_OTHER_LDFLAGS}

spec/integration/install_subspecs/after/Pods/Pods-OS X App-PodTest-Private.xcconfig

 #include "Pods-OS X App-PodTest"
-ALWAYS_SEARCH_USER_PATHS = YES
 GCC_PREPROCESSOR_DEFINITIONS = COCOAPODS=1
 HEADER_SEARCH_PATHS = "${PODS_ROOT}/BuildHeaders" "${PODS_ROOT}/BuildHeaders/PodTest" "${PODS_ROOT}/Headers" "${PODS_ROOT}/Headers/PodTest"
 OTHER_LDFLAGS = -ObjC

spec/integration/install_subspecs/after/Pods/Pods-OS X App.xcconfig

 #include "Pods-OS X App-PodTest"
-ALWAYS_SEARCH_USER_PATHS = YES
 GCC_PREPROCESSOR_DEFINITIONS = $(inherited) COCOAPODS=1
 HEADER_SEARCH_PATHS = "${PODS_ROOT}/Headers" "${PODS_ROOT}/Headers/PodTest"
 OTHER_LDFLAGS = -ObjC

spec/integration/install_subspecs/after/Pods/Pods-iOS App-PodTest-Private.xcconfig

 #include "Pods-iOS App-PodTest"
-ALWAYS_SEARCH_USER_PATHS = YES
 GCC_PREPROCESSOR_DEFINITIONS = COCOAPODS=1
 HEADER_SEARCH_PATHS = "${PODS_ROOT}/BuildHeaders" "${PODS_ROOT}/BuildHeaders/PodTest" "${PODS_ROOT}/Headers" "${PODS_ROOT}/Headers/PodTest"
 OTHER_LDFLAGS = -ObjC

spec/integration/install_subspecs/after/Pods/Pods-iOS App.xcconfig

 #include "Pods-iOS App-PodTest"
-ALWAYS_SEARCH_USER_PATHS = YES
 GCC_PREPROCESSOR_DEFINITIONS = $(inherited) COCOAPODS=1
 HEADER_SEARCH_PATHS = "${PODS_ROOT}/Headers" "${PODS_ROOT}/Headers/PodTest"
 OTHER_LDFLAGS = -ObjC

spec/integration/update/after/Pods/Pods-Reachability-Private.xcconfig

 #include "Pods-Reachability"
-ALWAYS_SEARCH_USER_PATHS = YES
 GCC_PREPROCESSOR_DEFINITIONS = COCOAPODS=1
 HEADER_SEARCH_PATHS = "${PODS_ROOT}/BuildHeaders" "${PODS_ROOT}/BuildHeaders/Reachability" "${PODS_ROOT}/Headers" "${PODS_ROOT}/Headers/Reachability"
 OTHER_LDFLAGS = -ObjC ${PODS_REACHABILITY_OTHER_LDFLAGS}

spec/integration/update/after/Pods/Pods.xcconfig

 #include "Pods-Reachability"
-ALWAYS_SEARCH_USER_PATHS = YES
 GCC_PREPROCESSOR_DEFINITIONS = $(inherited) COCOAPODS=1
 HEADER_SEARCH_PATHS = "${PODS_ROOT}/Headers" "${PODS_ROOT}/Headers/Reachability"
 OTHER_LDFLAGS = -ObjC ${PODS_REACHABILITY_OTHER_LDFLAGS}

spec/unit/generator/xcconfig/aggregate_xcconfig_spec.rb

@@ -36,10 +36,6 @@ module Pod
       @xcconfig.class.should == Xcodeproj::Config
     end
 
-    it "sets to always search the user paths" do
-      @xcconfig.to_hash['ALWAYS_SEARCH_USER_PATHS'].should == 'YES'
-    end
-
     it "configures the project to load all members that implement Objective-c classes or categories from the static library" do
       @xcconfig.to_hash['OTHER_LDFLAGS'].should.include '-ObjC'
     end

spec/unit/generator/xcconfig/private_pod_xcconfig_spec.rb

@@ -27,10 +27,6 @@ module Pod
       @xcconfig.class.should == Xcodeproj::Config
     end
 
-    it "sets to always search the user paths" do
-      @xcconfig.to_hash['ALWAYS_SEARCH_USER_PATHS'].should == 'YES'
-    end
-
     it "configures the project to load all members that implement Objective-c classes or categories from the static library" do
       @xcconfig.to_hash['OTHER_LDFLAGS'].should.include '-ObjC'
     end