Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
C
cocoapods
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
gengmeiios
cocoapods
Commits
591d8ecc
Commit
591d8ecc
authored
Oct 24, 2015
by
Samuel E. Giddins
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #4442 from manuyavuz/imp/repoLintErrorMessaging
Improve repo lint error messaging
parents
71f65fff
1f2554c0
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
19 additions
and
7 deletions
+19
-7
CHANGELOG.md
CHANGELOG.md
+5
-1
lint.rb
lib/cocoapods/command/repo/lint.rb
+7
-6
lint_spec.rb
spec/functional/command/repo/lint_spec.rb
+7
-0
No files found.
CHANGELOG.md
View file @
591d8ecc
...
...
@@ -13,12 +13,16 @@ To install release candidates run `[sudo] gem install cocoapods --pre`
[
Samuel Giddins
](
https://github.com/segiddins
)
[
#4374
](
https://github.com/CocoaPods/CocoaPods/issues/4374
)
*
Improving the performance of Pod::Installer::Analyzer#generate_pod_targets
*
Improving the performance of Pod::Installer::Analyzer#generate_pod_targets
[
Daniel Ribeiro
](
https://github.com/danielribeiro
)
[
#4399
](
https://github.com/CocoaPods/CocoaPods/pull/4399
)
##### Bug Fixes
*
Improve repo lint error message when no repo found with given name.
[
Muhammed Yavuz Nuzumlalı
](
https://github.com/manuyavuz
)
[
#4142
](
https://github.com/CocoaPods/CocoaPods/issues/4142
)
*
Fix a crash in dependency resolution when running Ruby 2.3.
[
Samuel Giddins
](
https://github.com/segiddins
)
[
#4345
](
https://github.com/CocoaPods/CocoaPods/issues/4345
)
...
...
lib/cocoapods/command/repo/lint.rb
View file @
591d8ecc
...
...
@@ -35,15 +35,16 @@ module Pod
#
def
run
if
@name
dirs
=
File
.
exist?
(
@name
)
?
[
Pathname
.
new
(
@name
)]
:
[
dir
]
sources
=
SourcesManager
.
sources
([
@name
])
else
dirs
=
config
.
repos_dir
.
children
.
select
(
&
:directory?
)
sources
=
SourcesManager
.
aggregate
.
sources
end
dirs
.
each
do
|
dir
|
SourcesManager
.
check_version_information
(
dir
)
UI
.
puts
"
\n
Linting spec repo `
#{
dir
.
realpath
.
basename
}
`
\n
"
.
yellow
validator
=
Source
::
HealthReporter
.
new
(
dir
)
sources
.
each
do
|
source
|
SourcesManager
.
check_version_information
(
source
.
repo
)
UI
.
puts
"
\n
Linting spec repo `
#{
source
.
repo
.
basename
}
`
\n
"
.
yellow
validator
=
Source
::
HealthReporter
.
new
(
source
.
repo
)
validator
.
pre_check
do
|
_name
,
_version
|
UI
.
print
'.'
end
...
...
spec/functional/command/repo/lint_spec.rb
View file @
591d8ecc
...
...
@@ -16,5 +16,12 @@ module Pod
repo
=
fixture
(
'spec-repos/test_repo'
).
to_s
lambda
{
run_command
(
'repo'
,
'lint'
,
repo
)
}.
should
.
not
.
raise
end
it
'raises when there is no repository with given name'
do
repo
=
fixture
(
'spec-repos/not_existing_repo'
).
to_s
e
=
lambda
{
run_command
(
'repo'
,
'lint'
,
repo
)
}.
should
.
raise
Informative
e
.
message
.
should
.
match
(
/Unable to find a source named/
)
e
.
message
.
should
.
match
(
/not_existing_repo/
)
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment