[Config] Spec robustness

lib/cocoapods/config.rb

@@ -112,10 +112,10 @@ module Pod
 
     # @!group Initialization
 
-    def initialize
+    def initialize(use_user_settings = true)
       configure_with(DEFAULTS)
 
-      if user_settings_file.exist?
+      if use_user_settings && user_settings_file.exist?
         require 'yaml'
         user_settings = YAML.load_file(user_settings_file)
         configure_with(user_settings)

spec/unit/config_spec.rb

@@ -4,7 +4,7 @@ module Pod
 
   describe Config do
     before do
-      Config.instance = nil
+      @sut = Config.new(false)
     end
 
     #-------------------------------------------------------------------------#
@@ -12,27 +12,27 @@ module Pod
     describe "In general" do
 
       it "returns the singleton config instance" do
-        config.should.be.instance_of Config
+        @sut.should.be.instance_of Config
       end
 
       it "returns the path to the spec-repos dir" do
-        config.repos_dir.should == Pathname.new("~/.cocoapods").expand_path
+        @sut.repos_dir.should == Pathname.new("~/.cocoapods").expand_path
       end
 
       it "returns the path to the spec-repos dir" do
-        config.repos_dir.should == Pathname.new("~/.cocoapods").expand_path
+        @sut.repos_dir.should == Pathname.new("~/.cocoapods").expand_path
       end
 
       it "allows to specify whether the aggressive cache should be used with an environment variable" do
-        config.aggressive_cache = false
+        @sut.aggressive_cache = false
         ENV['CP_AGGRESSIVE_CACHE'] = 'TRUE'
-        config.aggressive_cache?.should.be.true
+        @sut.aggressive_cache?.should.be.true
         ENV.delete('CP_AGGRESSIVE_CACHE')
       end
 
       it "allows to specify the repos dir with an environment variable" do
         ENV['CP_REPOS_DIR'] = '~/custom_repos_dir'
-        config.repos_dir.should == Pathname.new("~/custom_repos_dir").expand_path
+        @sut.repos_dir.should == Pathname.new("~/custom_repos_dir").expand_path
         ENV.delete('CP_REPOS_DIR')
       end
     end
@@ -44,7 +44,7 @@ module Pod
       it "returns the working directory as the installation root if a Podfile can be found" do
         Dir.chdir(temporary_directory) do
           File.open("Podfile", "w") {}
-          config.installation_root.should == temporary_directory
+          @sut.installation_root.should == temporary_directory
         end
       end
 
@@ -54,54 +54,54 @@ module Pod
           sub_dir = temporary_directory + 'sub_dir'
           sub_dir.mkpath
           Dir.chdir(sub_dir) do
-            config.installation_root.should == temporary_directory
+            @sut.installation_root.should == temporary_directory
           end
         end
       end
 
       it "it returns the working directory as the installation root if no Podfile can be found" do
         Dir.chdir(temporary_directory) do
-          config.installation_root.should == temporary_directory
+          @sut.installation_root.should == temporary_directory
         end
       end
 
       before do
-        config.installation_root = temporary_directory
+        @sut.installation_root = temporary_directory
       end
 
       it "returns the path to the project root" do
-        config.installation_root.should == temporary_directory
+        @sut.installation_root.should == temporary_directory
       end
 
       it "returns the path to the project Podfile if it exists" do
         (temporary_directory + 'Podfile').open('w') { |f| f << '# Yo' }
-        config.podfile_path.should == temporary_directory + 'Podfile'
+        @sut.podfile_path.should == temporary_directory + 'Podfile'
       end
 
       it "can detect yaml Podfiles" do
         (temporary_directory + 'CocoaPods.podfile.yaml').open('w') { |f| f << '# Yo' }
-        config.podfile_path.should == temporary_directory + 'CocoaPods.podfile.yaml'
+        @sut.podfile_path.should == temporary_directory + 'CocoaPods.podfile.yaml'
       end
 
       it "can detect files named `CocoaPods.podfile`" do
         (temporary_directory + 'CocoaPods.podfile').open('w') { |f| f << '# Yo' }
-        config.podfile_path.should == temporary_directory + 'CocoaPods.podfile'
+        @sut.podfile_path.should == temporary_directory + 'CocoaPods.podfile'
       end
 
       it "returns the path to the Pods directory that holds the dependencies" do
-        config.sandbox_root.should == temporary_directory + 'Pods'
+        @sut.sandbox_root.should == temporary_directory + 'Pods'
       end
 
       it "returns the Podfile path" do
         Dir.chdir(temporary_directory) do
           File.open("Podfile", "w") {}
-          config.podfile_path.should == temporary_directory + "Podfile"
+          @sut.podfile_path.should == temporary_directory + "Podfile"
         end
       end
 
       it "returns nils if the Podfile if no paths exists" do
         Dir.chdir(temporary_directory) do
-          config.podfile_path.should == nil
+          @sut.podfile_path.should == nil
         end
       end
 
@@ -109,16 +109,16 @@ module Pod
         Dir.chdir(temporary_directory) do
           File.open("Podfile", "w") {}
           File.open("Podfile.lock", "w") {}
-          config.lockfile_path.should == temporary_directory + "Podfile.lock"
+          @sut.lockfile_path.should == temporary_directory + "Podfile.lock"
         end
       end
 
       it "returns the statistics cache file" do
-        config.statistics_cache_file.to_s.should.end_with?('statistics.yml')
+        @sut.statistics_cache_file.to_s.should.end_with?('statistics.yml')
       end
 
       it "returns the search index file" do
-        config.search_index_file.to_s.should.end_with?('search_index.yaml')
+        @sut.search_index_file.to_s.should.end_with?('search_index.yaml')
       end
 
     end
@@ -127,32 +127,28 @@ module Pod
 
     describe "Default settings" do
 
-      before do
-        Config.any_instance.stubs(:user_settings_file).returns(Pathname.new('not_found'))
-      end
-
       it "prints out normal information" do
-        config.should.not.be.silent
+        @sut.should.not.be.silent
       end
 
       it "does not print verbose information" do
-        config.should.not.be.verbose
+        @sut.should.not.be.verbose
       end
 
       it "cleans SCM dirs in dependency checkouts" do
-        config.should.clean
+        @sut.should.clean
       end
 
       it "has a default cache size of 500" do
-        config.max_cache_size.should == 500
+        @sut.max_cache_size.should == 500
       end
 
       it "returns the cache root" do
-        config.cache_root.should == Pathname.new(File.join(ENV['HOME'], 'Library/Caches/CocoaPods'))
+        @sut.cache_root.should == Pathname.new(File.join(ENV['HOME'], 'Library/Caches/CocoaPods'))
       end
 
       it "doesn't use aggressive cache" do
-        config.should.not.aggressive_cache?
+        @sut.should.not.aggressive_cache?
       end
 
     end
@@ -162,17 +158,17 @@ module Pod
     describe "Dependency Injection" do
 
       it "returns the downloader" do
-        downloader = config.downloader(Pathname.new(''), { :git => 'example.com' })
+        downloader = @sut.downloader(Pathname.new(''), { :git => 'example.com' })
         downloader.target_path.should == Pathname.new('')
         downloader.url.should == 'example.com'
-        downloader.cache_root.should == config.cache_root
+        downloader.cache_root.should == @sut.cache_root
         downloader.max_cache_size.should == 500
         downloader.aggressive_cache.should.be.false
       end
 
       it "returns the specification statistics provider" do
-        stats_provider = config.spec_statistics_provider
-        stats_provider.cache_file.should == config.cache_root + 'statistics.yml'
+        stats_provider = @sut.spec_statistics_provider
+        stats_provider.cache_file.should == @sut.cache_root + 'statistics.yml'
       end
 
     end
@@ -182,13 +178,13 @@ module Pod
     describe "Private helpers" do
 
       it "returns the path of the user settings file" do
-        config.send(:user_settings_file).should == Pathname.new("~/.cocoapods/config.yaml").expand_path
+        @sut.send(:user_settings_file).should == Pathname.new("~/.cocoapods/config.yaml").expand_path
       end
 
       it "can be configured with a hash" do
         hash = { :verbose => true }
-        config.send(:configure_with, hash)
-        config.should.be.verbose
+        @sut.send(:configure_with, hash)
+        @sut.should.be.verbose
       end
 
       #----------------------------------------#
@@ -198,26 +194,26 @@ module Pod
         it "detects the CocoaPods.podfile.yaml file" do
           expected = temporary_directory + "CocoaPods.podfile.yaml"
           File.open(expected, "w") {}
-          path = config.send(:podfile_path_in_dir, temporary_directory)
+          path = @sut.send(:podfile_path_in_dir, temporary_directory)
           path.should == expected
         end
 
         it "detects the CocoaPods.podfile file" do
           expected = temporary_directory + "CocoaPods.podfile"
           File.open(expected, "w") {}
-          path = config.send(:podfile_path_in_dir, temporary_directory)
+          path = @sut.send(:podfile_path_in_dir, temporary_directory)
           path.should == expected
         end
 
         it "detects the Podfile file" do
           expected = temporary_directory + "Podfile"
           File.open(expected, "w") {}
-          path = config.send(:podfile_path_in_dir, temporary_directory)
+          path = @sut.send(:podfile_path_in_dir, temporary_directory)
           path.should == expected
         end
 
         it "returns nils if the Podfile is not available" do
-          path = config.send(:podfile_path_in_dir, temporary_directory)
+          path = @sut.send(:podfile_path_in_dir, temporary_directory)
           path.should == nil
         end