Unverified Commit 5cffb44f authored by Samuel Giddins's avatar Samuel Giddins Committed by GitHub

Merge pull request #7544 from dnkoutso/validator_warnings_off

Inhibit warnings for all dependencies during validation except for the one being validated  
parents a6838e8d bc63080b
...@@ -13,7 +13,9 @@ To install release candidates run `[sudo] gem install cocoapods --pre` ...@@ -13,7 +13,9 @@ To install release candidates run `[sudo] gem install cocoapods --pre`
##### Bug Fixes ##### Bug Fixes
* None. * Inhibit warnings for all dependencies during validation except for the one being validated
[Dimitris Koutsogiorgas](https://github.com/dnkoutso)
[#7434](https://github.com/CocoaPods/CocoaPods/issues/7434)
## 1.5.0 (2018-04-04) ## 1.5.0 (2018-04-04)
......
...@@ -808,20 +808,22 @@ module Pod ...@@ -808,20 +808,22 @@ module Pod
urls = source_urls urls = source_urls
Pod::Podfile.new do Pod::Podfile.new do
install! 'cocoapods', :deterministic_uuids => false install! 'cocoapods', :deterministic_uuids => false
# By default inhibit warnings for all pods, except the one being validated.
inhibit_all_warnings!
urls.each { |u| source(u) } urls.each { |u| source(u) }
target 'App' do target 'App' do
use_frameworks!(use_frameworks) use_frameworks!(use_frameworks)
platform(platform_name, deployment_target) platform(platform_name, deployment_target)
if local if local
pod name, :path => podspec.dirname.to_s pod name, :path => podspec.dirname.to_s, :inhibit_warnings => false
else else
pod name, :podspec => podspec.to_s pod name, :podspec => podspec.to_s, :inhibit_warnings => false
end end
test_spec_names.each do |test_spec_name| test_spec_names.each do |test_spec_name|
if local if local
pod test_spec_name, :path => podspec.dirname.to_s pod test_spec_name, :path => podspec.dirname.to_s, :inhibit_warnings => false
else else
pod test_spec_name, :podspec => podspec.to_s pod test_spec_name, :podspec => podspec.to_s, :inhibit_warnings => false
end end
end end
end end
......
...@@ -395,6 +395,13 @@ module Pod ...@@ -395,6 +395,13 @@ module Pod
(!!target_definition.uses_frameworks?).should == false (!!target_definition.uses_frameworks?).should == false
# rubocop:enable Style/DoubleNegation # rubocop:enable Style/DoubleNegation
end end
it 'inhibits warnings for all pods except the one being validated' do
podfile = @validator.send(:podfile_from_spec, :ios, '5.0')
target_definition = podfile.target_definitions['App']
target_definition.should.not.inhibits_warnings_for_pod?('JSONKit')
target_definition.should.inhibits_warnings_for_pod?('NotJSONKit')
end
end end
it 'empties sources when no dependencies' do it 'empties sources when no dependencies' do
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment