Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
C
cocoapods
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
gengmeiios
cocoapods
Commits
6c8b9cb3
Commit
6c8b9cb3
authored
Jan 18, 2018
by
Samuel Giddins
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[Resolver] Avoid extra allocations in #valid_dependencies_for_target_from_node
parent
d94cf0bc
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
13 additions
and
10 deletions
+13
-10
resolver.rb
lib/cocoapods/resolver.rb
+13
-10
No files found.
lib/cocoapods/resolver.rb
View file @
6c8b9cb3
...
@@ -558,14 +558,15 @@ module Pod
...
@@ -558,14 +558,15 @@ module Pod
def
valid_dependencies_for_target_from_node
(
target
,
dependencies
,
node
)
def
valid_dependencies_for_target_from_node
(
target
,
dependencies
,
node
)
dependencies
[
node
.
name
]
||=
begin
dependencies
[
node
.
name
]
||=
begin
validate_platform
(
node
.
payload
,
target
)
validate_platform
(
node
.
payload
,
target
)
dependency_nodes
=
node
.
outgoing_edges
.
select
do
|
edge
|
dependency_nodes
=
[]
edge_is_valid_for_target?
(
edge
,
target
)
node
.
outgoing_edges
.
each
do
|
edge
|
end
.
map
(
&
:destination
)
next
unless
edge_is_valid_for_target?
(
edge
,
target
)
dependency_nodes
<<
edge
.
destination
dependency_nodes
+
dependency_nodes
.
flat_map
do
|
item
|
node_result
=
valid_dependencies_for_target_from_node
(
target
,
dependencies
,
item
)
node_result
end
end
dependency_nodes
.
flat_map
do
|
item
|
valid_dependencies_for_target_from_node
(
target
,
dependencies
,
item
)
end
.
concat
dependency_nodes
end
end
end
end
...
@@ -575,9 +576,11 @@ module Pod
...
@@ -575,9 +576,11 @@ module Pod
# @return [Bool]
# @return [Bool]
#
#
def
edge_is_valid_for_target?
(
edge
,
target
)
def
edge_is_valid_for_target?
(
edge
,
target
)
dependencies_for_target_platform
=
requirement_name
=
edge
.
requirement
.
name
edge
.
origin
.
payload
.
all_dependencies
(
target
.
platform
).
map
(
&
:name
)
dependencies_for_target_platform
.
include?
(
edge
.
requirement
.
name
)
edge
.
origin
.
payload
.
all_dependencies
(
target
.
platform
).
any?
do
|
dep
|
dep
.
name
==
requirement_name
end
end
end
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment