Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
C
cocoapods
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
gengmeiios
cocoapods
Commits
7dfa9eff
Commit
7dfa9eff
authored
Sep 14, 2014
by
Kyle Fuller
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[Lib lint] Fixes a crash when podspec cannot be loaded
Fixes #2147
parent
72760d91
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
23 additions
and
1 deletion
+23
-1
CHANGELOG.md
CHANGELOG.md
+10
-0
lib.rb
lib/cocoapods/command/lib.rb
+4
-1
lib_spec.rb
spec/functional/command/lib_spec.rb
+9
-0
No files found.
CHANGELOG.md
View file @
7dfa9eff
...
@@ -2,6 +2,16 @@
...
@@ -2,6 +2,16 @@
To install or update CocoaPods see this
[
guide
](
http://docs.cocoapods.org/guides/installing_cocoapods.html
)
.
To install or update CocoaPods see this
[
guide
](
http://docs.cocoapods.org/guides/installing_cocoapods.html
)
.
## Master
##### Bug Fixes
*
Fixes an issue where
`pod lib lint`
would crash if a podspec couldn't be
loaded.
[
Kyle Fuller
](
https://github.com/kylef
)
[
#2147
](
https://github.com/CocoaPods/CocoaPods/issues/2147
)
## 0.34.0.rc1
## 0.34.0.rc1
##### Breaking
##### Breaking
...
...
lib/cocoapods/command/lib.rb
View file @
7dfa9eff
...
@@ -150,7 +150,10 @@ module Pod
...
@@ -150,7 +150,10 @@ module Pod
if
validator
.
validated?
if
validator
.
validated?
UI
.
puts
"
#{
validator
.
spec
.
name
}
passed validation."
.
green
UI
.
puts
"
#{
validator
.
spec
.
name
}
passed validation."
.
green
else
else
message
=
"
#{
validator
.
spec
.
name
}
did not pass validation."
spec_name
=
podspec
spec_name
=
validator
.
spec
.
name
if
validator
.
spec
message
=
"
#{
spec_name
}
did not pass validation."
if
@clean
if
@clean
message
<<
"
\n
You can use the `--no-clean` option to inspect "
\
message
<<
"
\n
You can use the `--no-clean` option to inspect "
\
'any issue.'
'any issue.'
...
...
spec/functional/command/lib_spec.rb
View file @
7dfa9eff
...
@@ -108,5 +108,14 @@ module Pod
...
@@ -108,5 +108,14 @@ module Pod
UI
.
output
.
should
.
include
'Pods project available at'
UI
.
output
.
should
.
include
'Pods project available at'
end
end
end
end
it
'fails to lint if the spec is not loaded'
do
Dir
.
chdir
(
temporary_directory
)
do
should
.
raise
Pod
::
Informative
do
run_command
(
'lib'
,
'lint'
,
'404.podspec'
)
end
UI
.
output
.
should
.
include
'could not be loaded'
end
end
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment