Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
C
cocoapods
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
gengmeiios
cocoapods
Commits
898d083a
Commit
898d083a
authored
Feb 14, 2015
by
Samuel E. Giddins
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #3083 from CocoaPods/validate-sim-only
Build for iOS simulator only during validation
parents
8cfec5a6
ffd8dfbd
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
23 additions
and
2 deletions
+23
-2
CHANGELOG.md
CHANGELOG.md
+6
-0
validator.rb
lib/cocoapods/validator.rb
+5
-2
validator_spec.rb
spec/unit/validator_spec.rb
+12
-0
No files found.
CHANGELOG.md
View file @
898d083a
...
...
@@ -8,6 +8,12 @@ To install release candidates run `[sudo] gem install cocoapods --pre`
##### Enhancements
*
Build for iOS simulator only during validation. This allows validation without having
provisioning profiles set up.
[
Boris Bügling
](
https://github.com/neonichu
)
[
#3083
](
https://github.com/CocoaPods/CocoaPods/issues/3083
)
[
Swift#13
](
https://github.com/CocoaPods/swift/issues/13
)
*
Explicitly inform the user to close existing project when switching to
a workspace for the first time.
[
Kyle Fuller
](
https://github.com/kylef
)
...
...
lib/cocoapods/validator.rb
View file @
898d083a
...
...
@@ -519,8 +519,11 @@ module Pod
# returns its output (both STDOUT and STDERR).
#
def
xcodebuild
UI
.
puts
'xcodebuild clean build -target Pods'
if
config
.
verbose?
output
=
`xcodebuild clean build -target Pods 2>&1`
command
=
'xcodebuild clean build -target Pods CODE_SIGN_IDENTITY=-'
command
<<
' -sdk iphonesimulator'
if
consumer
.
platform_name
==
:ios
UI
.
puts
command
if
config
.
verbose?
output
=
`
#{
command
}
2>&1`
unless
$?
.
success?
message
=
'Returned a unsuccessful exit code.'
...
...
spec/unit/validator_spec.rb
View file @
898d083a
...
...
@@ -371,6 +371,18 @@ module Pod
validator
.
result_type
.
should
==
:error
end
it
'runs xcodebuild with correct arguments for code signing'
do
Validator
.
any_instance
.
unstub
(
:xcodebuild
)
validator
=
Validator
.
new
(
podspec_path
,
SourcesManager
.
master
.
map
(
&
:url
))
validator
.
stubs
(
:check_file_patterns
)
validator
.
stubs
(
:validate_url
)
validator
.
expects
(
:`
).
with
(
'which xcodebuild'
).
twice
.
returns
(
'/usr/bin/xcodebuild'
)
command
=
'xcodebuild clean build -target Pods CODE_SIGN_IDENTITY=-'
validator
.
expects
(
:`
).
with
(
"
#{
command
}
2>&1"
).
once
.
returns
(
''
)
validator
.
expects
(
:`
).
with
(
"
#{
command
}
-sdk iphonesimulator 2>&1"
).
once
.
returns
(
''
)
validator
.
validate
end
it
'does filter InputFile errors completely'
do
validator
=
Validator
.
new
(
podspec_path
,
SourcesManager
.
master
.
map
(
&
:url
))
validator
.
stubs
(
:check_file_patterns
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment