Improve fix and improve spec for compiler_flags of subspecs. #364.

lib/cocoapods/specification.rb

@@ -264,16 +264,11 @@ module Pod
 
     def compiler_flags
       if @parent
-        chained = @compiler_flags[active_platform].clone
-        # TODO hack to get the parent's compiler flags without it being
-        # converted to a String by Specification#compiler_flags.
-        chained.unshift @parent.instance_variable_get(:@compiler_flags)[active_platform]
+        flags = [@parent.compiler_flags]
       else
-        chained = @compiler_flags[active_platform].clone
-        chained.unshift '-fobjc-arc' if requires_arc
-        chained.unshift ''
+        flags = [requires_arc ? ' -fobjc-arc' : '']
       end
-      chained.join(' ')
+      (flags + @compiler_flags[active_platform].clone).join(' ')
     end
 
     platform_attr_writer :compiler_flags, lambda {|value, current| current << value }

spec/unit/specification_spec.rb

@@ -321,7 +321,7 @@ describe "A Pod::Specification subspec" do
 
   it "automatically forwards top level attributes to the top level parent" do
     @spec.activate_platform(:ios)
-    [:version, :license, :authors, :requires_arc].each do |attr|
+    [:version, :license, :authors, :requires_arc, :compiler_flags].each do |attr|
       @spec.subspecs.first.send(attr).should == @spec.send(attr)
       @spec.subspecs.first.subspecs.first.send(attr).should == @spec.send(attr)
     end
@@ -332,8 +332,10 @@ describe "A Pod::Specification subspec" do
     @spec.source_files.map { |f| f.to_s }.should == %w[ spec.m  ]
     @subspec.source_files.map { |f| f.to_s }.should == %w[ spec.m  subspec_ios.m ]
     @subsubspec.source_files.map { |f| f.to_s }.should == %w[ spec.m  subspec_ios.m subsubspec.m ]
-
     @subsubspec.resources.should == %w[ resource ]
+
+    @subsubspec.compiler_flags = '-Wdeprecated-implementations'
+    @subsubspec.compiler_flags.should == ' -fobjc-arc -Wdeprecated-implementations'
   end
 
   it "returns empty arrays for chained attributes with no value in the chain" do