[PodTargetInstaller] Set product / module name directly on the target

xcodebuild fails if a framework target has PRODUCT_MODULE_NAME

lib/cocoapods/generator/xcconfig/pod_xcconfig.rb

@@ -55,7 +55,6 @@ module Pod
             'PODS_ROOT' => '${SRCROOT}',
             'PODS_TARGET_SRCROOT' => target.pod_target_srcroot,
             'PRODUCT_BUNDLE_IDENTIFIER' => 'org.cocoapods.${PRODUCT_NAME:rfc1034identifier}',
-            'PRODUCT_MODULE_NAME' => target.product_module_name,
             'SKIP_INSTALL' => 'YES',
             'SWIFT_ACTIVE_COMPILATION_CONDITIONS' => '$(inherited) ',
             'SWIFT_INCLUDE_PATHS' => '$(inherited) ',

lib/cocoapods/installer/xcode/pods_project_generator/pod_target_installer.rb

@@ -91,6 +91,9 @@ module Pod
               settings['PUBLIC_HEADERS_FOLDER_PATH'] = ''
             end
 
+            settings['PRODUCT_NAME'] = target.product_basename
+            settings['PRODUCT_MODULE_NAME'] = target.product_module_name
+
             settings['CODE_SIGN_IDENTITY[sdk=appletvos*]'] = ''
             settings['CODE_SIGN_IDENTITY[sdk=iphoneos*]'] = ''
             settings['CODE_SIGN_IDENTITY[sdk=watchos*]'] = ''

lib/cocoapods/installer/xcode/pods_project_generator/target_installer.rb

@@ -74,9 +74,7 @@ module Pod
           # @return [Hash{String => String}]
           #
           def custom_build_settings
-            settings = {
-              'PRODUCT_NAME' => target.product_module_name,
-            }
+            settings = {}
 
             unless target.archs.empty?
               settings['ARCHS'] = target.archs