Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
C
cocoapods
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
gengmeiios
cocoapods
Commits
abac7393
Commit
abac7393
authored
Mar 14, 2018
by
Dimitris Koutsogiorgas
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix iOS test native target signing settings
parent
e4355d85
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
10 additions
and
1 deletion
+10
-1
CHANGELOG.md
CHANGELOG.md
+4
-0
pod_target_installer.rb
...ller/xcode/pods_project_generator/pod_target_installer.rb
+4
-1
pod_target_installer_spec.rb
...xcode/pods_project_generator/pod_target_installer_spec.rb
+2
-0
No files found.
CHANGELOG.md
View file @
abac7393
...
...
@@ -55,6 +55,10 @@ To install release candidates run `[sudo] gem install cocoapods --pre`
##### Bug Fixes
*
Fix iOS test native target signing settings
[
Dimitris Koutsogiorgas
](
https://github.com/dnkoutso
)
[
#7504
](
https://github.com/CocoaPods/CocoaPods/pull/7504
)
*
Clear input/output paths if they exceed an arbitrary limit
[
Dimitris Koutsogiorgas
](
https://github.com/dnkoutso
)
[
#7362
](
https://github.com/CocoaPods/CocoaPods/issues/7362
)
...
...
lib/cocoapods/installer/xcode/pods_project_generator/pod_target_installer.rb
View file @
abac7393
...
...
@@ -278,7 +278,10 @@ module Pod
# irrelevant to whether we use frameworks or not.
configuration
.
build_settings
[
'PRODUCT_NAME'
]
=
name
# We must codesign iOS XCTest bundles that contain binary frameworks to allow them to be launchable in the simulator
configuration
.
build_settings
[
'CODE_SIGNING_REQUIRED'
]
=
'YES'
unless
target
.
platform
==
:osx
unless
target
.
platform
==
:osx
configuration
.
build_settings
[
'CODE_SIGNING_REQUIRED'
]
=
'YES'
configuration
.
build_settings
[
'CODE_SIGNING_ALLOWED'
]
=
'YES'
end
# For macOS we do not code sign the XCTest bundle because we do not code sign the frameworks either.
configuration
.
build_settings
[
'CODE_SIGN_IDENTITY'
]
=
''
if
target
.
platform
==
:osx
end
...
...
spec/unit/installer/xcode/pods_project_generator/pod_target_installer_spec.rb
View file @
abac7393
...
...
@@ -200,6 +200,7 @@ module Pod
native_test_target
.
build_configurations
.
each
do
|
bc
|
bc
.
build_settings
[
'PRODUCT_NAME'
].
should
==
'CoconutLib-Unit-Tests'
bc
.
build_settings
[
'CODE_SIGNING_REQUIRED'
].
should
==
'YES'
bc
.
build_settings
[
'CODE_SIGNING_ALLOWED'
].
should
==
'YES'
bc
.
build_settings
[
'CODE_SIGN_IDENTITY'
].
should
==
'iPhone Developer'
end
native_test_target
.
symbol_type
.
should
==
:unit_test_bundle
...
...
@@ -216,6 +217,7 @@ module Pod
native_test_target
.
build_configurations
.
each
do
|
bc
|
bc
.
build_settings
[
'PRODUCT_NAME'
].
should
==
'CoconutLib-Unit-Tests'
bc
.
build_settings
[
'CODE_SIGNING_REQUIRED'
].
should
.
be
.
nil
bc
.
build_settings
[
'CODE_SIGNING_ALLOWED'
].
should
.
be
.
nil
bc
.
build_settings
[
'CODE_SIGN_IDENTITY'
].
should
==
''
end
native_test_target
.
symbol_type
.
should
==
:unit_test_bundle
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment