Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
C
cocoapods
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
gengmeiios
cocoapods
Commits
b5813f3b
Commit
b5813f3b
authored
Feb 23, 2016
by
Samuel Giddins
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #4915 from seaders/ibtool-target-device-storyboard-patch
parents
92eae7e2
1857df70
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
23 additions
and
18 deletions
+23
-18
CHANGELOG.md
CHANGELOG.md
+5
-0
copy_resources_script.rb
lib/cocoapods/generator/copy_resources_script.rb
+17
-17
cocoapods-integration-specs
spec/cocoapods-integration-specs
+1
-1
No files found.
CHANGELOG.md
View file @
b5813f3b
...
...
@@ -29,6 +29,11 @@ To install release candidates run `[sudo] gem install cocoapods --pre`
[
Marius Rackwitz
](
https://github.com/mrackwitz
)
[
#4146
](
https://github.com/CocoaPods/CocoaPods/pull/4146
)
*
Pass target device arguments to
`ibtool`
in the copy resources script, fixing
compilation of storyboards when targeting versions of iOS prior to iOS 8.
[
seaders
](
https://github.com/seaders
)
[
#4913
](
https://github.com/CocoaPods/CocoaPods/issues/4913
)
## 1.0.0.beta.3 (2016-02-03)
##### Breaking
...
...
lib/cocoapods/generator/copy_resources_script.rb
View file @
b5813f3b
...
...
@@ -106,6 +106,21 @@ RESOURCES_TO_COPY=${PODS_ROOT}/resources-to-copy-${TARGETNAME}.txt
XCASSET_FILES=()
case "${TARGETED_DEVICE_FAMILY}" in
1,2)
TARGET_DEVICE_ARGS="--target-device ipad --target-device iphone"
;;
1)
TARGET_DEVICE_ARGS="--target-device iphone"
;;
2)
TARGET_DEVICE_ARGS="--target-device ipad"
;;
*)
TARGET_DEVICE_ARGS="--target-device mac"
;;
esac
realpath() {
DIRECTORY="$(cd "${1%/*}" && pwd)"
FILENAME="${1##*/}"
...
...
@@ -127,8 +142,8 @@ EOM
fi
case $RESOURCE_PATH in
*
\.
storyboard)
echo "ibtool --reference-external-strings-file --errors --warnings --notices --minimum-deployment-target ${!DEPLOYMENT_TARGET_SETTING_NAME} --output-format human-readable-text --compile ${CONFIGURATION_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/`basename
\\
"$RESOURCE_PATH
\\
" .storyboard`.storyboardc $RESOURCE_PATH --sdk ${SDKROOT}"
ibtool --reference-external-strings-file --errors --warnings --notices --minimum-deployment-target ${!DEPLOYMENT_TARGET_SETTING_NAME} --output-format human-readable-text --compile "${CONFIGURATION_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/`basename
\\
"$RESOURCE_PATH
\\
" .storyboard`.storyboardc" "$RESOURCE_PATH" --sdk "${SDKROOT}"
echo "ibtool --reference-external-strings-file --errors --warnings --notices --minimum-deployment-target ${!DEPLOYMENT_TARGET_SETTING_NAME} --output-format human-readable-text --compile ${CONFIGURATION_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/`basename
\\
"$RESOURCE_PATH
\\
" .storyboard`.storyboardc $RESOURCE_PATH --sdk ${SDKROOT}
${TARGET_DEVICE_ARGS}
"
ibtool --reference-external-strings-file --errors --warnings --notices --minimum-deployment-target ${!DEPLOYMENT_TARGET_SETTING_NAME} --output-format human-readable-text --compile "${CONFIGURATION_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/`basename
\\
"$RESOURCE_PATH
\\
" .storyboard`.storyboardc" "$RESOURCE_PATH" --sdk "${SDKROOT}
${TARGET_DEVICE_ARGS}
"
;;
*
\.
xib)
echo "ibtool --reference-external-strings-file --errors --warnings --notices --minimum-deployment-target ${!DEPLOYMENT_TARGET_SETTING_NAME} --output-format human-readable-text --compile ${CONFIGURATION_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/`basename
\\
"$RESOURCE_PATH
\\
" .xib`.nib $RESOURCE_PATH --sdk ${SDKROOT}"
...
...
@@ -179,21 +194,6 @@ EOS
if [[ -n "${WRAPPER_EXTENSION}" ]] && [ "`xcrun --find actool`" ] && [ -n "$XCASSET_FILES" ]
then
case "${TARGETED_DEVICE_FAMILY}" in
1,2)
TARGET_DEVICE_ARGS="--target-device ipad --target-device iphone"
;;
1)
TARGET_DEVICE_ARGS="--target-device iphone"
;;
2)
TARGET_DEVICE_ARGS="--target-device ipad"
;;
*)
TARGET_DEVICE_ARGS="--target-device mac"
;;
esac
# Find all other xcassets (this unfortunately includes those of path pods and other targets).
OTHER_XCASSETS=$(find "$PWD" -iname "*.xcassets" -type d)
while read line; do
...
...
cocoapods-integration-specs
@
3edf4131
Subproject commit
1adc26822f4509232f6953e421d592753ac98c19
Subproject commit
3edf4131d999b88df50e86faad014b8afcef1c40
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment