Merge pull request #5167 from CocoaPods/orta-danger

Introduce a danger file to check for `fit` and `fdescribe` in tests

.rubocop.yml

@@ -8,6 +8,8 @@ ParameterLists:
   CountKeywordArgs: false
 
 AllCops:
+  Include:
+    - Dangerfile
   Exclude:
     - spec/fixtures/**/*.rb
     - spec/fixtures/banana-lib/libPusher/Scripts/pusher
@@ -16,3 +18,7 @@ Style/FileName:
   Exclude:
     - bin/*
     - Rakefile
+
+Style/SignalException:
+  Exclude:
+    - Dangerfile

.travis.yml

@@ -26,7 +26,9 @@ after_install:
 before_script:
   - bundle exec pod repo update --silent
 
-script: bundle exec rake
+script:
+  - bundle exec rake
+  - bundle exec danger
 
 addons:
  code_climate:

Dangerfile

+# Don't let testing shortcuts get into master by accident
+
+(modified_files + added_files - %w(Dangerfile)).each do |file|
+  contents = File.read(file)
+  fail("`fit` left in tests (#{file})") if contents =~ /fit/
+  fail("`fdescribe` left in tests (#{file})") if contents =~ /fdescribe/
+end

Gemfile

@@ -48,6 +48,8 @@ group :development do
   # Code Quality
   gem 'inch_by_inch'
   gem 'rubocop'
+
+  gem 'danger'
 end
 
 group :debugging do

Gemfile.lock

@@ -136,11 +136,22 @@ GEM
     colored (1.2)
     crack (0.4.2)
       safe_yaml (~> 1.0.0)
+    danger (0.7.2)
+      claide
+      colored (~> 1.2)
+      faraday
+      git
+      octokit (~> 4.2)
+      redcarpet (~> 3.3)
+      terminal-table (~> 1)
     diffy (3.1.0)
     escape (0.0.4)
+    faraday (0.9.2)
+      multipart-post (>= 1.2, < 3)
     ffi (1.9.6)
     fourflusher (0.3.0)
     fuzzy_match (2.0.4)
+    git (1.3.0)
     i18n (0.7.0)
     inch (0.7.0)
       pry
@@ -164,9 +175,12 @@ GEM
       metaclass (~> 0.0.1)
     mocha-on-bacon (0.2.2)
       mocha (>= 0.13.0)
+    multipart-post (2.0.0)
     nap (1.1.0)
     netrc (0.7.8)
     notify (0.5.2)
+    octokit (4.3.0)
+      sawyer (~> 0.7.0, >= 0.5.3)
     parser (2.3.0.6)
       ast (~> 2.2)
     powerpack (0.1.1)
@@ -183,6 +197,7 @@ GEM
       ffi (>= 0.5.0)
     rb-kqueue (0.2.3)
       ffi (>= 0.5.0)
+    redcarpet (3.3.4)
     rubocop (0.37.2)
       parser (>= 2.3.0.4, < 3.0)
       powerpack (~> 0.1)
@@ -193,10 +208,14 @@ GEM
     ruby-prof (0.15.2)
     ruby-progressbar (1.7.5)
     safe_yaml (1.0.4)
+    sawyer (0.7.0)
+      addressable (>= 2.3.5, < 2.5)
+      faraday (~> 0.8, < 0.10)
     slop (3.6.0)
     sparkr (0.4.1)
     term-ansicolor (1.3.2)
       tins (~> 1.0)
+    terminal-table (1.5.2)
     thread_safe (0.3.5)
     tins (1.8.1)
     tzinfo (1.2.2)
@@ -227,6 +246,7 @@ DEPENDENCIES
   cocoapods-trunk!
   cocoapods-try!
   cocoapods_debug
+  danger
   diffy
   inch_by_inch
   json!