Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
C
cocoapods
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
gengmeiios
cocoapods
Commits
c229f47f
Commit
c229f47f
authored
Mar 19, 2013
by
Fabio Pelosin
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[UserProjectIntegrator] Always return a Pathname in #workspace_path.
Closes #871
parent
03ab8617
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
9 additions
and
8 deletions
+9
-8
CHANGELOG.md
CHANGELOG.md
+2
-0
user_project_integrator.rb
lib/cocoapods/installer/user_project_integrator.rb
+3
-4
user_project_integrator_spec.rb
spec/unit/installer/user_project_integrator_spec.rb
+4
-4
No files found.
CHANGELOG.md
View file @
c229f47f
...
@@ -8,6 +8,8 @@
...
@@ -8,6 +8,8 @@
-
CocoaPods updates the repositories by default.
-
CocoaPods updates the repositories by default.
[
#872
](
https://github.com/CocoaPods/CocoaPods/issues/872
)
[
#872
](
https://github.com/CocoaPods/CocoaPods/issues/872
)
-
Fixed a crash which was present when the Podfile specifies a workspace.
[
#871
](
https://github.com/CocoaPods/CocoaPods/issues/871
)
###### Ancillary enhancements
###### Ancillary enhancements
...
...
lib/cocoapods/installer/user_project_integrator.rb
View file @
c229f47f
...
@@ -132,18 +132,17 @@ module Pod
...
@@ -132,18 +132,17 @@ module Pod
end
end
end
end
#-----------------------------------------------------------------------#
private
private
# @!group Helpers.
# @!group Private Helpers
#-----------------------------------------------------------------------#
# @return [Pathname] the path where the workspace containing the Pods
# @return [Pathname] the path where the workspace containing the Pods
# project and the user projects should be saved.
# project and the user projects should be saved.
#
#
def
workspace_path
def
workspace_path
if
podfile
.
workspace_path
if
podfile
.
workspace_path
podfile
.
workspace_path
Pathname
.
new
(
podfile
.
workspace_path
)
elsif
user_project_paths
.
count
==
1
elsif
user_project_paths
.
count
==
1
project
=
user_project_paths
.
first
.
basename
(
'.xcodeproj'
)
project
=
user_project_paths
.
first
.
basename
(
'.xcodeproj'
)
installation_root
+
"
#{
project
}
.xcworkspace"
installation_root
+
"
#{
project
}
.xcworkspace"
...
...
spec/unit/installer/user_project_integrator_spec.rb
View file @
c229f47f
...
@@ -122,12 +122,12 @@ module Pod
...
@@ -122,12 +122,12 @@ module Pod
#-----------------------------------------------------------------------#
#-----------------------------------------------------------------------#
describe
"Helpers"
do
describe
"
Private
Helpers"
do
it
"uses the path of the workspace defined in the podfile"
do
it
"uses the path of the workspace defined in the podfile"
do
path
=
"a_path"
path
=
Pathname
.
new
(
"a_path"
)
@podfile
.
workspace
(
path
)
@podfile
.
workspace
(
path
.
to_s
)
@integrator
.
send
(
:workspace_path
).
should
==
path
+
".xcworkspace"
@integrator
.
send
(
:workspace_path
).
should
==
path
.
sub_ext
(
".xcworkspace"
)
end
end
it
"names the workspace after the user project if needed"
do
it
"names the workspace after the user project if needed"
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment