Merge pull request #3412 from CocoaPods/mr-lint-fail-fast

[Linter] Allow to fail-fast

lib/cocoapods/command/lib.rb

@@ -113,6 +113,7 @@ module Pod
            ['--subspec=NAME', 'Lint validates only the given subspec'],
            ['--no-subspecs', 'Lint skips validation of subspecs'],
            ['--no-clean', 'Lint leaves the build directory intact for inspection'],
+           ['--fail-fast', 'Lint stops on the first failing platform or subspec'],
            ['--use-libraries', 'Lint uses static libraries to install the spec'],
            ['--sources=https://github.com/artsy/Specs,master', 'The sources from which to pull dependant pods ' \
             '(defaults to https://github.com/CocoaPods/Specs.git). '\
@@ -123,6 +124,7 @@ module Pod
           @quick           = argv.flag?('quick')
           @allow_warnings  = argv.flag?('allow-warnings')
           @clean           = argv.flag?('clean', true)
+          @fail_fast       = argv.flag?('fail-fast', false)
           @subspecs        = argv.flag?('subspecs', true)
           @only_subspec    = argv.option('subspec')
           @use_frameworks  = !argv.flag?('use-libraries')
@@ -142,6 +144,7 @@ module Pod
             validator.local          = true
             validator.quick          = @quick
             validator.no_clean       = !@clean
+            validator.fail_fast      = @fail_fast
             validator.allow_warnings = @allow_warnings
             validator.no_subspecs    = !@subspecs || @only_subspec
             validator.only_subspec   = @only_subspec

lib/cocoapods/command/spec/lint.rb

@@ -20,6 +20,7 @@ module Pod
            ['--subspec=NAME', 'Lint validates only the given subspec'],
            ['--no-subspecs', 'Lint skips validation of subspecs'],
            ['--no-clean', 'Lint leaves the build directory intact for inspection'],
+           ['--fail-fast', 'Lint stops on the first failing platform or subspec'],
            ['--use-libraries', 'Lint uses static libraries to install the spec'],
            ['--sources=https://github.com/artsy/Specs,master', 'The sources from which to pull dependant pods ' \
             '(defaults to https://github.com/CocoaPods/Specs.git). '\
@@ -30,6 +31,7 @@ module Pod
           @quick           = argv.flag?('quick')
           @allow_warnings  = argv.flag?('allow-warnings')
           @clean           = argv.flag?('clean', true)
+          @fail_fast       = argv.flag?('fail-fast', false)
           @subspecs        = argv.flag?('subspecs', true)
           @only_subspec    = argv.option('subspec')
           @use_frameworks  = !argv.flag?('use-libraries')
@@ -45,6 +47,7 @@ module Pod
             validator                = Validator.new(podspec, @source_urls)
             validator.quick          = @quick
             validator.no_clean       = !@clean
+            validator.fail_fast      = @fail_fast
             validator.allow_warnings = @allow_warnings
             validator.no_subspecs    = !@subspecs || @only_subspec
             validator.only_subspec   = @only_subspec

lib/cocoapods/validator.rb

@@ -123,6 +123,12 @@ module Pod
     #
     attr_accessor :no_clean
 
+    # @return [Bool] whether the linter should fail as soon as the first build
+    #         variant causes an error. Helpful for i.e. multi-platforms specs,
+    #         specs with subspecs.
+    #
+    attr_accessor :fail_fast
+
     # @return [Bool] whether the validation should be performed against the root of
     #         the podspec instead to its original source.
     #
@@ -208,7 +214,7 @@ module Pod
       validate_documentation_url(spec)
       validate_docset_url(spec)
 
-      spec.available_platforms.each do |platform|
+      valid = spec.available_platforms.send(fail_fast ? :all? : :each) do |platform|
         UI.message "\n\n#{spec} - Analyzing on #{platform} platform.".green.reversed
         @consumer = spec.consumer(platform)
         setup_validation_environment
@@ -217,14 +223,16 @@ module Pod
         build_pod
         check_file_patterns
         tear_down_validation_environment
+        validated?
       end
+      return false if fail_fast && !valid
       perform_extensive_subspec_analysis(spec) unless @no_subspecs
     end
 
     # Recursively perform the extensive analysis on all subspecs
     #
     def perform_extensive_subspec_analysis(spec)
-      spec.subspecs.each do |subspec|
+      spec.subspecs.send(fail_fast ? :all? : :each) do |subspec|
         @subspec_name = subspec.name
         perform_extensive_analysis(subspec)
       end

spec/unit/validator_spec.rb

@@ -273,6 +273,17 @@ module Pod
         validator.validate
       end
 
+      it 'builds the pod only once if the first fails with fail_fast' do
+        Validator.any_instance.unstub(:xcodebuild)
+        validator = Validator.new(podspec_path, SourcesManager.master.map(&:url))
+        validator.stubs(:check_file_patterns)
+        validator.stubs(:validate_url)
+        validator.fail_fast = true
+        validator.expects(:xcodebuild).once.returns('file.m:1:1: error: Pretended!')
+        validator.validate
+        validator.result_type.should == :error
+      end
+
       it 'uses the deployment target of the specification' do
         validator = Validator.new(podspec_path, SourcesManager.master.map(&:url))
         validator.stubs(:validate_url)
@@ -284,6 +295,7 @@ module Pod
 
       it 'uses the deployment target of the current subspec' do
         validator = Validator.new(podspec_path, SourcesManager.master.map(&:url))
+        validator.instance_variable_set(:@results, [])
         validator.stubs(:validate_url)
         validator.stubs(:validate_screenshots)
         validator.stubs(:check_file_patterns)
@@ -365,7 +377,7 @@ module Pod
         validator = Validator.new(podspec_path, SourcesManager.master.map(&:url))
         validator.stubs(:check_file_patterns)
         validator.stubs(:validate_url)
-        validator.stubs(:`).returns('Output')
+        validator.expects(:`).with('which xcodebuild').twice.returns('/usr/bin/xcodebuild')
         status = mock
         status.stubs(:success?).returns(false)
         validator.stubs(:_xcodebuild).returns(['Output', status])
@@ -487,6 +499,7 @@ module Pod
       end
 
       def setup_validator
+        @validator.instance_variable_set(:@results, [])
         @validator.stubs(:validate_url)
         @validator.stubs(:validate_screenshots)
         @validator.stubs(:check_file_patterns)