[Subversion] Improved head support.

lib/cocoapods/downloader/subversion.rb

@@ -4,25 +4,26 @@ module Pod
       executable :svn
 
       def download
-        if options[:revision]
-          download_revision
-        elsif options[:tag]
-          download_tag
-        else
-          download_head
-        end
+        svn %|checkout "#{reference_url}" "#{target_path}"|
       end
 
       def download_head
-        svn %|checkout "#{url}/#{options[:folder]}" "#{target_path}"|
+        svn %|checkout "#{trunk_url}" "#{target_path}"|
       end
 
-      def download_revision
-        svn %|checkout "#{url}/#{options[:folder]}" -r "#{options[:revision]}" "#{target_path}"|
+      def reference_url
+        result = url.dup
+        result << '/'       << options[:folder] if options[:folder]
+        result << '/tags/'  << options[:tag] if options[:tag]
+        result << '" -r "'  << options[:revision] if options[:revision]
+        result
       end
 
-      def download_tag
-        svn %|checkout "#{url}/tags/#{options[:tag]}/#{options[:folder]}" "#{target_path}"|
+      def trunk_url
+        result = url.dup
+        result << '/' << options[:folder] if options[:folder]
+        result << '/trunk'
+        result
       end
     end
   end

spec/functional/downloader_spec.rb

@@ -253,6 +253,7 @@ module Pod
     end
 
     describe "for Subversion" do
+
       it "check's out a specific revision" do
         @pod.top_specification.stubs(:source).returns(
           :svn => "file://#{fixture('subversion-repo')}", :revision => '1'
@@ -270,8 +271,18 @@ module Pod
         downloader.download
         (@pod.root + 'README').read.strip.should == 'tag 1'
       end
+
+      it "check's out the head version" do
+        @pod.top_specification.stubs(:source).returns(
+          :svn => "file://#{fixture('subversion-repo')}", :revision => '1'
+        )
+        downloader = Downloader.for_pod(@pod)
+        downloader.download_head
+        (@pod.root + 'README').read.strip.should == 'unintersting'
+      end
     end
 
+
     describe "for HTTP" do
       extend SpecHelper::TemporaryDirectory