[PodXCConfig] Always set PRODUCT_MODULE_NAME

lib/cocoapods/generator/xcconfig/pod_xcconfig.rb

@@ -53,6 +53,7 @@ module Pod
             'PODS_ROOT' => '${SRCROOT}',
             'PODS_TARGET_SRCROOT' => target.pod_target_srcroot,
             'PRODUCT_BUNDLE_IDENTIFIER' => 'org.cocoapods.${PRODUCT_NAME:rfc1034identifier}',
+            'PRODUCT_MODULE_NAME' => target.product_module_name,
             'SKIP_INSTALL' => 'YES',
             'SWIFT_ACTIVE_COMPILATION_CONDITIONS' => '$(inherited) ',
             'SWIFT_INCLUDE_PATHS' => '$(inherited) ${LIBRARY_SEARCH_PATHS}',

lib/cocoapods/installer/xcode/pods_project_generator/target_installer.rb

@@ -82,15 +82,11 @@ module Pod
 
             if target.requires_frameworks?
               framework_name = target.product_module_name
-              settings['PRODUCT_NAME'] = framework_name
               if target.static_framework?
                 settings['PUBLIC_HEADERS_FOLDER_PATH'] = framework_name + '.framework' + '/Headers'
                 settings['PRIVATE_HEADERS_FOLDER_PATH'] = framework_name + '.framework' + '/PrivateHeaders'
               end
             else
-              # if target.uses_swift?
-              #   settings['PRODUCT_NAME'] = target.product_module_name
-              # end
               settings.merge!('OTHER_LDFLAGS' => '', 'OTHER_LIBTOOLFLAGS' => '')
             end