Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
C
cocoapods
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
gengmeiios
cocoapods
Commits
da544fa9
Commit
da544fa9
authored
Jan 05, 2015
by
Samuel E. Giddins
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[RuboCop] Enable Style/CommentAnnotation
parent
afe424ff
Hide whitespace changes
Inline
Side-by-side
Showing
9 changed files
with
9 additions
and
15 deletions
+9
-15
.rubocop_todo.yml
.rubocop_todo.yml
+0
-5
.travis.yml
.travis.yml
+1
-1
Rakefile
Rakefile
+1
-1
sandbox-pod
bin/sandbox-pod
+1
-1
cocoapods.rb
lib/cocoapods.rb
+1
-1
aggregate_xcconfig.rb
lib/cocoapods/generator/xcconfig/aggregate_xcconfig.rb
+1
-1
installer.rb
lib/cocoapods/installer.rb
+2
-3
analyzer.rb
lib/cocoapods/installer/analyzer.rb
+1
-1
spec_spec.rb
spec/functional/command/spec_spec.rb
+1
-1
No files found.
.rubocop_todo.yml
View file @
da544fa9
...
...
@@ -22,11 +22,6 @@ Metrics/LineLength:
Metrics/PerceivedComplexity
:
Max
:
10
# Offense count: 7
# Configuration parameters: Keywords.
Style/CommentAnnotation
:
Enabled
:
false
# Offense count: 6
# Configuration parameters: AllowedVariables.
Style/GlobalVars
:
...
...
.travis.yml
View file @
da544fa9
...
...
@@ -8,7 +8,7 @@ rvm:
# OS X 10.9.3-10.9.4
-
2.0.0-p451
# OS X 10.9.0-10.9.2
# TODO currently unavailable: https://github.com/travis-ci/travis-ci/issues/2918
# TODO
:
currently unavailable: https://github.com/travis-ci/travis-ci/issues/2918
# - 2.0.0-p247
before_install
:
...
...
Rakefile
View file @
da544fa9
...
...
@@ -213,7 +213,7 @@ begin
task
:recreate_workspace_schemes
do
examples
.
each
do
|
example
|
Dir
.
chdir
(
example
.
to_s
)
do
# TODO we need to open the workspace in Xcode at least once, otherwise it might not contain schemes.
# TODO
:
we need to open the workspace in Xcode at least once, otherwise it might not contain schemes.
# The schemes do not seem to survive a SCM round-trip.
sh
"open '
#{
example
.
basename
}
.xcworkspace'"
sleep
5
...
...
bin/sandbox-pod
View file @
da544fa9
...
...
@@ -153,7 +153,7 @@ class Profile
File
.
expand_path
(
'../..'
,
developer_prefix
)
end
# TODO raise SAFE level (0) to 4 if possible.
# TODO
:
raise SAFE level (0) to 4 if possible.
def
generate
ERB
.
new
(
PROFILE_ERB_TEMPLATE
,
0
,
'>'
).
result
(
binding
)
end
...
...
lib/cocoapods.rb
View file @
da544fa9
...
...
@@ -7,7 +7,7 @@ require 'xcodeproj'
require
'active_support/core_ext/string/strip'
require
'active_support/core_ext/string/inflections'
require
'active_support/core_ext/array/conversions'
# TODO check what this actually does by the time we're going to add support for
# TODO
:
check what this actually does by the time we're going to add support for
# other locales.
require
'i18n'
if
I18n
.
respond_to?
(
:enforce_available_locales
=
)
...
...
lib/cocoapods/generator/xcconfig/aggregate_xcconfig.rb
View file @
da544fa9
...
...
@@ -101,7 +101,7 @@ module Pod
end
end
# TODO Need to decide how we are going to ensure settings like these
# TODO
:
Need to decide how we are going to ensure settings like these
# are always excluded from the user's project.
#
# See https://github.com/CocoaPods/CocoaPods/issues/1216
...
...
lib/cocoapods/installer.rb
View file @
da544fa9
...
...
@@ -446,8 +446,7 @@ module Pod
target_installer
.
install!
end
# TODO
# Move and add specs
# TODO: Move and add specs
pod_targets
.
sort_by
(
&
:name
).
each
do
|
pod_target
|
pod_target
.
file_accessors
.
each
do
|
file_accessor
|
file_accessor
.
spec_consumer
.
frameworks
.
each
do
|
framework
|
...
...
@@ -481,7 +480,7 @@ module Pod
pod_target
.
dependencies
.
each
do
|
dep
|
unless
dep
==
pod_target
.
pod_name
pod_dependency_target
=
aggregate_target
.
pod_targets
.
find
{
|
target
|
target
.
pod_name
==
dep
}
# TODO remove me
# TODO
:
remove me
unless
pod_dependency_target
puts
"[BUG] DEP:
#{
dep
}
"
end
...
...
lib/cocoapods/installer/analyzer.rb
View file @
da544fa9
...
...
@@ -306,7 +306,7 @@ module Pod
#
# @return [void]
#
# TODO Specs
# TODO
:
Specs
#
def
fetch_external_sources
return
unless
allow_pre_downloads?
...
...
spec/functional/command/spec_spec.rb
View file @
da544fa9
...
...
@@ -352,7 +352,7 @@ module Pod
describe
'Private helpers'
do
before
do
# TODO Use class methods
# TODO
:
Use class methods
@command
=
Command
::
Spec
.
new
(
CLAide
::
ARGV
.
new
([]))
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment