Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
C
cocoapods
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
gengmeiios
cocoapods
Commits
edd3b916
Commit
edd3b916
authored
Apr 16, 2018
by
Dimitris Koutsogiorgas
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove unused #specific_source attribute
parent
1c6dedd1
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
10 deletions
+2
-10
pod_source_installer.rb
lib/cocoapods/installer/pod_source_installer.rb
+2
-8
pod_source_installer_spec.rb
spec/unit/installer/pod_source_installer_spec.rb
+0
-2
No files found.
lib/cocoapods/installer/pod_source_installer.rb
View file @
edd3b916
...
...
@@ -91,19 +91,13 @@ module Pod
end
end
# @return [Hash] @see Downloader#checkout_options
#
attr_reader
:specific_source
#-----------------------------------------------------------------------#
private
# @!group Installation Steps
# Downloads the source of the Pod. It also stores the specific options
# needed to recreate the same exact installation if needed in
# `#specific_source`.
# Downloads the source of the Pod.
#
# @return [void]
#
...
...
@@ -111,7 +105,7 @@ module Pod
verify_source_is_secure
(
root_spec
)
download_result
=
Downloader
.
download
(
download_request
,
root
,
:can_cache
=>
can_cache?
)
if
(
@
specific_source
=
download_result
.
checkout_options
)
&&
specific_source
!=
root_spec
.
source
if
(
specific_source
=
download_result
.
checkout_options
)
&&
specific_source
!=
root_spec
.
source
sandbox
.
store_checkout_source
(
root_spec
.
name
,
specific_source
)
end
end
...
...
spec/unit/installer/pod_source_installer_spec.rb
View file @
edd3b916
...
...
@@ -18,7 +18,6 @@ module Pod
it
'downloads the source'
do
@spec
.
source
=
{
:git
=>
SpecHelper
.
fixture
(
'banana-lib'
),
:tag
=>
'v1.0'
}
@installer
.
install!
@installer
.
specific_source
[
:tag
].
should
==
'v1.0'
pod_folder
=
config
.
sandbox
.
pod_dir
(
'BananaLib'
)
pod_folder
.
should
.
exist
end
...
...
@@ -26,7 +25,6 @@ module Pod
it
'returns the checkout options of the downloader if any'
do
@spec
.
source
=
{
:git
=>
SpecHelper
.
fixture
(
'banana-lib'
),
:branch
=>
'topicbranch'
}
@installer
.
install!
@installer
.
specific_source
[
:commit
].
should
==
'446b22414597f1bb4062a62c4eed7af9627a3f1b'
pod_folder
=
config
.
sandbox
.
pod_dir
(
'BananaLib'
)
pod_folder
.
should
.
exist
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment