Address code review comments

lib/cocoapods/command/outdated.rb

@@ -91,7 +91,7 @@ module Pod
       def spec_sets
         @spec_sets ||= begin
           analyzer.send(:update_repositories) unless config.skip_repo_update?
-          aggregate = Source::Aggregate.new(analyzer.sources.map)
+          aggregate = Source::Aggregate.new(analyzer.sources)
           installed_pods.map do |pod_name|
             aggregate.search(Dependency.new(pod_name))
           end.compact.uniq

lib/cocoapods/sources_manager.rb

@@ -475,7 +475,7 @@ module Pod
       #
       def source_from_path(path)
         return Source.new(path) unless path.basename.to_s == 'master'
-        return MasterSource.new(path)
+        MasterSource.new(path)
       end
 
       # @return [Source::Aggregate] The aggregate of the sources from repos.

spec/unit/sources_manager_spec.rb

@@ -296,15 +296,18 @@ module Pod
     describe 'Updating Sources' do
       extend SpecHelper::TemporaryRepos
       
+      before do
+        WebMock::API.stub_request(:get, "https://api.github.com/repos/cocoapods/specs/commits/master")
+          .with(:headers => {'Accept'=>'application/vnd.github.chitauri-preview+sha'})
+          .to_return(:status => 200, :body => '', :headers => {})
+      end
+
       after do
         WebMock.reset!
       end
 
       it 'updates source backed by a git repository' do
         set_up_test_repo_for_update
-        WebMock::API.stub_request(:get, "https://api.github.com/repos/cocoapods/specs/commits/master")
-                  .with(:headers => {'Accept'=>'application/vnd.github.chitauri-preview+sha'})
-                  .to_return(:status => 200, :body => '', :headers => {})
         SourcesManager.expects(:update_search_index_if_needed_in_background).with({}).returns(nil)
         SourcesManager.update(test_repo_path.basename.to_s, true)
         UI.output.should.match /is up to date/
@@ -312,20 +315,12 @@ module Pod
 
       it 'uses the only fast forward git option' do
         set_up_test_repo_for_update
-
-        WebMock::API.stub_request(:get, "https://api.github.com/repos/cocoapods/specs/commits/master")
-                  .with(:headers => {'Accept'=>'application/vnd.github.chitauri-preview+sha'})
-                  .to_return(:status => 200, :body => '', :headers => {})
-
         Source.any_instance.expects(:git!).with { |options| options.should.include? '--ff-only' }
         SourcesManager.expects(:update_search_index_if_needed_in_background).with({}).returns(nil)
         SourcesManager.update(test_repo_path.basename.to_s, true)
       end
 
       it 'prints a warning if the update failed' do
-        WebMock::API.stub_request(:get, "https://api.github.com/repos/cocoapods/specs/commits/master")
-                  .with(:headers => {'Accept'=>'application/vnd.github.chitauri-preview+sha'})
-                  .to_return(:status => 200, :body => '', :headers => {})
         UI.warnings = ''
         set_up_test_repo_for_update
         Dir.chdir(test_repo_path) do