[FileAccessor] Partition dynamic and static vendored artifacts

lib/cocoapods/generator/xcconfig/aggregate_xcconfig.rb

@@ -53,7 +53,7 @@ module Pod
         #
         def generate
           includes_static_libs = !target.requires_frameworks?
-          includes_static_libs ||= pod_targets.flat_map(&:file_accessors).any? { |fa| !fa.vendored_libraries.empty? }
+          includes_static_libs ||= pod_targets.flat_map(&:file_accessors).any? { |fa| !fa.vendored_static_libraries.empty? || !fa.vendored_static_frameworks.empty? }
           config = {
             'OTHER_LDFLAGS' => '$(inherited) ' + XCConfigHelper.default_ld_flags(target, includes_static_libs),
             'PODS_ROOT' => target.relative_pods_root,

lib/cocoapods/installer.rb

@@ -418,8 +418,7 @@ module Pod
           dependended_upon_targets = pod_targets.select { |t| dependencies.include?(t.pod_name) && !t.should_build? }
 
           static_libs = dependended_upon_targets.flat_map(&:file_accessors).flat_map do |fa|
-            static_frameworks = fa.vendored_frameworks.reject { |fw| `file #{fw + fw.basename('.framework')} 2>&1` =~ /dynamically linked/ }
-            fa.vendored_libraries + static_frameworks
+            fa.vendored_static_libraries + fa.vendored_static_frameworks
           end
 
           unless static_libs.empty?

lib/cocoapods/sandbox/file_accessor.rb

@@ -152,6 +152,16 @@ module Pod
         paths_for_attribute(:vendored_frameworks, true)
       end
 
+      def vendored_dynamic_frameworks
+        vendored_frameworks.select do |framework|
+          dynamic_binary?(framework + framework.basename('.*'))
+        end
+      end
+
+      def vendored_static_frameworks
+        vendored_frameworks - vendored_dynamic_frameworks
+      end
+
       # @param  [Pathname] framework
       #         The vendored framework to search into.
       # @return [Pathname] The path of the header directory of the
@@ -187,6 +197,16 @@ module Pod
         paths_for_attribute(:vendored_libraries)
       end
 
+      def vendored_dynamic_libraries
+        vendored_libraries.select do |library|
+          dynamic_binary?(library)
+        end
+      end
+
+      def vendored_static_libraries
+        vendored_libraries - vendored_dynamic_libraries
+      end
+
       # @return [Hash{String => Array<Pathname>}] A hash that describes the
       #         resource bundles of the Pod. The keys represent the name of
       #         the bundle while the values the path of the resources.
@@ -315,6 +335,11 @@ module Pod
         result.flatten.compact.uniq
       end
 
+      def dynamic_binary?(binary)
+        return unless binary.file?
+        Executable.execute_command('file', [binary], false) =~ /dynamically linked/
+      end
+
       #-----------------------------------------------------------------------#
     end
   end

lib/cocoapods/validator.rb

@@ -382,8 +382,8 @@ module Pod
       deployment_target = spec.subspec_by_name(subspec_name).deployment_target(consumer.platform_name)
 
       unless file_accessor.nil?
-        dynamic_frameworks = file_accessor.vendored_frameworks.select { |fw| `file #{fw + fw.basename('.framework')} 2>&1` =~ /dynamically linked/ }
-        dynamic_libraries = file_accessor.vendored_libraries.select { |lib| `file #{lib} 2>&1` =~ /dynamically linked/ }
+        dynamic_frameworks = file_accessor.vendored_dynamic_frameworks
+        dynamic_libraries = file_accessor.vendored_dynamic_libraries
         if (dynamic_frameworks.count > 0 || dynamic_libraries.count > 0) && consumer.platform_name == :ios &&
             (deployment_target.nil? || Version.new(deployment_target).major < 8)
           error('dynamic', 'Dynamic frameworks and libraries are only supported on iOS 8.0 and onwards.')