Merge pull request #63 from jumpserver/dev

Dev

Dockerfile

@@ -4,8 +4,8 @@ WORKDIR /opt/coco
 ARG GOPROXY
 ENV GOPROXY=$GOPROXY
 ENV GO111MODULE=on
-COPY go.mod go.sum ./
 RUN apk update && apk add git
+COPY go.mod go.sum ./
 RUN go mod download
 COPY . .
 RUN cd cmd && go build koko.go

go.mod

@@ -6,7 +6,7 @@ require (
 	github.com/Azure/azure-pipeline-go v0.1.9 // indirect
 	github.com/Azure/azure-storage-blob-go v0.6.0
 	github.com/BurntSushi/toml v0.3.1 // indirect
-	github.com/LeeEirc/elfinder v0.0.0-20190718023636-5679c8bdb7bf
+	github.com/LeeEirc/elfinder v0.0.1
 	github.com/aliyun/aliyun-oss-go-sdk v1.9.8
 	github.com/anmitsu/go-shlex v0.0.0-20161002113705-648efa622239 // indirect
 	github.com/aws/aws-sdk-go v1.19.46

go.sum

@@ -7,6 +7,8 @@ github.com/BurntSushi/toml v0.3.1 h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ
 github.com/BurntSushi/toml v0.3.1/go.mod h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03qcyfWMU=
 github.com/LeeEirc/elfinder v0.0.0-20190718023636-5679c8bdb7bf h1:dZipr1cwienSKNTXsveMmyd7VFY3v/eMHNl/vueN10s=
 github.com/LeeEirc/elfinder v0.0.0-20190718023636-5679c8bdb7bf/go.mod h1:ApL/XFs34Gvqinex9Z1sZdsp3Jeu26nNuEsf1wQFx8s=
+github.com/LeeEirc/elfinder v0.0.1 h1:fFVy2xddwB2qQxLxJOGl+1Lj686pnRFnySsjPr7luZ0=
+github.com/LeeEirc/elfinder v0.0.1/go.mod h1:VSfmUhE4Fvv+4Dfyo7Wmi44bdyDuIQgJtyi5EDcDSxE=
 github.com/aliyun/aliyun-oss-go-sdk v1.9.8 h1:BOflvK0Zs/zGmoabyFIzTg5c3kguktWTXEwewwbuba0=
 github.com/aliyun/aliyun-oss-go-sdk v1.9.8/go.mod h1:T/Aws4fEfogEE9v+HPhhw+CntffsBHJ8nXQCwKr0/g8=
 github.com/anmitsu/go-shlex v0.0.0-20161002113705-648efa622239 h1:kFOfPq6dUM1hTo4JG6LR5AXSUEsOjtdm0kw0FtQtMJA=

pkg/httpd/server.go

@@ -7,11 +7,11 @@ import (
 	"time"
 
 	"github.com/gorilla/mux"
-	"github.com/kataras/neffos"
-	"github.com/kataras/neffos/gorilla"
-
+	gorillaws "github.com/gorilla/websocket"
 	"github.com/jumpserver/koko/pkg/config"
 	"github.com/jumpserver/koko/pkg/logger"
+	"github.com/kataras/neffos"
+	"github.com/kataras/neffos/gorilla"
 )
 
 var (
@@ -19,6 +19,12 @@ var (
 	Timeout    = time.Duration(60)
 )
 
+var upgrader = gorilla.Upgrader(gorillaws.Upgrader{
+	CheckOrigin: func(r *http.Request) bool {
+		return true
+	},
+})
+
 var wsEvents = neffos.WithTimeout{
 	ReadTimeout:  Timeout * time.Second,
 	WriteTimeout: Timeout * time.Second,
@@ -50,7 +56,7 @@ var wsEvents = neffos.WithTimeout{
 
 func StartHTTPServer() {
 	conf := config.GetConf()
-	sshWs := neffos.New(gorilla.DefaultUpgrader, wsEvents)
+	sshWs := neffos.New(upgrader, wsEvents)
 	sshWs.IDGenerator = func(w http.ResponseWriter, r *http.Request) string {
 		return neffos.DefaultIDGenerator(w, r)
 	}

pkg/httpd/upgrader.go

-package httpd
-
-import (
-	"net"
-	"net/http"
-	"sync"
-	"time"
-
-	"github.com/kataras/neffos"
-
-	gorilla "github.com/gorilla/websocket"
-)
-
-// DefaultUpgrader is a gorilla/websocket Upgrader with all fields set to the default values.
-var DefaultUpgrader = Upgrader(gorilla.Upgrader{})
-
-// Upgrader is a `neffos.Upgrader` type for the gorilla/websocket subprotocol implementation.
-// Should be used on `New` to construct the neffos server.
-func Upgrader(upgrader gorilla.Upgrader) neffos.Upgrader {
-	return func(w http.ResponseWriter, r *http.Request) (neffos.Socket, error) {
-		header := w.Header()
-		header.Set("Access-Control-Allow-Origin", "*")
-		underline, err := upgrader.Upgrade(w, r, header)
-		if err != nil {
-			return nil, err
-		}
-
-		return newSocket(underline, r, false), nil
-	}
-}
-
-// Socket completes the `neffos.Socket` interface,
-// it describes the underline websocket connection.
-type Socket struct {
-	UnderlyingConn *gorilla.Conn
-	request        *http.Request
-
-	client bool
-
-	mu sync.Mutex
-}
-
-func newSocket(underline *gorilla.Conn, request *http.Request, client bool) *Socket {
-	return &Socket{
-		UnderlyingConn: underline,
-		request:        request,
-		client:         client,
-	}
-}
-
-// NetConn returns the underline net connection.
-func (s *Socket) NetConn() net.Conn {
-	return s.UnderlyingConn.UnderlyingConn()
-}
-
-// Request returns the http request value.
-func (s *Socket) Request() *http.Request {
-	return s.request
-}
-
-// ReadData reads binary or text messages from the remote connection.
-func (s *Socket) ReadData(timeout time.Duration) ([]byte, error) {
-	for {
-		if timeout > 0 {
-			s.UnderlyingConn.SetReadDeadline(time.Now().Add(timeout))
-		}
-
-		opCode, data, err := s.UnderlyingConn.ReadMessage()
-		if err != nil {
-			return nil, err
-		}
-
-		if opCode != gorilla.BinaryMessage && opCode != gorilla.TextMessage {
-			// if gorilla.IsUnexpectedCloseError(err, gorilla.CloseGoingAway) ...
-			continue
-		}
-
-		return data, err
-	}
-}
-
-// WriteBinary sends a binary message to the remote connection.
-func (s *Socket) WriteBinary(body []byte, timeout time.Duration) error {
-	return s.write(body, gorilla.BinaryMessage, timeout)
-}
-
-// WriteText sends a text message to the remote connection.
-func (s *Socket) WriteText(body []byte, timeout time.Duration) error {
-	return s.write(body, gorilla.TextMessage, timeout)
-}
-
-func (s *Socket) write(body []byte, opCode int, timeout time.Duration) error {
-	if timeout > 0 {
-		s.UnderlyingConn.SetWriteDeadline(time.Now().Add(timeout))
-	}
-
-	s.mu.Lock()
-	err := s.UnderlyingConn.WriteMessage(opCode, body)
-	s.mu.Unlock()
-
-	return err
-}

pkg/srvconn/sftpconn.go

@@ -245,6 +245,7 @@ func (u *UserSftp) Remove(path string) error {
 	if conn == nil {
 		return sftp.ErrSshFxPermissionDenied
 	}
+	logger.Debug("remove file path", realPath)
 	err := conn.client.Remove(realPath)
 	filename := realPath
 	isSuccess := false
@@ -391,6 +392,7 @@ func (u *UserSftp) Create(path string) (*sftp.File, error) {
 	if conn == nil {
 		return nil, sftp.ErrSshFxPermissionDenied
 	}
+	logger.Debug("create path:", realPath)
 	sf, err := conn.client.Create(realPath)
 	filename := realPath
 	isSuccess := false
@@ -425,6 +427,7 @@ func (u *UserSftp) Open(path string) (*sftp.File, error) {
 	if conn == nil {
 		return nil, sftp.ErrSshFxPermissionDenied
 	}
+	logger.Debug("Open path:", realPath)
 	sf, err := conn.client.Open(realPath)
 	filename := realPath
 	isSuccess := false